From patchwork Thu Jan 11 03:44:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fangrui Song X-Patchwork-Id: 83819 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9334338582AC for ; Thu, 11 Jan 2024 03:44:59 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by sourceware.org (Postfix) with ESMTPS id 7B2BA3857708 for ; Thu, 11 Jan 2024 03:44:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B2BA3857708 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=flex--maskray.bounces.google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B2BA3857708 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1149 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704944667; cv=none; b=kvprPJoAL0Sl1U37xgX23ozA2GUZr7umyPtcf/W2xGsW4dSwvphLe08TkpoWHoa2MqiES08fcVXe2qhZaOvY+ujyQnQqcrR+WyKqEKG/jJDFBmx6d5pXzf0u085PYesrOnqhHFesNhbHD5z8IiBUlzmdC0EZwSbLdGhNurQjbt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704944667; c=relaxed/simple; bh=4ApR4oMwpTjzK+ZIxy3HYscFA/u8mty95uzXdZb4M/Y=; h=DKIM-Signature:Date:Mime-Version:Message-ID:Subject:From:To; b=ujO1ag1v9CYwhX9QV38DZZ86/m6yeiWDjZErrwAecrGO6N9/ybTpawUSLGeedHB6rS1Vbh44AyP1YzLZ/SYmz1g8tAXhi9uVaoDYxggROgSlemYa6xVuJKxWNmfVNsCeCZinUX9CXW0zD8agcGjtGZrngF1qzcCuBrKW8bjwscI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5ea6aa02fa4so86106407b3.0 for ; Wed, 10 Jan 2024 19:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704944663; x=1705549463; darn=gcc.gnu.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=OSlbZ5aqOrmKAykuusaWvhgzM9Z+UYMGWYoXqIkv94A=; b=sFIOZmlbRD0eOWHOsM9MH9U5RyBiR48o9RgQY311FXIO/825U3gqYCcmK+FXimI6B3 BoR5vMYKIV1EaVZ34sBsJG0qjqMD1jYjISzy2FuWvnSe8CDmQmHqJpfrVD+YjNX31D2M DIDSTOGQ2kC4/73sSujPhs4GLulR7y5vpR6lWRIA9+GWQHIsbpFiAeikteoiZMQJqH1Q KKvCNyBdHdsPMK+Zyu9GYcw7vBQSI2PLBrrfb9dX69ExNmWyLqiYP5++iw/9PxSgs51V Y9YG0V7hWSiN5eYzkqvjop2w7H8UdoCjY39jKl/vMdIXsaET4XWL8H+wDGXtzAiTqg8c ZKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704944663; x=1705549463; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OSlbZ5aqOrmKAykuusaWvhgzM9Z+UYMGWYoXqIkv94A=; b=VY02iPrwRyA3vXMEWrm1c7Rx7i/+hVg6ElqtJY7U7mkH58COr1J2SvotpCjBSKfSAZ 3uEWKTvqnzVmQ74DNjxhJWE9iAsOtWpdAQwjZFGZwOuagQoFdsoQaQEmpd2yJ2XNeM/v t62lrV16/uFoUEOEUF483yLkYok7GBTYnZOP+O4SryfPZprBoShV40dv03m2YuXjtVt5 BNs8lWacnVU3sCWqZ9atil1gWriHMjBqyfMXlBfmW85I/DyDRj9IsorhodnElHGLXFuc lEueTC7JB6+ftKOSop4nq0QTaCvwv+x0liaRu/rJa1ZSK02Q5AYyyg5IyuIKYtiSCmNs l96A== X-Gm-Message-State: AOJu0YwqMC1NYHUF3vLRrjnojVLZ8acEW0UbZevUYXReTBXMC1YKRckt N7mdoX+lGZOFzOexfxXsJI/SrFT3i6M9GJkmlP4= X-Google-Smtp-Source: AGHT+IFCVh11jDhTAZ/DjmgpirixbQoZ28VsRWw2zlOkYmB1m5hgHVWfn1ETEjteHMsoLJZwkswE5FFcFMYl X-Received: from maskray.svl.corp.google.com ([2620:15c:2d3:205:ecd9:ef92:c56d:6d2f]) (user=maskray job=sendgmr) by 2002:a0d:e005:0:b0:5e6:831:c075 with SMTP id j5-20020a0de005000000b005e60831c075mr6169ywe.4.1704944662852; Wed, 10 Jan 2024 19:44:22 -0800 (PST) Date: Wed, 10 Jan 2024 19:44:15 -0800 Mime-Version: 1.0 Message-ID: <20240111034415.431657-1-maskray@google.com> Subject: [PATCH] i386: Add "z" constraint for symbolic address/label reference [PR105576] From: Fangrui Song To: Jan Hubicka , Uros Bizjak , gcc-patches@gcc.gnu.org Cc: Fangrui Song X-Spam-Status: No, score=-19.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Printing the raw symbol is useful in inline asm (e.g. in C++ to get the mangled name). Similar constraints are available in other targets (e.g. "S" for aarch64/riscv, "Cs" for m68k). There isn't a good way for x86 yet, e.g. "i" doesn't work for PIC/-mcmodel=large. This patch adds "z". gcc/ChangeLog: PR target/105576 * config/i386/constraints.md: Define constraint 'z'. * doc/md.texi: Document it. gcc/testsuite/ChangeLog: * gcc.target/i386/asm-raw-symbol.c: New testcase. --- gcc/config/i386/constraints.md | 5 ++++- gcc/doc/md.texi | 4 ++++ gcc/testsuite/gcc.target/i386/asm-raw-symbol.c | 13 +++++++++++++ 3 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/asm-raw-symbol.c diff --git a/gcc/config/i386/constraints.md b/gcc/config/i386/constraints.md index 0c6e662df25..64330dfdf01 100644 --- a/gcc/config/i386/constraints.md +++ b/gcc/config/i386/constraints.md @@ -19,7 +19,6 @@ ;;; Unused letters: ;;; H -;;; z ;; Integer register constraints. ;; It is not necessary to define 'r' here. @@ -438,3 +437,7 @@ (define_constraint "je" "@internal constant that do not allow any unspec global offsets" (and (match_operand 0 "x86_64_immediate_operand") (match_test "!x86_poff_operand_p (op)"))) + +(define_constraint "z" + "A symbolic reference or label reference." + (match_code "const,symbol_ref,label_ref")) diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi index 47a87d6ceec..bbfec024311 100644 --- a/gcc/doc/md.texi +++ b/gcc/doc/md.texi @@ -4286,6 +4286,10 @@ VSIB address operand. @item Ts Address operand without segment register. +@item z +A symbolic reference or label reference. +You can use the @code{%p} modifier to print the raw symbol. + @end table @item Xstormy16---@file{config/stormy16/stormy16.h} diff --git a/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c b/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c new file mode 100644 index 00000000000..ce88f3baee6 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ + +extern int var; + +void +func (void) +{ + __asm__ ("@ %p0" : : "z" (func)); + __asm__ ("@ %p0" : : "z" (&var + 1)); +} + +/* { dg-final { scan-assembler "@ func" } } */ +/* { dg-final { scan-assembler "@ var\\+4" } } */