From patchwork Tue Jan 9 10:51:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 83607 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DFE6B3858414 for ; Tue, 9 Jan 2024 10:53:47 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E2A803858CDB; Tue, 9 Jan 2024 10:53:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2A803858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E2A803858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704797587; cv=none; b=ZwU204oDDz+QpJxGa/vUdSI2F3TAmhcuZlsW6ASP6WT5NvQhJ1Mb8yTD28HtyL+DsWMwaH8pMeN4U0mXYLGP7fCqU7hxc+DDQB7brZBg5QtiqZHfiM8ZdkFWTLI+HXxU2HbjKCN2l8Z4h9wmjCcvlZZS/Jtfq/8/zyG5Ix+LBqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704797587; c=relaxed/simple; bh=wH8R7hMP2kftqbct95Waa6ogAnYvAqOuk2w+bNPVRJo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aG4Ns1Q4A87yN97yslEtNGc0DM2MmwsCne2iLDOpkXRcthNfLOc1yxL47ClCUHuxVgDymWCzzmEeqHlW54uqN2gPY+SmmVhAouU7bpzGw/iFDWU/aFuC5CrVu+sdOKgGbK0BP6652iMKk62bqggQWnFfES2CrGxKb6Z8uEvWuYE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4099vK4e010191; Tue, 9 Jan 2024 10:53:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=+6m2EB8iPnvXvvTSIl+cynRZiUbJrzYbN97fOdgl6Dk=; b=CmEIlQsUDwSzru6ccBaTfhj3y9M5QMmcqBveFtabKC/GLV1seuQofcdrAN3pnh/tsere qv9HrEOQ1j6yYqCud+QsMLAOOs8Q0La/u3ry1s35+166IMp1sErU9OFtXDySl9bdx/EN gTr414z0NaZ12i+f0Jw/rHaX57y/VcMtPEWUR0iVkK5TMCWupuaglBi8vkPEcpN7NNh9 pv3IvLSArEcg0WZH4ZIqVUSu/5wCcnoToxrcnSPF2PrQ3uMwWhHhjLQ8R4VNfjpiSGLR YxK9mAgBBxVkc76R+MJAEmXOc4MK0k+f2pAJXAgaOo2JlRWt+S8QDfXm+MQaDtY4/JZ3 UA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vh3y71crw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 10:53:04 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 409AOhal030450; Tue, 9 Jan 2024 10:53:03 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vh3y71cqw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 10:53:03 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4098eVTs000898; Tue, 9 Jan 2024 10:53:02 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3vfkdk5qhh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 10:53:02 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 409AqxTU31392444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Jan 2024 10:52:59 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C184D2004B; Tue, 9 Jan 2024 10:52:59 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 40ADC20040; Tue, 9 Jan 2024 10:52:59 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.171.15.162]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 9 Jan 2024 10:52:59 +0000 (GMT) From: Ilya Leoshkevich To: Jeff Law , Jakub Jelinek Cc: seurer@gcc.gnu.org, Andreas Krebbel , gcc-patches@gcc.gnu.org, Stefan Schulze Frielinghaus , Ilya Leoshkevich Subject: [PATCH] rs6000: Fix ASAN linker errors for Power ELF V1 ABI [PR113284] Date: Tue, 9 Jan 2024 11:51:16 +0100 Message-ID: <20240109105253.332676-1-iii@linux.ibm.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Pk771X8AWy2FVuI2eSL-VyaE-C7mKPF6 X-Proofpoint-ORIG-GUID: V7IUzFPIjIwpZ2OSRlWYjAhsZuydCaTp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-09_03,2024-01-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 malwarescore=0 clxscore=1011 mlxlogscore=964 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401090088 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Bootstrap and regtest running on ppc64le-redhat-linux and powerpc64-linux-gnu. Ok for trunk when successful? Use ASM_OUTPUT_FUNCTION_LABEL () instead of ASM_OUTPUT_LABEL () in the Power ELF V1 ABI branch of rs6000_elf_declare_function_name () to ensure that the .LASANPC label is emitted. The other branches already use the correct macro. Fixes: c659dd8bfb55 ("Implement ASM_DECLARE_FUNCTION_NAME using ASM_OUTPUT_FUNCTION_LABEL") Signed-off-by: Ilya Leoshkevich gcc/ChangeLog: PR sanitizer/113284 * config/rs6000/rs6000.cc (rs6000_elf_declare_function_name): Use ASM_OUTPUT_FUNCTION_LABEL () for Power ELF V1 ABI. --- gcc/config/rs6000/rs6000.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index 94fbf46f2b6..fd9bb807957 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -21334,7 +21334,7 @@ rs6000_elf_declare_function_name (FILE *file, const char *name, tree decl) if (TARGET_64BIT && DEFAULT_ABI != ABI_ELFv2) { fputs ("\t.section\t\".opd\",\"aw\"\n\t.align 3\n", file); - ASM_OUTPUT_LABEL (file, name); + ASM_OUTPUT_FUNCTION_LABEL (file, name, decl); fputs (DOUBLE_INT_ASM_OP, file); rs6000_output_function_entry (file, name); fputs (",.TOC.@tocbase,0\n\t.previous\n", file);