From patchwork Wed Dec 13 08:44:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 82033 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 38028386074B for ; Wed, 13 Dec 2023 08:46:10 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 656473858D39 for ; Wed, 13 Dec 2023 08:45:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 656473858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 656473858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702457155; cv=none; b=YpfiYcHFn67AJklnjcuudJQzJ0xBrc+8tjMNX7FbJpUu9jwfg1mJhbXANiehTfobv8xSzZkGpwFoIi2DC1BjdIQksA9eEgINlmJ47SClLWMx1JWDwagjcqwF3P9Nru0B9BrYbpJFnpB4yZDgPNZfUaP49HuZzoKy7LyCh6ts3CE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702457155; c=relaxed/simple; bh=yUYvoPJqvdWQmyfgsTihFmjImiFX32074MYOccb9yDE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=Vt+Uk4s2ZyIW+q72ka/DRvEShsDtIIgzF/uJqH9yML3BUkRpSJ1w80vXSiat3pSCK2J2q0/0149Oehz2aHRdxRP8UodHoe2Gr3r8oJYYcfiHcPlduHbIdVEF137EdoGx2/p3Z/BAUVym+S8ZoQGrtcU8q8SgKBNSZRUnTt6yWjg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 69ABC21E54 for ; Wed, 13 Dec 2023 08:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702457153; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=AggdV/6UbvMS9KFWgcnKY1s/y/jdFW0KZc3VmjV7AMQ=; b=QyUb687H2d1+u9dk7SoAdJnR3RD96KKeYCo4b9ssfOUwdbH5IsSJ7hKaAo5efvn4hf8K1+ ADVRjUdnah/W3HS6fjt21tYEIbz5i5GXdZuPFPK0KW9zvltKgbBcxT4gWzpagjZakjQ0Mh OdYguetCdGHregWqtlVEUFUxa46Nvwo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702457153; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=AggdV/6UbvMS9KFWgcnKY1s/y/jdFW0KZc3VmjV7AMQ=; b=JpHEW2jZ6TbJIPlCX7fdT4q18OuLyBpY7oSq9c3ddMFEyufUNdzuqdCAnyhiIQf45XM6KM VRwl9raTPHJFEUCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702457153; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=AggdV/6UbvMS9KFWgcnKY1s/y/jdFW0KZc3VmjV7AMQ=; b=QyUb687H2d1+u9dk7SoAdJnR3RD96KKeYCo4b9ssfOUwdbH5IsSJ7hKaAo5efvn4hf8K1+ ADVRjUdnah/W3HS6fjt21tYEIbz5i5GXdZuPFPK0KW9zvltKgbBcxT4gWzpagjZakjQ0Mh OdYguetCdGHregWqtlVEUFUxa46Nvwo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702457153; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=AggdV/6UbvMS9KFWgcnKY1s/y/jdFW0KZc3VmjV7AMQ=; b=JpHEW2jZ6TbJIPlCX7fdT4q18OuLyBpY7oSq9c3ddMFEyufUNdzuqdCAnyhiIQf45XM6KM VRwl9raTPHJFEUCg== Date: Wed, 13 Dec 2023 09:44:50 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/112990 - unsupported VEC_PERM from match pattern MIME-Version: 1.0 X-Spam-Score: 1.40 Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 4.46 X-Spamd-Result: default: False [4.46 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.71)[-0.713]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_SPAM_SHORT(2.79)[0.931]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.02)[54.27%] X-Spam-Flag: NO X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Message-Id: <20231213084610.38028386074B@sourceware.org> The following avoids creating an unsupported VEC_PERM after vector lowering from the pattern merging a bit-insert from a bit-field-ref to a VEC_PERM. For the already existing s390 testcase we get TImode vectors which later ICE during attempted expansion of a vec_perm_const. Pushed accidentially before bootstrap / testing finished which is still ongoing on x86-64_unknown-linux-gnu. Will revert in the event that goes wrong (not expecting that). Richard. PR tree-optimization/112990 * match.pd (bit_insert @0 (BIT_FIELD_REF @1 ..) ..): Restrict to vector modes after lowering. --- gcc/match.pd | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/match.pd b/gcc/match.pd index 15bca217aaf..e3dcff5c29c 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -8505,6 +8505,8 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (simplify (bit_insert @0 (BIT_FIELD_REF@2 @1 @rsize @rpos) @ipos) (if (VECTOR_TYPE_P (type) + && (VECTOR_MODE_P (TYPE_MODE (type)) + || optimize_vectors_before_lowering_p ()) && types_match (@0, @1) && types_match (TREE_TYPE (TREE_TYPE (@0)), TREE_TYPE (@2)) && TYPE_VECTOR_SUBPARTS (type).is_constant ())