From patchwork Mon Dec 11 17:04:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Stubbs X-Patchwork-Id: 81922 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8B7CE385DC3D for ; Mon, 11 Dec 2023 17:05:29 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 6A13C3858293 for ; Mon, 11 Dec 2023 17:04:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A13C3858293 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A13C3858293 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.137.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702314274; cv=none; b=bXdSM/49AKBbp7e7I0BXZVdPSis6e/1J5UNWdl33ECcfeXKS4qsFfCAKwpkDfn6dWIKL/Dfz7VndQVyxc6jAV2dj1rPK1KdiWtsqQ6XAfDOCXeEkW+Fw1/U/1hqcS1P6nQzmjNw57AkMzWmwHmmwoRsE0Z9atfYQBhPcJyGRkfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702314274; c=relaxed/simple; bh=HmGcZ5ReUYFPoJvoukrgMUGJsw5zOcJ2RfsH/Su6acQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=N8Bz+NDrpXtbtuXF0a3ZMp60BH7zemqDqhqEqRa/CgJvN+dZb3r86a7z/emAc6BMrwb9E3MOvoeIBvhGtvNDhATlRUzrgzH/kDEOh/T4zblejQr7Eiid1Fcxvq55Y+yyUQdWF064xvOSkGUyO1rpHB/nV7SbPs6ZT+z/PBj1Z7I= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: 0IGxXY0YRhSUutFv22ANCg== X-CSE-MsgGUID: zxkhOnzcQ0W8gwD+K9Uy+A== X-IronPort-AV: E=Sophos;i="6.04,268,1695715200"; d="scan'208";a="25008320" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 11 Dec 2023 09:04:32 -0800 IronPort-SDR: lCDcwEHCQa+qlu9TDbGIN17Cv1X9mzilbPxywRqt5fG07TKXh981WM7LwevuhocSAGhhRxfDly P0ObizU1np9bagiMcqRFsexdFJme43YIqfqThyv8E+6bGUcXVfnUHNf123XugjSbTdYpp6AYsd DI0ToMGaBqEqypuLo057Ii+pl5a1sPaPgUx0wBiUiioc3n7N67e/ZxGPKbbaOqsaQZlY8/tV71 p0odUdE0Gd/ZadfCf31mJuteTY2j37pVdVqrl7K+iSs51z+sgFJHqJ9NX53VY7ped54SXwb6B7 /HY= From: Andrew Stubbs To: Subject: [PATCH v3 3/6] openmp: Add -foffload-memory Date: Mon, 11 Dec 2023 17:04:02 +0000 Message-ID: <20231211170405.2538247-4-ams@codesourcery.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231211170405.2538247-1-ams@codesourcery.com> References: <20231211170405.2538247-1-ams@codesourcery.com> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Add a new option. It's inactive until I add some follow-up patches. gcc/ChangeLog: * common.opt: Add -foffload-memory and its enum values. * coretypes.h (enum offload_memory): New. * doc/invoke.texi: Document -foffload-memory. --- gcc/common.opt | 16 ++++++++++++++++ gcc/coretypes.h | 7 +++++++ gcc/doc/invoke.texi | 16 +++++++++++++++- 3 files changed, 38 insertions(+), 1 deletion(-) diff --git a/gcc/common.opt b/gcc/common.opt index 5eb5ecff04b..a008827cfa2 100644 --- a/gcc/common.opt +++ b/gcc/common.opt @@ -2332,6 +2332,22 @@ Enum(offload_abi) String(ilp32) Value(OFFLOAD_ABI_ILP32) EnumValue Enum(offload_abi) String(lp64) Value(OFFLOAD_ABI_LP64) +foffload-memory= +Common Joined RejectNegative Enum(offload_memory) Var(flag_offload_memory) Init(OFFLOAD_MEMORY_NONE) +-foffload-memory=[none|unified|pinned] Use an offload memory optimization. + +Enum +Name(offload_memory) Type(enum offload_memory) UnknownError(Unknown offload memory option %qs) + +EnumValue +Enum(offload_memory) String(none) Value(OFFLOAD_MEMORY_NONE) + +EnumValue +Enum(offload_memory) String(unified) Value(OFFLOAD_MEMORY_UNIFIED) + +EnumValue +Enum(offload_memory) String(pinned) Value(OFFLOAD_MEMORY_PINNED) + fomit-frame-pointer Common Var(flag_omit_frame_pointer) Optimization When possible do not generate stack frames. diff --git a/gcc/coretypes.h b/gcc/coretypes.h index fe5b868fb4f..fb4bf37ba24 100644 --- a/gcc/coretypes.h +++ b/gcc/coretypes.h @@ -218,6 +218,13 @@ enum offload_abi { OFFLOAD_ABI_ILP32 }; +/* Types of memory optimization for an offload device. */ +enum offload_memory { + OFFLOAD_MEMORY_NONE, + OFFLOAD_MEMORY_UNIFIED, + OFFLOAD_MEMORY_PINNED +}; + /* Types of profile update methods. */ enum profile_update { PROFILE_UPDATE_SINGLE, diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 43341fe6e5e..f6a7459bda7 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -202,7 +202,7 @@ in the following sections. -fno-builtin -fno-builtin-@var{function} -fcond-mismatch -ffreestanding -fgimple -fgnu-tm -fgnu89-inline -fhosted -flax-vector-conversions -fms-extensions --foffload=@var{arg} -foffload-options=@var{arg} +-foffload=@var{arg} -foffload-options=@var{arg} -foffload-memory=@var{arg} -fopenacc -fopenacc-dim=@var{geom} -fopenmp -fopenmp-simd -fopenmp-target-simd-clone@r{[}=@var{device-type}@r{]} -fpermitted-flt-eval-methods=@var{standard} @@ -2766,6 +2766,20 @@ Typical command lines are -foffload-options=amdgcn-amdhsa=-march=gfx906 @end smallexample +@opindex foffload-memory +@cindex OpenMP offloading memory modes +@item -foffload-memory=none +@itemx -foffload-memory=unified +@itemx -foffload-memory=pinned +Enable a memory optimization mode to use with OpenMP. The default behavior, +@option{-foffload-memory=none}, is to do nothing special (unless enabled via +a requires directive in the code). @option{-foffload-memory=unified} is +equivalent to @code{#pragma omp requires unified_shared_memory}. +@option{-foffload-memory=pinned} forces all host memory to be pinned (this +mode may require the user to increase the ulimit setting for locked memory). +All translation units must select the same setting to avoid undefined +behavior. + @opindex fopenacc @cindex OpenACC accelerator programming @item -fopenacc