From patchwork Mon Dec 4 13:24:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 81281 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 96A943870921 for ; Mon, 4 Dec 2023 13:24:51 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id E57EE3865C25 for ; Mon, 4 Dec 2023 13:24:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E57EE3865C25 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E57EE3865C25 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701696275; cv=none; b=xSw7b10eTG71nCGtxD8jYMloaj1DmgagUS0m3fCmtRnkBV96fOUP+pRId1r7xnCQOk710j04enXSvvxfttkVjemccRELG/36f9NE8J/QsX6WTnGg6Wmi5lDHbNEvHj1oGwLg6WiOG08+Iv7R9MWtTbtbCY8U04ce+l8IbLNvuv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701696275; c=relaxed/simple; bh=D+SYW5+1O8DIyBw5uGQrbUGr2oFLyno/dJYfrYx06j0=; h=Date:From:To:Subject:MIME-Version:Message-Id; b=eHtwlN2MSRVy9RUtyDN0kz8G2bl2Rsv3zKapEBzo5Faz+90ngxRBkA7fyDbOA7CHNPGOWiUtA5jLdHU/baera6YnllEvP4bmOHS7qEKyvin99K8hLADP5nonvfMyiLG6DBUDKc5eO1nmhmEoZ721lGLZn/ITgMhj0iiW6N1M1f4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CD68421BDA; Mon, 4 Dec 2023 13:24:29 +0000 (UTC) Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id AB3CA13588; Mon, 4 Dec 2023 13:24:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id Dv0OKA3TbWVpdwAAn2gu4w (envelope-from ); Mon, 04 Dec 2023 13:24:29 +0000 Date: Mon, 4 Dec 2023 14:24:29 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: "Joseph S. Myers" Subject: [PATCH] c/89270 - honor registered_builtin_types in type_for_size MIME-Version: 1.0 Message-Id: <20231204132429.AB3CA13588@imap2.dmz-prg2.suse.org> X-Spamd-Bar: ++++++++++ X-Spam-Score: 10.81 X-Rspamd-Server: rspamd1 Authentication-Results: smtp-out1.suse.de; dkim=none; spf=softfail (smtp-out1.suse.de: 2a07:de40:b281:104:10:150:64:98 is neither permitted nor denied by domain of rguenther@suse.de) smtp.mailfrom=rguenther@suse.de; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none) X-Rspamd-Queue-Id: CD68421BDA X-Spamd-Result: default: False [10.81 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(4.60)[~all:c]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(2.20)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-2.48)[97.66%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(3.00)[1.000]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_LONG(3.50)[1.000]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org The following fixes the intermediate conversions inserted by convert_to_integer when facing address-spaces and converts to their effective [u]intptr_t when they are registered_builtin_types by considering those also from c_common_type_for_size and not only from c_common_type_for_mode. Bootstrap and regtest on x86_64-unknown-linux-gnu, OK? Thanks, Richard. PR c/89270 gcc/c-family/ * c-common.cc (c_common_type_for_size): Consider registered_builtin_types. gcc/testsuite/ * gcc.target/avr/pr89270.c: New testcase. --- gcc/c-family/c-common.cc | 9 +++++++++ gcc/testsuite/gcc.target/avr/pr89270.c | 7 +++++++ 2 files changed, 16 insertions(+) create mode 100644 gcc/testsuite/gcc.target/avr/pr89270.c diff --git a/gcc/c-family/c-common.cc b/gcc/c-family/c-common.cc index b2b70c99338..d175054dddb 100644 --- a/gcc/c-family/c-common.cc +++ b/gcc/c-family/c-common.cc @@ -2362,6 +2362,15 @@ c_common_type_for_size (unsigned int bits, int unsignedp) return (unsignedp ? widest_unsigned_literal_type_node : widest_integer_literal_type_node); + for (tree t = registered_builtin_types; t; t = TREE_CHAIN (t)) + { + tree type = TREE_VALUE (t); + if (TREE_CODE (type) == INTEGER_TYPE + && bits == TYPE_PRECISION (type) + && !!unsignedp == !!TYPE_UNSIGNED (type)) + return type; + } + if (bits <= TYPE_PRECISION (intQI_type_node)) return unsignedp ? unsigned_intQI_type_node : intQI_type_node; diff --git a/gcc/testsuite/gcc.target/avr/pr89270.c b/gcc/testsuite/gcc.target/avr/pr89270.c new file mode 100644 index 00000000000..2b6e4a8aa5b --- /dev/null +++ b/gcc/testsuite/gcc.target/avr/pr89270.c @@ -0,0 +1,7 @@ +/* { dg-do compile } */ + +void test() +{ + extern const unsigned char __memx __data_load_end; + __uint24 top=(__uint24)&__data_load_end; +}