diff mbox series

[v14,38/40] libstdc++: Optimize is_signed trait performance

Message ID	20230915235353.19378-39-kmatsui@gcc.gnu.org
State	Superseded
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 385423856243 To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org> Subject: [PATCH v14 38/40] libstdc++: Optimize is_signed trait performance Date: Fri, 15 Sep 2023 16:51:24 -0700 Message-ID: <20230915235353.19378-39-kmatsui@gcc.gnu.org> In-Reply-To: <20230915235353.19378-1-kmatsui@gcc.gnu.org> References: <20230915023640.75216-17-kmatsui@gcc.gnu.org> <20230915235353.19378-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Ken Matsui via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Ken Matsui <kmatsui@gcc.gnu.org> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org>
Series	Optimize type traits performance \| [v14,00/40] Optimize type traits performance [v14,01/40] c++: Sort built-in identifiers alphabetically [v14,02/40] c++: Implement __is_const built-in trait [v14,03/40] libstdc++: Optimize is_const trait performance [v14,04/40] c++: Implement __is_volatile built-in trait [v14,05/40] libstdc++: Optimize is_volatile trait performance [v14,06/40] c++: Implement __is_array built-in trait [v14,07/40] libstdc++: Optimize is_array trait performance [v14,08/40] c++: Implement __is_unbounded_array built-in trait [v14,09/40] libstdc++: Optimize is_unbounded_array trait performance [v14,10/40] c++: Implement __is_bounded_array built-in trait [v14,11/40] libstdc++: Optimize is_bounded_array trait performance [v14,12/40] c++: Implement __is_scoped_enum built-in trait [v14,13/40] libstdc++: Optimize is_scoped_enum trait performance [v14,14/40] c++: Implement __is_member_pointer built-in trait [v14,15/40] libstdc++: Optimize is_member_pointer trait performance [v14,16/40] c, c++: Use 16 bits for all use of enum rid for more keyword space [v14,17/40] c-family: Fix C_SET_RID_CODE to handle 16-bit rid code correctly [v14,18/40] c++: Implement __is_member_function_pointer built-in trait [v14,19/40] libstdc++: Optimize is_member_function_pointer trait performance [v14,20/40] c++: Implement __is_member_object_pointer built-in trait [v14,21/40] libstdc++: Optimize is_member_object_pointer trait performance [v14,22/40] c++: Implement __is_reference built-in trait [v14,23/40] libstdc++: Optimize is_reference trait performance [v14,24/40] c++: Implement __is_function built-in trait [v14,25/40] libstdc++: Optimize is_function trait performance [v14,26/40] libstdc++: Optimize is_object trait performance [v14,27/40] c++: Implement __remove_pointer built-in trait [v14,28/40] libstdc++: Optimize remove_pointer trait performance [v14,29/40] c++, libstdc++: Implement __is_pointer built-in trait [v14,30/40] libstdc++: Optimize is_pointer trait performance [v14,31/40] c++, libstdc++: Implement __is_arithmetic built-in trait [v14,32/40] libstdc++: Optimize is_arithmetic trait performance [v14,33/40] libstdc++: Optimize is_fundamental trait performance [v14,34/40] libstdc++: Optimize is_compound trait performance [v14,35/40] c++: Implement __is_unsigned built-in trait [v14,36/40] libstdc++: Optimize is_unsigned trait performance [v14,37/40] c++, libstdc++: Implement __is_signed built-in trait [v14,38/40] libstdc++: Optimize is_signed trait performance [v14,39/40] c++, libstdc++: Implement __is_scalar built-in trait [v14,40/40] libstdc++: Optimize is_scalar trait performance

Checks

Context	Check	Description
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64	success	Testing passed
linaro-tcwg-bot/tcwg_gcc_build--master-arm	success	Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64	success	Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm	success	Testing passed

Commit Message

Ken Matsui Sept. 15, 2023, 11:51 p.m. UTC

  This patch optimizes the performance of the is_signed trait by dispatching to
the new __is_signed built-in trait.

libstdc++-v3/ChangeLog:

	* include/std/type_traits (is_signed): Use __is_signed built-in trait.
	(is_signed_v): Likewise.

Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
 libstdc++-v3/include/std/type_traits | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits
index f7d3815f332..7e93923f44b 100644
--- a/libstdc++-v3/include/std/type_traits
+++ b/libstdc++-v3/include/std/type_traits
@@ -982,6 +982,13 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
     : public __bool_constant<__is_abstract(_Tp)>
     { };
 
+  /// is_signed
+#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_signed)
+  template<typename _Tp>
+    struct is_signed
+    : public __bool_constant<__is_signed(_Tp)>
+    { };
+#else
   /// @cond undocumented
   template<typename _Tp,
 	   bool = is_arithmetic<_Tp>::value>
@@ -994,11 +1001,11 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
     { };
   /// @endcond
 
-  /// is_signed
   template<typename _Tp>
     struct is_signed
     : public __is_signed_helper<_Tp>::type
     { };
+#endif
 
   /// is_unsigned
 #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_unsigned)
@@ -3445,8 +3452,13 @@  template <typename _Tp>
 template <typename _Tp>
   inline constexpr bool is_final_v = __is_final(_Tp);
 
+#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_signed)
+template <typename _Tp>
+  inline constexpr bool is_signed_v = __is_signed(_Tp);
+#else
 template <typename _Tp>
   inline constexpr bool is_signed_v = is_signed<_Tp>::value;
+#endif
 
 #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_unsigned)
 template <typename _Tp>