diff mbox series

[2/3] RISC-V: Add missing torture-init and torture-finish for rvv.exp

Message ID 20230531162534.119952-3-vineetg@rivosinc.com
State Dropped
Headers
Series Unbork testsuite for multlib setups |

Commit Message

Vineet Gupta May 31, 2023, 4:25 p.m. UTC 
  From: Kito Cheng <kito.cheng@sifive.com>

This is in line with recent test harness expectations and is a
preventive change as it doesn't actually fix any errors.

gcc/testsuite/ChangeLog:

	* gcc.target/riscv/rvv/rvv.exp: Add torture-init and
	torture-finish.

Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
---
 gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Schwinge June 1, 2023, 11:53 a.m. UTC | #1 
Hi!

On 2023-05-31T09:25:33-0700, Vineet Gupta <vineetg@rivosinc.com> wrote:
> From: Kito Cheng <kito.cheng@sifive.com>
>
> This is in line with recent test harness expectations and is a
> preventive change as it doesn't actually fix any errors.
>
> gcc/testsuite/ChangeLog:
>
>       * gcc.target/riscv/rvv/rvv.exp: Add torture-init and
>       torture-finish.
>
> Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
> ---
>  gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> index 5e69235a268c..7ab7456d1d15 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> @@ -39,6 +39,7 @@ if [istarget riscv32-*-*] then {
>
>  # Initialize `dg'.
>  dg-init
> +torture-init
>
>  # Main loop.
>  set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3"
> @@ -90,5 +91,7 @@ foreach op $AUTOVEC_TEST_OPTS {
>  dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/autovec/vls-vlmax/*.\[cS\]]] \
>       "-std=c99 -O3 -ftree-vectorize --param riscv-autovec-preference=fixed-vlmax" $CFLAGS
>
> +torture-finish
> +
>  # All done.
>  dg-finish

I suggest to drop this patch: 'gcc.target/riscv/rvv/rvv.exp' isn't doing
anything with torture testing flags etc., but (in addition to
'dg-runtest') just calls 'gcc-dg-runtest', which internally does
'torture-init', 'torture-finish' -- like in a number of other '*.exp'
files.  As you say, this patch "doesn't actually fix any errors".


Grüße
 Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
Jeff Law June 1, 2023, 2:54 p.m. UTC | #2 
On 5/31/23 10:25, Vineet Gupta wrote:
> From: Kito Cheng <kito.cheng@sifive.com>
> 
> This is in line with recent test harness expectations and is a
> preventive change as it doesn't actually fix any errors.
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.target/riscv/rvv/rvv.exp: Add torture-init and
> 	torture-finish.
Thomas's recommendation was to drop this as it doesn't change any 
observed behavior.  Do you agree with that recommendation?

jeff
Vineet Gupta June 1, 2023, 7:33 p.m. UTC | #3 
On 6/1/23 07:54, Jeff Law wrote:
>
>
> On 5/31/23 10:25, Vineet Gupta wrote:
>> From: Kito Cheng <kito.cheng@sifive.com>
>>
>> This is in line with recent test harness expectations and is a
>> preventive change as it doesn't actually fix any errors.
>>
>> gcc/testsuite/ChangeLog:
>>
>>     * gcc.target/riscv/rvv/rvv.exp: Add torture-init and
>>     torture-finish.
> Thomas's recommendation was to drop this as it doesn't change any 
> observed behavior.  Do you agree with that recommendation?

Yep dropped now.

Thx,
-Vineet
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
index 5e69235a268c..7ab7456d1d15 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
+++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
@@ -39,6 +39,7 @@  if [istarget riscv32-*-*] then {
 
 # Initialize `dg'.
 dg-init
+torture-init
 
 # Main loop.
 set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3"
@@ -90,5 +91,7 @@  foreach op $AUTOVEC_TEST_OPTS {
 dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/autovec/vls-vlmax/*.\[cS\]]] \
 	"-std=c99 -O3 -ftree-vectorize --param riscv-autovec-preference=fixed-vlmax" $CFLAGS
 
+torture-finish
+
 # All done.
 dg-finish