From patchwork Thu May 25 10:23:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Zissulescu Ianculescu X-Patchwork-Id: 70064 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FE06385842C for ; Thu, 25 May 2023 10:24:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FE06385842C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1685010245; bh=Dmh2Dd7f7AswddWaKoQCz8DWAqU69fWgg76s2cxKh+0=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=GA1RV6X/x1l7JDx5tuzn88gg6k3YOJOkjppjLXUQgZDNppU85uNNpiCSLhE1iOTxq ODy4vlknsgVw2hB2LokgGz8hANNKJ6xEYlQD/x9PLof4TTU7Pkeb8r5OkjspJ+Th73 0vnCAlo8ar6OXXDDlJgh+Y0qGllFQ85Smj/KEsaQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 4C6053858D32 for ; Thu, 25 May 2023 10:23:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C6053858D32 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-30950eecc1eso1909427f8f.0 for ; Thu, 25 May 2023 03:23:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685010212; x=1687602212; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Dmh2Dd7f7AswddWaKoQCz8DWAqU69fWgg76s2cxKh+0=; b=A3+OOQiFGM7No6kHxr3oOMMGfNjHlCnothg0Q2CbszBZ5pHrE7SqJdQv8WbTlNZqO1 vEHk5uCa4zx7TO4cTZ70HcoXhXCuAESZguUkncxQb3CRp94Jmhq/fkOXJGop52RBel1h 1h1/ZZNhyrk+mX/o71zGxk6JbA3doGhGXNU802Xd+GqqkI8iicx+PsFVQoR8Zvx25b2D ZOc39AdgKywX5z8E4jHCvXHe0WnR7J1mtmQ37dNoKwwCdian/bnYihDInxNUmAXz0QIr 2IjMW3mo1JLC28K8s6qh2knH1vYQ/jcje9zpB50SC2SRKTrDY0/h9qAMQjhxf1yudgl5 +IWQ== X-Gm-Message-State: AC+VfDxIeIVLCmWMAnqvZqmdBPzBTl6YcewMLRI69QUpscTcCk1ilpG4 ahUVa4Q3or1wxgVWgYxVyXyb8GcodqTNxw== X-Google-Smtp-Source: ACHHUZ7Jo91JmxdpR8QfLSyCp3v+zOpNdXYCeLTFiBDBjC6fK64ryNJvsLS4d9MJCmZ7ON5/f+eSTQ== X-Received: by 2002:a5d:53cb:0:b0:309:3bb5:7968 with SMTP id a11-20020a5d53cb000000b003093bb57968mr2017295wrw.16.1685010212132; Thu, 25 May 2023 03:23:32 -0700 (PDT) Received: from fatty.nomansland ([193.187.151.25]) by smtp.gmail.com with ESMTPSA id a18-20020adfe5d2000000b003079c402762sm1306203wrn.19.2023.05.25.03.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 03:23:31 -0700 (PDT) To: gcc-patches@gcc.gnu.org Cc: fbedard@synopsys.com Subject: [committed] arc: Make TLS Local Dynamic work like Global Dynamic model Date: Thu, 25 May 2023 13:23:30 +0300 Message-Id: <20230525102330.3637874-1-claziss@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Claudiu Zissulescu via Gcc-patches From: Claudiu Zissulescu Ianculescu Reply-To: Claudiu Zissulescu Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Current ARC's TLS Local Dynamic model is using two anchors to access data, namely `.tdata` and `.tbss`. This implementation is unnecessary complicated. However, the TLS Local Dynamic model has better results using Global Dynamic model and anchors. gcc/ChangeLog; * config/arc/arc.cc (arc_call_tls_get_addr): Simplify access using TLS Local Dynamic. Signed-off-by: Claudiu Zissulescu --- gcc/config/arc/arc.cc | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/gcc/config/arc/arc.cc b/gcc/config/arc/arc.cc index dd012ffa975..fef8a504f77 100644 --- a/gcc/config/arc/arc.cc +++ b/gcc/config/arc/arc.cc @@ -6257,8 +6257,6 @@ arc_call_tls_get_addr (rtx ti) return ret; } -#define DTPOFF_ZERO_SYM ".tdata" - /* Return a legitimized address for ADDR, which is a SYMBOL_REF with tls_model MODEL. */ @@ -6267,37 +6265,17 @@ arc_legitimize_tls_address (rtx addr, enum tls_model model) { rtx tmp; - if (!flag_pic && model == TLS_MODEL_LOCAL_DYNAMIC) - model = TLS_MODEL_LOCAL_EXEC; - - /* The TP pointer needs to be set. */ gcc_assert (arc_tp_regno != -1); switch (model) { case TLS_MODEL_GLOBAL_DYNAMIC: + case TLS_MODEL_LOCAL_DYNAMIC: tmp = gen_reg_rtx (Pmode); emit_move_insn (tmp, arc_unspec_offset (addr, UNSPEC_TLS_GD)); return arc_call_tls_get_addr (tmp); - case TLS_MODEL_LOCAL_DYNAMIC: - rtx base; - tree decl; - const char *base_name; - - decl = SYMBOL_REF_DECL (addr); - base_name = DTPOFF_ZERO_SYM; - if (decl && bss_initializer_p (decl)) - base_name = ".tbss"; - - base = gen_rtx_SYMBOL_REF (Pmode, base_name); - tmp = gen_reg_rtx (Pmode); - emit_move_insn (tmp, arc_unspec_offset (base, UNSPEC_TLS_GD)); - base = arc_call_tls_get_addr (tmp); - return gen_rtx_PLUS (Pmode, force_reg (Pmode, base), - arc_unspec_offset (addr, UNSPEC_TLS_OFF)); - case TLS_MODEL_INITIAL_EXEC: addr = arc_unspec_offset (addr, UNSPEC_TLS_IE); addr = copy_to_mode_reg (Pmode, gen_const_mem (Pmode, addr));