From patchwork Mon Mar 13 19:00:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 66311 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD2283857C4F for ; Mon, 13 Mar 2023 19:00:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD2283857C4F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678734059; bh=d2fm1ayOVBfd7iIirGy353Xrp229jCStsP4pk/bMGbs=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=bAHwRMqdso3g2384dyCXTH+5+Jbj2biL0mDOgcqOi8sRgOxcyjtPundZ/20Ws8u/F CnutqyEmlHdvvYVMz65MkNdeMSInnpEWN+HYVJS2gXKbTbBBrZVzX4FIznIfxnEFLn rJbhFtt8XRmUwCIkvdNoMPSF9MF1NgKpUJ/KlwcE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6B6713858D1E for ; Mon, 13 Mar 2023 19:00:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B6713858D1E Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-464-O6JM-R_jNEWLn6WRgCp-JQ-1; Mon, 13 Mar 2023 15:00:28 -0400 X-MC-Unique: O6JM-R_jNEWLn6WRgCp-JQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8AB113C10220 for ; Mon, 13 Mar 2023 19:00:28 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.17.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 61757492C13; Mon, 13 Mar 2023 19:00:28 +0000 (UTC) To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [pushed] analyzer, testsuite: add test coverage for various builtins Date: Mon, 13 Mar 2023 15:00:27 -0400 Message-Id: <20230313190027.3358516-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: David Malcolm Reply-To: David Malcolm Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Successfully regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-6639-gfa9d3aa67894c8. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/exec-1.c: New test. * gcc.dg/analyzer/snprintf-concat.c: New test. * gcc.dg/analyzer/vsnprintf-1.c: New test. Signed-off-by: David Malcolm --- gcc/testsuite/gcc.dg/analyzer/exec-1.c | 43 +++++++++++++++++++ .../gcc.dg/analyzer/snprintf-concat.c | 35 +++++++++++++++ gcc/testsuite/gcc.dg/analyzer/vsnprintf-1.c | 11 +++++ 3 files changed, 89 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/analyzer/exec-1.c create mode 100644 gcc/testsuite/gcc.dg/analyzer/snprintf-concat.c create mode 100644 gcc/testsuite/gcc.dg/analyzer/vsnprintf-1.c diff --git a/gcc/testsuite/gcc.dg/analyzer/exec-1.c b/gcc/testsuite/gcc.dg/analyzer/exec-1.c new file mode 100644 index 00000000000..6b71118bd54 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/exec-1.c @@ -0,0 +1,43 @@ +#define NULL ((void *)0) + +extern int execl(const char *pathname, const char *arg, ...); +extern int execlp(const char *file, const char *arg, ...); +extern int execle(const char *pathname, const char *arg, ...); +extern int execv(const char *pathname, char *const argv[]); +extern int execvp(const char *file, char *const argv[]); +extern int execvpe(const char *file, char *const argv[], char *const envp[]); + +int test_execl_ls_al () +{ + return execl ("/usr/bin/ls", "ls", "-al", NULL); +} + +int test_execlpl_ls_al () +{ + return execlp ("ls", "ls", "-al", NULL); +} + +int test_execle_ls_al () +{ + const char *env[3] = {"FOO=BAR", "BAZ", NULL}; + return execl ("/usr/bin/ls", "ls", "-al", NULL, env); +} + +int test_execv_ls_al () +{ + char *argv[3] = {"ls", "-al", NULL}; + return execv ("/usr/bin/ls", argv); +} + +int test_execvp_ls_al () +{ + char *argv[3] = {"ls", "-al", NULL}; + return execvp ("ls", argv); +} + +int test_execvpe_ls_al () +{ + char *env[3] = {"FOO=BAR", "BAZ", NULL}; + char *argv[3] = {"ls", "-al", NULL}; + return execvpe ("ls", argv, env); +} diff --git a/gcc/testsuite/gcc.dg/analyzer/snprintf-concat.c b/gcc/testsuite/gcc.dg/analyzer/snprintf-concat.c new file mode 100644 index 00000000000..a557dee6e44 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/snprintf-concat.c @@ -0,0 +1,35 @@ +typedef __SIZE_TYPE__ size_t; +#define NULL ((void *)0) + +extern size_t +strlen(const char* __s) __attribute__((__nothrow__, __leaf__)) +__attribute__((__pure__)) __attribute__((__nonnull__(1))); + +extern void* +malloc(size_t __size) __attribute__((__nothrow__, __leaf__)) +__attribute__((__malloc__)) __attribute__((__alloc_size__(1))); + +extern int +snprintf(char* __restrict __s, size_t size, const char* __restrict, ...) + __attribute__((__nothrow__)); + +char * +test_1 (const char *a, const char *b) +{ + size_t sz = strlen (a) + strlen (b) + 2; + char *p = malloc (sz); + if (!p) + return NULL; + snprintf (p, sz, "%s/%s", a, b); + return p; +} + +void +test_2 (const char *a, const char *b) +{ + size_t sz = strlen (a) + strlen (b) + 2; + char *p = malloc (sz); /* { dg-message "allocated here" "PR 107017" { xfail *-*-* } } */ + if (!p) + return; + snprintf (p, sz, "%s/%s", a, b); /* { dg-warning "leak of 'p'" "PR 107017" { xfail *-*-* } } */ +} diff --git a/gcc/testsuite/gcc.dg/analyzer/vsnprintf-1.c b/gcc/testsuite/gcc.dg/analyzer/vsnprintf-1.c new file mode 100644 index 00000000000..209c4b6cbb6 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/vsnprintf-1.c @@ -0,0 +1,11 @@ +typedef __SIZE_TYPE__ size_t; + +int +my_snprintf(char *pos, size_t left, const char *fmt, ...) +{ + __builtin_va_list ap; + __builtin_va_start(ap, fmt); + const int len = __builtin_vsnprintf(pos, left, fmt, ap); + __builtin_va_end(ap); + return len; +}