[RFC,v1,09/10] RISC-V: Recognize xventanacondops extension
Commit Message
This adds the xventanacondops extension to the option parsing and as a
default for the ventana-vt1 core:
gcc/Changelog:
* common/config/riscv/riscv-common.cc: Recognize
"xventanacondops" as part of an architecture string.
* config/riscv/riscv-opts.h (MASK_XVENTANACONDOPS): Define.
(TARGET_XVENTANACONDOPS): Define.
* config/riscv/riscv.opt: Add "riscv_xventanacondops".
Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
---
gcc/common/config/riscv/riscv-common.cc | 2 ++
gcc/config/riscv/riscv-opts.h | 3 +++
gcc/config/riscv/riscv.opt | 3 +++
3 files changed, 8 insertions(+)
Comments
On 2/10/23 15:41, Philipp Tomsich wrote:
> This adds the xventanacondops extension to the option parsing and as a
> default for the ventana-vt1 core:
>
> gcc/Changelog:
>
> * common/config/riscv/riscv-common.cc: Recognize
> "xventanacondops" as part of an architecture string.
> * config/riscv/riscv-opts.h (MASK_XVENTANACONDOPS): Define.
> (TARGET_XVENTANACONDOPS): Define.
> * config/riscv/riscv.opt: Add "riscv_xventanacondops".
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
OK
jeff
I am not sure if we should accept this on gcc trunk without binutils support?
On Sat, Apr 22, 2023 at 3:58 AM Jeff Law via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
>
> On 2/10/23 15:41, Philipp Tomsich wrote:
> > This adds the xventanacondops extension to the option parsing and as a
> > default for the ventana-vt1 core:
> >
> > gcc/Changelog:
> >
> > * common/config/riscv/riscv-common.cc: Recognize
> > "xventanacondops" as part of an architecture string.
> > * config/riscv/riscv-opts.h (MASK_XVENTANACONDOPS): Define.
> > (TARGET_XVENTANACONDOPS): Define.
> > * config/riscv/riscv.opt: Add "riscv_xventanacondops".
> >
> > Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
> OK
> jeff
The binutils support is lingering on-list since Jan 2022:
https://sourceware.org/pipermail/binutils/2022-January/119388.html
If we get an OK on that one, we will rebase, retest, and merge it.
Thanks,
Philipp.
On Tue, 25 Apr 2023 at 11:53, Kito Cheng <kito.cheng@gmail.com> wrote:
> I am not sure if we should accept this on gcc trunk without binutils
> support?
>
> On Sat, Apr 22, 2023 at 3:58 AM Jeff Law via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> >
> >
> > On 2/10/23 15:41, Philipp Tomsich wrote:
> > > This adds the xventanacondops extension to the option parsing and as a
> > > default for the ventana-vt1 core:
> > >
> > > gcc/Changelog:
> > >
> > > * common/config/riscv/riscv-common.cc: Recognize
> > > "xventanacondops" as part of an architecture string.
> > > * config/riscv/riscv-opts.h (MASK_XVENTANACONDOPS): Define.
> > > (TARGET_XVENTANACONDOPS): Define.
> > > * config/riscv/riscv.opt: Add "riscv_xventanacondops".
> > >
> > > Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
> > OK
> > jeff
>
I am ok if binutils patch get merged into trunk
Philipp Tomsich <philipp.tomsich@vrull.eu> 於 2023年4月25日 週二 18:15 寫道:
> The binutils support is lingering on-list since Jan 2022:
> https://sourceware.org/pipermail/binutils/2022-January/119388.html
>
> If we get an OK on that one, we will rebase, retest, and merge it.
>
> Thanks,
> Philipp.
>
> On Tue, 25 Apr 2023 at 11:53, Kito Cheng <kito.cheng@gmail.com> wrote:
>
> > I am not sure if we should accept this on gcc trunk without binutils
> > support?
> >
> > On Sat, Apr 22, 2023 at 3:58 AM Jeff Law via Gcc-patches
> > <gcc-patches@gcc.gnu.org> wrote:
> > >
> > >
> > >
> > > On 2/10/23 15:41, Philipp Tomsich wrote:
> > > > This adds the xventanacondops extension to the option parsing and as
> a
> > > > default for the ventana-vt1 core:
> > > >
> > > > gcc/Changelog:
> > > >
> > > > * common/config/riscv/riscv-common.cc: Recognize
> > > > "xventanacondops" as part of an architecture string.
> > > > * config/riscv/riscv-opts.h (MASK_XVENTANACONDOPS): Define.
> > > > (TARGET_XVENTANACONDOPS): Define.
> > > > * config/riscv/riscv.opt: Add "riscv_xventanacondops".
> > > >
> > > > Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
> > > OK
> > > jeff
> >
>
On 4/25/23 03:53, Kito Cheng wrote:
> I am not sure if we should accept this on gcc trunk without binutils support?
Let's get the binutils bits in first. I don't mind owning that review.
It just hasn't been a priority due to the gcc-13 freeze.
jeff
@@ -1250,6 +1250,8 @@ static const riscv_ext_flag_table_t riscv_ext_flag_table[] =
{"svinval", &gcc_options::x_riscv_sv_subext, MASK_SVINVAL},
{"svnapot", &gcc_options::x_riscv_sv_subext, MASK_SVNAPOT},
+ {"xventanacondops", &gcc_options::x_riscv_xventanacondops, MASK_XVENTANACONDOPS},
+
{NULL, NULL, 0}
};
@@ -191,4 +191,7 @@ enum stack_protector_guard {
? 0 \
: 32 << (__builtin_popcount (riscv_zvl_flags) - 1))
+#define MASK_XVENTANACONDOPS (1 << 0)
+#define TARGET_XVENTANACONDOPS ((riscv_xventanacondops & MASK_XVENTANACONDOPS) != 0)
+
#endif /* ! GCC_RISCV_OPTS_H */
@@ -233,6 +233,9 @@ int riscv_zm_subext
TargetVariable
int riscv_sv_subext
+TargetVariable
+int riscv_xventanacondops = 0
+
Enum
Name(isa_spec_class) Type(enum riscv_isa_spec_class)
Supported ISA specs (for use with the -misa-spec= option):