| Message ID | 20230106083908.332604-1-chigot@adacore.com |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0F1713858C62 for <patchwork@sourceware.org>; Fri, 6 Jan 2023 08:40:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F1713858C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1672994423; bh=4/FP0yLHqOIUhHXwMzXAFxsCNpsxUvl5wMWjQHFQxVU=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=SpxaOpushmxB+aavQqZpoC/YoZy/Wwf+Thzkye4FRF/fV5oPBDX5CLXUnq4JLbO8m Vluxi4/frhcJs/FGDcgB/cMxZsxXOK99pBI6C36HAJhAVdh/5f4e8O+x5tZTbMDlm8 FDP4vAPvH9dG1ncH/W+cNXTag8a15Ro2+BDJau7Y= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id EB3453858D28 for <gcc-patches@gcc.gnu.org>; Fri, 6 Jan 2023 08:39:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB3453858D28 Received: by mail-wm1-x329.google.com with SMTP id g25-20020a7bc4d9000000b003d97c8d4941so3039651wmk.4 for <gcc-patches@gcc.gnu.org>; Fri, 06 Jan 2023 00:39:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4/FP0yLHqOIUhHXwMzXAFxsCNpsxUvl5wMWjQHFQxVU=; b=U8s5LXILjqzzrZQ7NWWG4BZ4TRA4k+KeRJcZAmzD3yjLy2pbuk3CuFK48aC285YHU0 1Z5kIe4cKIviHWQgsIrXXRABiYhHSrdGSQs0ajtItb6vaLffRdV7TL46J6deXAMREi+Z iqXYcawlLQavTy20/AiYNfhM9UoTbKLHBTkRgUevnXDJzNfmjzIcffejMW0gy9288yQh t8s4s4NFnOt+vIRDtqCNThck0N/GmFwhprMGRtk105WPReIeV24C4+eScknUUqP75JOY 30bxQ3NgnIhqJ3Yt/IG/nBtkBUHg4Rnm/v+gA2125TU/8neUnfH4Kin2Svew3zTEzq26 PRVQ== X-Gm-Message-State: AFqh2kqolWUaIIQOzYsWedfAzFRtglMVR+2fwj6Ec32dEe8J0+rQ7RI7 WkH2jgtrzEMGlt3lBVzI86bruQ4V99LrD2qY X-Google-Smtp-Source: AMrXdXvq2YtZp2ZtuxjEvNGEPI2AClWXB+n+1/asxw2wM+XxJkHSRIHjCX/P/C8lps1xruEZX4UIMg== X-Received: by 2002:a05:600c:1c97:b0:3d2:274d:be7c with SMTP id k23-20020a05600c1c9700b003d2274dbe7cmr39908720wms.19.1672994387333; Fri, 06 Jan 2023 00:39:47 -0800 (PST) Received: from chigot-Dell.home ([2a01:cb15:8123:8100:f81a:e010:9c9e:34fa]) by smtp.gmail.com with ESMTPSA id y7-20020a7bcd87000000b003d997e5e679sm1026121wmj.14.2023.01.06.00.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 00:39:46 -0800 (PST) To: gcc-patches@gcc.gnu.org Cc: tom@tromey.com, pinskia@gmail.com, =?utf-8?q?Cl=C3=A9ment_Chigot?= <chigot@adacore.com> Subject: [PATCH] configure: remove dependencies on gmp and mpfr when gdb is disabled Date: Fri, 6 Jan 2023 09:39:08 +0100 Message-Id: <20230106083908.332604-1-chigot@adacore.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: =?utf-8?q?Cl=C3=A9ment_Chigot_via_Gcc-patches?= <gcc-patches@gcc.gnu.org> Reply-To: =?utf-8?q?Cl=C3=A9ment_Chigot?= <chigot@adacore.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
| Series |
configure: remove dependencies on gmp and mpfr when gdb is disabled
|
|
Commit Message
Clément Chigot
Jan. 6, 2023, 8:39 a.m. UTC
Since 91e0d22025e0bf2af2e364cb7214a05512a0c431, the configure checks about GMP and MPFR for gdb builds have been moved to the toplevel configure. However, it doesn't take into account the --disable-gdb option. Meaning that a build without gdb will require these libraries even if not needed. ChangeLog: * configure.ac: Skip GMP and MPFR when --disable-gdb is provided. * configure: Regenerate. --- configure | 4 +++- configure.ac | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
Comments
On Fri, Jan 6, 2023 at 9:39 AM Clément Chigot <chigot@adacore.com> wrote: > > Since 91e0d22025e0bf2af2e364cb7214a05512a0c431, the configure checks > about GMP and MPFR for gdb builds have been moved to the toplevel > configure. > However, it doesn't take into account the --disable-gdb option. Meaning > that a build without gdb will require these libraries even if not > needed. > > ChangeLog: > > * configure.ac: Skip GMP and MPFR when --disable-gdb is > provided. > * configure: Regenerate. > --- > configure | 4 +++- > configure.ac | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index d6716e38e99..85883099410 100755 > --- a/configure > +++ b/configure > @@ -7913,7 +7913,9 @@ if test -d ${srcdir}/gcc ; then > require_mpc=yes > fi > if test -d ${srcdir}/gdb ; then > - require_gmp=yes > + if test "x$enable_gdb" != xno; then > + require_gmp=yes > + fi > fi > > gmplibs="-lmpfr -lgmp" > diff --git a/configure.ac b/configure.ac > index 737c1a1172b..2b612dce6e9 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1489,7 +1489,9 @@ if test -d ${srcdir}/gcc ; then > require_mpc=yes > fi > if test -d ${srcdir}/gdb ; then > - require_gmp=yes > + if test "x$enable_gdb" != xno; then > + require_gmp=yes > + fi > fi > > gmplibs="-lmpfr -lgmp" > -- > 2.25.1 This patch has already been merged in the binutils repository see [1]. [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=5fb0e308577143ceb313fde5538dc9ecb038f29f Thanks, Clément
> Am 06.01.2023 um 09:44 schrieb Clément Chigot via Gcc-patches <gcc-patches@gcc.gnu.org>: > > On Fri, Jan 6, 2023 at 9:39 AM Clément Chigot <chigot@adacore.com> wrote: >> >> Since 91e0d22025e0bf2af2e364cb7214a05512a0c431, the configure checks >> about GMP and MPFR for gdb builds have been moved to the toplevel >> configure. >> However, it doesn't take into account the --disable-gdb option. Meaning >> that a build without gdb will require these libraries even if not >> needed. >> >> ChangeLog: >> >> * configure.ac: Skip GMP and MPFR when --disable-gdb is >> provided. >> * configure: Regenerate. >> --- >> configure | 4 +++- >> configure.ac | 4 +++- >> 2 files changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index d6716e38e99..85883099410 100755 >> --- a/configure >> +++ b/configure >> @@ -7913,7 +7913,9 @@ if test -d ${srcdir}/gcc ; then >> require_mpc=yes >> fi >> if test -d ${srcdir}/gdb ; then >> - require_gmp=yes >> + if test "x$enable_gdb" != xno; then >> + require_gmp=yes >> + fi >> fi >> >> gmplibs="-lmpfr -lgmp" >> diff --git a/configure.ac b/configure.ac >> index 737c1a1172b..2b612dce6e9 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -1489,7 +1489,9 @@ if test -d ${srcdir}/gcc ; then >> require_mpc=yes >> fi >> if test -d ${srcdir}/gdb ; then >> - require_gmp=yes >> + if test "x$enable_gdb" != xno; then >> + require_gmp=yes >> + fi >> fi >> >> gmplibs="-lmpfr -lgmp" >> -- >> 2.25.1 > > This patch has already been merged in the binutils repository see [1]. Ok for GCC Richard > [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=5fb0e308577143ceb313fde5538dc9ecb038f29f > > Thanks, > Clément
diff --git a/configure b/configure index d6716e38e99..85883099410 100755 --- a/configure +++ b/configure @@ -7913,7 +7913,9 @@ if test -d ${srcdir}/gcc ; then require_mpc=yes fi if test -d ${srcdir}/gdb ; then - require_gmp=yes + if test "x$enable_gdb" != xno; then + require_gmp=yes + fi fi gmplibs="-lmpfr -lgmp" diff --git a/configure.ac b/configure.ac index 737c1a1172b..2b612dce6e9 100644 --- a/configure.ac +++ b/configure.ac @@ -1489,7 +1489,9 @@ if test -d ${srcdir}/gcc ; then require_mpc=yes fi if test -d ${srcdir}/gdb ; then - require_gmp=yes + if test "x$enable_gdb" != xno; then + require_gmp=yes + fi fi gmplibs="-lmpfr -lgmp"