libstdc++, testsuite: Correct an init.

Message ID 20221224114234.20419-1-iain@sandoe.co.uk
State Committed
Commit 4c3a036be5f4dd68e0e4d8fb3a152c06538f5872
Headers
Series libstdc++, testsuite: Correct an init. |

Commit Message

Iain Sandoe Dec. 24, 2022, 11:42 a.m. UTC
  Noticed while debugging tz info support on Darwin, unless I miss
some other reasoning...
OK for trunk?
Iain

--- 8< ---

in leap_seconds.cc, we are testing to see if the function that
overrides the default zoneinfo directory has been called.  That
is implemented with a static boolean that needs to be initialized
to false.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

libstdc++-v3/ChangeLog:

	* testsuite/std/time/tzdb/leap_seconds.cc: Initialize the
	override_used test var to false.
---
 libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Jonathan Wakely Dec. 24, 2022, 12:07 p.m. UTC | #1
On Sat, 24 Dec 2022, 11:43 Iain Sandoe via Libstdc++, <libstdc++@gcc.gnu.org>
wrote:

> Noticed while debugging tz info support on Darwin, unless I miss
> some other reasoning...
> OK for trunk?
>

Doh, thanks. OK for trunk.


Iain
>
> --- 8< ---
>
> in leap_seconds.cc, we are testing to see if the function that
> overrides the default zoneinfo directory has been called.  That
> is implemented with a static boolean that needs to be initialized
> to false.
>
> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>
> libstdc++-v3/ChangeLog:
>
>         * testsuite/std/time/tzdb/leap_seconds.cc: Initialize the
>         override_used test var to false.
> ---
>  libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> index 82303e8bdf0..2b289436583 100644
> --- a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> +++ b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> @@ -7,7 +7,7 @@
>  #include <fstream>
>  #include <testsuite_hooks.h>
>
> -static bool override_used = true;
> +static bool override_used = false;
>
>  namespace __gnu_cxx
>  {
> --
> 2.37.1 (Apple Git-137.1)
>
>
  

Patch

diff --git a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
index 82303e8bdf0..2b289436583 100644
--- a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
+++ b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
@@ -7,7 +7,7 @@ 
 #include <fstream>
 #include <testsuite_hooks.h>
 
-static bool override_used = true;
+static bool override_used = false;
 
 namespace __gnu_cxx
 {