From patchwork Mon Dec 5 13:43:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Joakim_Nohlg=C3=A5rd?= X-Patchwork-Id: 61473 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B059838A8153 for ; Mon, 5 Dec 2022 13:44:20 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 591D338A814D for ; Mon, 5 Dec 2022 13:44:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 591D338A814D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nohlgard.se Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nohlgard.se Received: by mail-lf1-x12f.google.com with SMTP id x28so1283506lfn.6 for ; Mon, 05 Dec 2022 05:44:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nohlgard.se; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VQG7OjstGMJELu4od7tPNSv6MAFXkzEYKKlGyIvkI0E=; b=TZq6fv+b0dc1uCLmTL6q3draPZjtr1aDQ+LcAeUINiJDa5caYai9bmuD54WkgK29Hm GODneyhLlHH8LU2EeV8gEdMEb/Irw8xcI605G21iYDEEI7e2hs5vPvd7AjBsjl5XxEit hOu91OrTntqw+O+3raw02m8caChx0U695AB8YTYMB3QH9J5AqWLOPn+uMR/SNQ5sjMpo BfEZJxVLYHIT3v0BfaUgaYTLKWunxMtd2Az2u7njlcT812YzYLjAgTDdElsxF7byldVS H0XWBEsS2BYIvrQ6ZJSO+QJBeSKYs80DpA8yEqDZq5o9wg+ByiT1Nv3RwPXLywZi73R1 hOjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VQG7OjstGMJELu4od7tPNSv6MAFXkzEYKKlGyIvkI0E=; b=kf7sZH6t6PuijYKGLw2rxgqm0K/StxUSa2KiTW1cZXlvYocln+cvOms3zxauBFivf5 m536Kh2wDt567vwWuFW7bcZZKOWepeT5vmP82TjEN8RdQZdDN6aMzjVWi+JKOurI5CFk LiC5Vcwyj7V+SG1kxBwRIycda7dm7gr0Ar+yNMbA52ph9T4BPYE54Wzkd5xIWcEL1R0R HLbElb/wVu8kJjKZD3zig2oqy8u/WVLxgywCiiVwdqitSUO0ij1zAxOsfif24f6YbLhl gIB3eXYq+Z4pxrrwTkhEso7rIwOu6cQcF4uen2SUDdtQGBAhC+qJBYK7S0ADlruv3qq4 gG1A== X-Gm-Message-State: ANoB5pmUS4+afaJro1gca7nH7E/NL594jC9oBDOxyQee7nTI4gNN5bJL buu/G4kLloYhuweFKOTZc1YuNsKqh5NTFZnp X-Google-Smtp-Source: AA0mqf6WaGfI/U3ALWdeVPVzFAgBcGUCcm2TD4kGzGArPFConEcEGm/S/Uth4P/PtyKlry+6SUvvQA== X-Received: by 2002:ac2:4347:0:b0:4a4:782a:42ac with SMTP id o7-20020ac24347000000b004a4782a42acmr26176660lfl.468.1670247838401; Mon, 05 Dec 2022 05:43:58 -0800 (PST) Received: from cppdev.jnohlgard-laptop (81-26-241-118.customers.ownit.se. [81.26.241.118]) by smtp.gmail.com with ESMTPSA id o14-20020a056512230e00b004a26ba3458fsm2132013lfu.62.2022.12.05.05.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 05:43:57 -0800 (PST) From: =?utf-8?q?Joakim_Nohlg=C3=A5rd?= To: gcc-patches@gcc.gnu.org Cc: =?utf-8?q?Joakim_Nohlg=C3=A5rd?= Subject: [PATCH v2] gcc: Use ld -r when checking for HAVE_LD_RO_RW_SECTION_MIXING Date: Mon, 5 Dec 2022 14:43:49 +0100 Message-Id: <20221205134349.1730053-1-joakim@nohlgard.se> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Fall back to ld -r if ld -shared fails during configure. The check for HAVE_LD_RO_RW_SECTION_MIXING can fail on targets where ld does not support shared objects, even though the answer to the test should be 'read-write'. One such target is riscv64-unknown-elf. Failing this test results in a libgcc crtbegin.o which has a writable .eh_frame section leading to the default linker scripts placing the .eh_frame section in a writable memory segment, or a linker warning when using ld scripts that place .eh_frame unconditionally in ROM. gcc/ChangeLog: * configure: Regenerate. * configure.ac: Use ld -r in the check for HAVE_LD_RO_RW_SECTION_MIXING Signed-off-by: Joakim Nohlgård --- gcc/configure.ac | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/gcc/configure.ac b/gcc/configure.ac index 7c55bff6cb0..500829ceb1d 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -3152,16 +3152,19 @@ elif test x$gcc_cv_as != x -a x$gcc_cv_ld != x -a x$gcc_cv_objdump != x ; then echo '.byte 0' >> conftest3.s if $gcc_cv_as -o conftest1.o conftest1.s > /dev/null 2>&1 \ && $gcc_cv_as -o conftest2.o conftest2.s > /dev/null 2>&1 \ - && $gcc_cv_as -o conftest3.o conftest3.s > /dev/null 2>&1 \ - && $gcc_cv_ld -shared -o conftest1.so conftest1.o \ - conftest2.o conftest3.o > /dev/null 2>&1; then - gcc_cv_ld_ro_rw_mix=`$gcc_cv_objdump -h conftest1.so \ - | sed -e '/myfoosect/!d' -e N` - if echo "$gcc_cv_ld_ro_rw_mix" | grep CONTENTS > /dev/null; then - if echo "$gcc_cv_ld_ro_rw_mix" | grep READONLY > /dev/null; then - gcc_cv_ld_ro_rw_mix=read-only - else - gcc_cv_ld_ro_rw_mix=read-write + && $gcc_cv_as -o conftest3.o conftest3.s > /dev/null 2>&1; then + if $gcc_cv_ld -shared -o conftest1.so conftest1.o \ + conftest2.o conftest3.o > /dev/null 2>&1 \ + || $gcc_cv_ld -r -o conftest1.so conftest1.o \ + conftest2.o conftest3.o > /dev/null 2>&1; then + gcc_cv_ld_ro_rw_mix=`$gcc_cv_objdump -h conftest1.so \ + | sed -e '/myfoosect/!d' -e N` + if echo "$gcc_cv_ld_ro_rw_mix" | grep CONTENTS > /dev/null; then + if echo "$gcc_cv_ld_ro_rw_mix" | grep READONLY > /dev/null; then + gcc_cv_ld_ro_rw_mix=read-only + else + gcc_cv_ld_ro_rw_mix=read-write + fi fi fi fi