From patchwork Wed Nov 16 22:51:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 60725 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D27A2396E41D for ; Wed, 16 Nov 2022 22:52:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D27A2396E41D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668639132; bh=crLy2s4OFEBjckfEvJjMC4uqsyv7sFbEHiEyvWxY+P8=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=VsZ6m8tf9e/ccoSdrCA4msS5vwwlqkshnRLH9IMt5TeK4/6EAsMsT5ooR55bLLEsC 3lNx0xWV8ThxlAVpYQZRb2hD+tf/HkZStgaP77qhv+rBciaxGW2d+HS6J9qWRNh4V4 dC6y8b8oKURkyhmdSxm4lB4DAoDVu4gYN4VKX0U8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E7A8B396E05F for ; Wed, 16 Nov 2022 22:51:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E7A8B396E05F Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624-7NQeeSvRMGSaGn13LnkB1A-1; Wed, 16 Nov 2022 17:51:42 -0500 X-MC-Unique: 7NQeeSvRMGSaGn13LnkB1A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1FAD585A5A6 for ; Wed, 16 Nov 2022 22:51:42 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.17.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC6DC140EBF3; Wed, 16 Nov 2022 22:51:41 +0000 (UTC) To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [committed] analyzer: more test coverage for named constants Date: Wed, 16 Nov 2022 17:51:37 -0500 Message-Id: <20221116225137.2985245-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: David Malcolm Reply-To: David Malcolm Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Successfully tested on x86_64-pc-linux-gnu. Pushed to trunk as r13-4115-gff199a859b2a95. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/named-constants-via-command-line.c: New test. * gcc.dg/analyzer/named-constants-via-macros-3.c: New test. * gcc.dg/analyzer/named-constants-via-macros-4.c: New test. * gcc.dg/analyzer/named-constants-via-macros-empty.c: New test. * gcc.dg/analyzer/named-constants-via-macros-gc.c: New test. * gcc.dg/analyzer/named-constants-via-macros-traditional.c: New test. * gcc.dg/analyzer/named-constants-via-macros-undef.c: New test. Signed-off-by: David Malcolm --- .../named-constants-via-command-line.c | 10 +++++++++ .../analyzer/named-constants-via-macros-3.c | 15 +++++++++++++ .../analyzer/named-constants-via-macros-4.c | 15 +++++++++++++ .../named-constants-via-macros-empty.c | 14 +++++++++++++ .../analyzer/named-constants-via-macros-gc.c | 21 +++++++++++++++++++ .../named-constants-via-macros-traditional.c | 16 ++++++++++++++ .../named-constants-via-macros-undef.c | 18 ++++++++++++++++ 7 files changed, 109 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-command-line.c create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-3.c create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-4.c create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-empty.c create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-gc.c create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-traditional.c create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-undef.c diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-command-line.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-command-line.c new file mode 100644 index 00000000000..4a3dd16752e --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-command-line.c @@ -0,0 +1,10 @@ +/* { dg-additional-options "-DO_ACCMODE=42 -DO_RDONLY=0x1 -DO_WRONLY=010" } */ + +#include "analyzer-decls.h" + +void test_sm_fd_constants (void) +{ + __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has value '42'" } */ + __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has value '1'" } */ + __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has value '8'" } */ +} diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-3.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-3.c new file mode 100644 index 00000000000..2a3f2b0070a --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-3.c @@ -0,0 +1,15 @@ +#include "analyzer-decls.h" + +/* Various constants used by the fd state machine, as macros + that can't be handled. */ + +#define O_RDONLY (1 << 0) +#define O_WRONLY (1 << 1) +#define O_ACCMODE (O_RDONLY | O_WRONLY) + +void test_sm_fd_constants (void) +{ + __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */ + __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */ + __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */ +} diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-4.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-4.c new file mode 100644 index 00000000000..16eef964051 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-4.c @@ -0,0 +1,15 @@ +#include "analyzer-decls.h" + +/* Various constants used by the fd state machine, as macros + that can't be handled. */ + +#define O_ACCMODE(X) 42 +#define O_RDONLY(X) 0x1 +#define O_WRONLY(X) 010 + +void test_sm_fd_constants (void) +{ + __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */ + __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */ + __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */ +} diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-empty.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-empty.c new file mode 100644 index 00000000000..3d347e2caf5 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-empty.c @@ -0,0 +1,14 @@ +#include "analyzer-decls.h" + +/* Various constants used by the fd state machine. */ + +#define O_ACCMODE +#define O_RDONLY +#define O_WRONLY + +void test_sm_fd_constants (void) +{ + __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */ + __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */ + __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */ +} diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-gc.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-gc.c new file mode 100644 index 00000000000..e7b12f325a5 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-gc.c @@ -0,0 +1,21 @@ +/* { dg-additional-options "--param ggc-min-expand=0 --param ggc-min-heapsize=0" } */ + +#include "analyzer-decls.h" + +/* Various constants used by the fd state machine. */ + +#define O_ACCMODE 42 +#define O_RDONLY 0x1 +#define O_WRONLY 010 + +void test_sm_fd_constants (void) +{ + __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has value '42'" } */ + __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has value '1'" } */ + __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has value '8'" } */ +} + +void test_unknown (void) +{ + __analyzer_dump_named_constant ("UNKNOWN"); /* { dg-warning "named constant 'UNKNOWN' has unknown value" } */ +} diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-traditional.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-traditional.c new file mode 100644 index 00000000000..64acaad6aa0 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-traditional.c @@ -0,0 +1,16 @@ +/* { dg-additional-options "-traditional-cpp" } */ + +#include "analyzer-decls.h" + +/* Various constants used by the fd state machine. */ + +#define O_ACCMODE 42 +#define O_RDONLY 0x1 +#define O_WRONLY 010 + +void test_sm_fd_constants (void) +{ + __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */ + __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */ + __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */ +} diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-undef.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-undef.c new file mode 100644 index 00000000000..46c03223190 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-undef.c @@ -0,0 +1,18 @@ +#include "analyzer-decls.h" + +/* Various constants used by the fd state machine. */ + +#define O_ACCMODE 42 +#define O_RDONLY 0x1 +#define O_WRONLY 010 + +#undef O_ACCMODE +#undef O_RDONLY +#undef O_WRONLY + +void test_sm_fd_constants (void) +{ + __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */ + __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */ + __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */ +}