From patchwork Wed Nov 16 15:34:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 60705 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 991D1395BC36 for ; Wed, 16 Nov 2022 15:34:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 991D1395BC36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668612881; bh=PGf0R6V2LexPNUfLdfkdHbWzmmQ5cBW/FCqGJWo/yNg=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=NzW5L1UVUY8jA+kD0xXO1SYTuD3IQi04NQmBXTb0r+eQcuvllY5Yu5DY8LDpvijkM ac8UXcWVNE/KSHjqeBqV2ZIEyBVKBBvSzDhBUZdSZc8VH+MwUh6gYJxzFJMGsktbk3 5BQBXfC45HgBq94+/vCx/gug1FEymkJzXwI39NFc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id A904B395B422 for ; Wed, 16 Nov 2022 15:34:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A904B395B422 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9AB942241E for ; Wed, 16 Nov 2022 15:34:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 86FA313480 for ; Wed, 16 Nov 2022 15:34:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 52i8H/ACdWNRcQAAMHmgww (envelope-from ) for ; Wed, 16 Nov 2022 15:34:08 +0000 Date: Wed, 16 Nov 2022 16:34:08 +0100 (CET) To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/107679 - fix SSA rewrite of clobber of parameter MIME-Version: 1.0 Message-Id: <20221116153408.86FA313480@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" When the frontend clobbers a parameter and that parameter gets rewritten into SSA then we ICE because we didn't expect this. Avoid using the parameter decl to create a SSA default def in this case. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR middle-end/107679 * tree-into-ssa.cc (maybe_register_def): Use new temporary if we require an uninitialized value for a parameter decl. * gfortran.dg/pr107679.f90: New testcase. --- gcc/testsuite/gfortran.dg/pr107679.f90 | 9 +++++++++ gcc/tree-into-ssa.cc | 8 ++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gfortran.dg/pr107679.f90 diff --git a/gcc/testsuite/gfortran.dg/pr107679.f90 b/gcc/testsuite/gfortran.dg/pr107679.f90 new file mode 100644 index 00000000000..33a52fb5ef2 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr107679.f90 @@ -0,0 +1,9 @@ +! { dg-do compile } + +subroutine s1(x) + integer, intent(out) :: x +end +subroutine s2(z) + integer, value :: z + call s1(z) +end diff --git a/gcc/tree-into-ssa.cc b/gcc/tree-into-ssa.cc index d13fb720b37..f21ed2bea3f 100644 --- a/gcc/tree-into-ssa.cc +++ b/gcc/tree-into-ssa.cc @@ -1911,13 +1911,17 @@ maybe_register_def (def_operand_p def_p, gimple *stmt, { if (gimple_clobber_p (stmt) && is_gimple_reg (sym)) { - gcc_checking_assert (VAR_P (sym)); + tree defvar; + if (VAR_P (sym)) + defvar = sym; + else + defvar = create_tmp_reg (TREE_TYPE (sym)); /* Replace clobber stmts with a default def. This new use of a default definition may make it look like SSA_NAMEs have conflicting lifetimes, so we need special code to let them coalesce properly. */ to_delete = true; - def = get_or_create_ssa_default_def (cfun, sym); + def = get_or_create_ssa_default_def (cfun, defvar); } else {