Message ID | 20220923084330.4131742-1-torbjorn.svensson@foss.st.com |
---|---|
State | Committed |
Commit | b22baa40d7465addf01373a0555a79fdf63dfa72 |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC956385DC03 for <patchwork@sourceware.org>; Fri, 23 Sep 2022 08:44:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC956385DC03 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663922666; bh=EXQrt1y5Ng6En+/frLV9+kp8id3mn/xBGkYWrMZM9rQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=DVltSMe/rSOqTuMvJwRfufChmDFQA4L81ljbCpK3dDrYl4UfVpVykmSJGyHILm0tX bCjBmmmk6c4R7N9OA+jgM0qT8MV4KBkF0ilT6MO8falE9uiHjvfM/roQ2eH0FMHHub A7uo07Pco/3xnD9aqQm0EU/RNfiRawp7tpkeFU68= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by sourceware.org (Postfix) with ESMTPS id 9A75F3858034 for <gcc-patches@gcc.gnu.org>; Fri, 23 Sep 2022 08:43:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A75F3858034 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28N4P2B7008132; Fri, 23 Sep 2022 10:43:54 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3jrkmx7tpw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Sep 2022 10:43:54 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2812F10002A; Fri, 23 Sep 2022 10:43:52 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 05275217B7C; Fri, 23 Sep 2022 10:43:52 +0200 (CEST) Received: from jkgcxl0002.jkg.st.com (10.75.127.47) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 10:43:50 +0200 To: <gcc-patches@gcc.gnu.org> Subject: [PATCH] [testsuite][arm] Fix cmse-15.c expected output Date: Fri, 23 Sep 2022 10:43:31 +0200 Message-ID: <20220923084330.4131742-1-torbjorn.svensson@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-23_02,2022-09-22_02,2022-06-22_01 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: =?utf-8?q?Torbj=C3=B6rn_SVENSSON_via_Gcc-patches?= <gcc-patches@gcc.gnu.org> Reply-To: =?utf-8?q?Torbj=C3=B6rn_SVENSSON?= <torbjorn.svensson@foss.st.com> Cc: =?utf-8?q?Torbj=C3=B6rn_SVENSSON?= <torbjorn.svensson@foss.st.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
[testsuite,arm] Fix cmse-15.c expected output
|
|
Commit Message
Torbjorn SVENSSON
Sept. 23, 2022, 8:43 a.m. UTC
The cmse-15.c testcase fails at -Os because ICF means that we
generate
secure3:
b secure1
which is OK, but does not match the currently expected
secure3:
...
bx r[0-3]
gcc/testsuite/ChangeLog:
* gcc.target/arm/cmse/cmse-15.c: Align with -Os improvements.
Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
---
gcc/testsuite/gcc.target/arm/cmse/cmse-15.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi Torbjörn, On 9/23/22 10:43, Torbjörn SVENSSON via Gcc-patches wrote: > The cmse-15.c testcase fails at -Os because ICF means that we > generate > secure3: > b secure1 > > which is OK, but does not match the currently expected > secure3: > ... > bx r[0-3] > > gcc/testsuite/ChangeLog: > > * gcc.target/arm/cmse/cmse-15.c: Align with -Os improvements. > > Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com> > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > --- > gcc/testsuite/gcc.target/arm/cmse/cmse-15.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c b/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c > index b0fefe561a1..5188f1d697f 100644 > --- a/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c > +++ b/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c > @@ -144,6 +144,8 @@ int secure2 (s_bar_ptr s_bar_p) > ** bx r[0-3] > ** | > ** blx r[0-3] > +** | > +** b secure1 > ** ) > ** ... > */ Yes, that looks OK to me, similar to a patch I made some time ago to the very same file, when ICF became smarter. It seems it is now able to notice that return (*s_bar_p) (); in secure3 () is equivalent to the same call in secure1 (). LGTM, but I'm not a maintainer. Thanks, Christophe
On 23/09/2022 09:43, Torbjörn SVENSSON via Gcc-patches wrote: > The cmse-15.c testcase fails at -Os because ICF means that we > generate > secure3: > b secure1 > > which is OK, but does not match the currently expected > secure3: > ... > bx r[0-3] > > gcc/testsuite/ChangeLog: > > * gcc.target/arm/cmse/cmse-15.c: Align with -Os improvements. OK. R. > > Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com> > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > --- > gcc/testsuite/gcc.target/arm/cmse/cmse-15.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c b/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c > index b0fefe561a1..5188f1d697f 100644 > --- a/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c > +++ b/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c > @@ -144,6 +144,8 @@ int secure2 (s_bar_ptr s_bar_p) > ** bx r[0-3] > ** | > ** blx r[0-3] > +** | > +** b secure1 > ** ) > ** ... > */
diff --git a/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c b/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c index b0fefe561a1..5188f1d697f 100644 --- a/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c +++ b/gcc/testsuite/gcc.target/arm/cmse/cmse-15.c @@ -144,6 +144,8 @@ int secure2 (s_bar_ptr s_bar_p) ** bx r[0-3] ** | ** blx r[0-3] +** | +** b secure1 ** ) ** ... */