diff mbox series

testsuite: Do not prefix linker script with "-Wl,"

Message ID 20220919165735.4106606-1-torbjorn.svensson@foss.st.com
State Committed
Commit 86291da0057d01efdaba71f28cad80b69dc703a4
Headers
Series testsuite: Do not prefix linker script with "-Wl," |

Commit Message

Torbjorn SVENSSON Sept. 19, 2022, 4:57 p.m. UTC 
  The linker script should not be prefixed with "-Wl," - it's not an
input file and does not interfere with the new dump output filename
strategy.

gcc/testsuite/ChangeLog:

	* lib/gcc-defs.exp: Do not prefix linker script with "-Wl,".

Signed-off-by: Torbjörn SVENSSON  <torbjorn.svensson@foss.st.com>
---
 gcc/testsuite/lib/gcc-defs.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Torbjorn SVENSSON Sept. 28, 2022, 9:18 a.m. UTC | #1 
Hi,

Ping: https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601831.html

Kind regards,
Torbjörn

On 2022-09-19 18:57, Torbjörn SVENSSON wrote:
> The linker script should not be prefixed with "-Wl," - it's not an
> input file and does not interfere with the new dump output filename
> strategy.
> 
> gcc/testsuite/ChangeLog:
> 
> 	* lib/gcc-defs.exp: Do not prefix linker script with "-Wl,".
> 
> Signed-off-by: Torbjörn SVENSSON  <torbjorn.svensson@foss.st.com>
> ---
>   gcc/testsuite/lib/gcc-defs.exp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/testsuite/lib/gcc-defs.exp b/gcc/testsuite/lib/gcc-defs.exp
> index 42ef1d85432..2102ed6f7a3 100644
> --- a/gcc/testsuite/lib/gcc-defs.exp
> +++ b/gcc/testsuite/lib/gcc-defs.exp
> @@ -332,7 +332,7 @@ proc gcc_adjust_linker_flags_list { args } {
>   	    continue
>   	} elseif { $skip != "" } then {
>   	    set skip ""
> -	} elseif { $opt == "-Xlinker" } then {
> +	} elseif { $opt == "-Xlinker" || $opt == "-T" } then {
>   	    set skip $opt
>   	} elseif { ![string match "-*" $opt] \
>   		       && [file isfile $opt] } {
Christophe Lyon Sept. 28, 2022, 2:08 p.m. UTC | #2 
On 9/28/22 11:18, Torbjorn SVENSSON via Gcc-patches wrote:
> Hi,
> 
> Ping: https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601831.html
> 
> Kind regards,
> Torbjörn
> 
> On 2022-09-19 18:57, Torbjörn SVENSSON wrote:
>> The linker script should not be prefixed with "-Wl," - it's not an
>> input file and does not interfere with the new dump output filename
>> strategy.
>>
>> gcc/testsuite/ChangeLog:
>>
I think you want to mention PR testsuite/95720 since it is related?

>>     * lib/gcc-defs.exp: Do not prefix linker script with "-Wl,".
>>
>> Signed-off-by: Torbjörn SVENSSON  <torbjorn.svensson@foss.st.com>
>> ---
>>   gcc/testsuite/lib/gcc-defs.exp | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/testsuite/lib/gcc-defs.exp 
>> b/gcc/testsuite/lib/gcc-defs.exp
>> index 42ef1d85432..2102ed6f7a3 100644
>> --- a/gcc/testsuite/lib/gcc-defs.exp
>> +++ b/gcc/testsuite/lib/gcc-defs.exp
>> @@ -332,7 +332,7 @@ proc gcc_adjust_linker_flags_list { args } {
>>           continue
>>       } elseif { $skip != "" } then {
>>           set skip ""
>> -    } elseif { $opt == "-Xlinker" } then {
>> +    } elseif { $opt == "-Xlinker" || $opt == "-T" } then {
>>           set skip $opt
>>       } elseif { ![string match "-*" $opt] \
>>                  && [file isfile $opt] } {
Richard Sandiford Sept. 30, 2022, 4:19 p.m. UTC | #3 
Torbjorn SVENSSON <torbjorn.svensson@foss.st.com> writes:
> Hi,
>
> Ping: https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601831.html

OK, thanks.

Richard

> Kind regards,
> Torbjörn
>
> On 2022-09-19 18:57, Torbjörn SVENSSON wrote:
>> The linker script should not be prefixed with "-Wl," - it's not an
>> input file and does not interfere with the new dump output filename
>> strategy.
>> 
>> gcc/testsuite/ChangeLog:
>> 
>> 	* lib/gcc-defs.exp: Do not prefix linker script with "-Wl,".
>> 
>> Signed-off-by: Torbjörn SVENSSON  <torbjorn.svensson@foss.st.com>
>> ---
>>   gcc/testsuite/lib/gcc-defs.exp | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/gcc/testsuite/lib/gcc-defs.exp b/gcc/testsuite/lib/gcc-defs.exp
>> index 42ef1d85432..2102ed6f7a3 100644
>> --- a/gcc/testsuite/lib/gcc-defs.exp
>> +++ b/gcc/testsuite/lib/gcc-defs.exp
>> @@ -332,7 +332,7 @@ proc gcc_adjust_linker_flags_list { args } {
>>   	    continue
>>   	} elseif { $skip != "" } then {
>>   	    set skip ""
>> -	} elseif { $opt == "-Xlinker" } then {
>> +	} elseif { $opt == "-Xlinker" || $opt == "-T" } then {
>>   	    set skip $opt
>>   	} elseif { ![string match "-*" $opt] \
>>   		       && [file isfile $opt] } {
diff mbox series

Patch

diff --git a/gcc/testsuite/lib/gcc-defs.exp b/gcc/testsuite/lib/gcc-defs.exp
index 42ef1d85432..2102ed6f7a3 100644
--- a/gcc/testsuite/lib/gcc-defs.exp
+++ b/gcc/testsuite/lib/gcc-defs.exp
@@ -332,7 +332,7 @@  proc gcc_adjust_linker_flags_list { args } {
 	    continue
 	} elseif { $skip != "" } then {
 	    set skip ""
-	} elseif { $opt == "-Xlinker" } then {
+	} elseif { $opt == "-Xlinker" || $opt == "-T" } then {
 	    set skip $opt
 	} elseif { ![string match "-*" $opt] \
 		       && [file isfile $opt] } {