config/rs6000/t-float128: Don't encode full build paths into headers

Message ID 20220817121014.1824521-1-richard.purdie@linuxfoundation.org
State New
Headers
Series config/rs6000/t-float128: Don't encode full build paths into headers |

Commit Message

Richard Purdie Aug. 17, 2022, 12:10 p.m. UTC
  Avoid encoding full build paths into headers, just use the basename of the file.
This aids build reproducibility where the build paths vary and source is saved
for debugging purposes.

libgcc/ChangeLog:

    * config/rs6000/t-float128: Don't encode full build paths into headers

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 libgcc/config/rs6000/t-float128 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Richard Purdie Nov. 2, 2022, 10:45 a.m. UTC | #1
On Wed, 2022-08-17 at 13:10 +0100, Richard Purdie via Gcc-patches
wrote:
> Avoid encoding full build paths into headers, just use the basename of the file.
> This aids build reproducibility where the build paths vary and source is saved
> for debugging purposes.
> 
> libgcc/ChangeLog:
> 
>     * config/rs6000/t-float128: Don't encode full build paths into headers
> 

I think this patch is at risk of being lost. It is a simple change
which aids reproducibility so I'm hoping someone might be able to help
with review/merging?

Thanks!

Richard


> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  libgcc/config/rs6000/t-float128 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libgcc/config/rs6000/t-float128 b/libgcc/config/rs6000/t-float128
> index b09b5664af0..513e63748f1 100644
> --- a/libgcc/config/rs6000/t-float128
> +++ b/libgcc/config/rs6000/t-float128
> @@ -103,7 +103,7 @@ $(ibm128_dec_objs)	: INTERNAL_CFLAGS += $(IBM128_CFLAGS_DECIMAL)
>  $(fp128_softfp_src) : $(srcdir)/soft-fp/$(subst -sw,,$(subst kf,tf,$@)) $(fp128_dep)
>  	@src="$(srcdir)/soft-fp/$(subst -sw,,$(subst kf,tf,$@))"; \
>  	echo "Create $@"; \
> -	(echo "/* file created from $$src */"; \
> +	(echo "/* file created from `basename $$src` */"; \
>  	 echo; \
>  	 sed -f $(fp128_sed) < $$src) > $@
>
  

Patch

diff --git a/libgcc/config/rs6000/t-float128 b/libgcc/config/rs6000/t-float128
index b09b5664af0..513e63748f1 100644
--- a/libgcc/config/rs6000/t-float128
+++ b/libgcc/config/rs6000/t-float128
@@ -103,7 +103,7 @@  $(ibm128_dec_objs)	: INTERNAL_CFLAGS += $(IBM128_CFLAGS_DECIMAL)
 $(fp128_softfp_src) : $(srcdir)/soft-fp/$(subst -sw,,$(subst kf,tf,$@)) $(fp128_dep)
 	@src="$(srcdir)/soft-fp/$(subst -sw,,$(subst kf,tf,$@))"; \
 	echo "Create $@"; \
-	(echo "/* file created from $$src */"; \
+	(echo "/* file created from `basename $$src` */"; \
 	 echo; \
 	 sed -f $(fp128_sed) < $$src) > $@