Message ID | 20220620152821.81724-1-iain@sandoe.co.uk |
---|---|
State | Committed |
Commit | 607118dfa47a1865dc59f98e7d161da98471d688 |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4EE6E386CE46 for <patchwork@sourceware.org>; Mon, 20 Jun 2022 15:28:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4EE6E386CE46 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1655738938; bh=321w3dl/BRpDbQE29MzuZoKPFCS27FBGbfNMIIG9VeU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=bykx1jvKWFw+DUnM0WlPuwYEUBt24Vcwei6JXXgDR/68clxEKVsiwZMcaT8XHhEls PFrkMNtAZYGeuQuAovy7xu6Gc9gyJm5rdDLEPS+ZT+JHgXtLQHkEqjOEc0oebXoN70 1v6MJg25tEVD/BtsgLtxc2x1ijX2uA6InaToex8g= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 820033858C2C for <gcc-patches@gcc.gnu.org>; Mon, 20 Jun 2022 15:28:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 820033858C2C Received: by mail-wr1-x432.google.com with SMTP id q9so15175576wrd.8 for <gcc-patches@gcc.gnu.org>; Mon, 20 Jun 2022 08:28:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :mime-version:content-transfer-encoding; bh=321w3dl/BRpDbQE29MzuZoKPFCS27FBGbfNMIIG9VeU=; b=e96DAmSZU+M4WnHo7TsY1RGjx0YKI84hL9KxDiSW6IbJfAt2S/nurJ3HXnRH24PlOM RsA2zVdiSnvBW13PpCMY9tuJz3CU4XnDCdLR6wyJJqcOQI0L9NvSTCKS/GyhKAySNTaO mEHy4V/W4X6LVEDuA/EAM8E4XS/8OIt8bGuCBO4I9kZZw3VzEEIhngRorYQDKU8fxaee IORfXvdGoZII5HIXUO/9uURmM2P34oBvQQCchKBDOj8WprR8VRj7b2bXEqUzs0AGVmDD OPXC/CTNetRP34InGiFYd6xf0y4ijKlAD2Qq5M+a13owAOUxvUwCEuwNJvsaX5s0EwL4 gLkw== X-Gm-Message-State: AJIora+6gdVHPpzLVRaKd1+TNENGvABzzurqgUAisD/gA4Kn4l34JYcl Ll5B+vL9HclnKF0qLZ0HbDEjiedbgd8= X-Google-Smtp-Source: AGRyM1sp2k9iIyI5Nog3K9aEPWqox4xPNdstGsxdIhf02Nlp2a9dvZ4azCgUB9Qjb+ZC77Rw1L5kLw== X-Received: by 2002:adf:d229:0:b0:21a:3916:84ff with SMTP id k9-20020adfd229000000b0021a391684ffmr21445557wrh.349.1655738907310; Mon, 20 Jun 2022 08:28:27 -0700 (PDT) Received: from localhost.localdomain (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.gmail.com with ESMTPSA id f11-20020a05600c4e8b00b003973a3fe4fasm17201259wmq.42.2022.06.20.08.28.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2022 08:28:26 -0700 (PDT) X-Google-Original-From: Iain Sandoe <iain@sandoe.co.uk> To: gcc-patches@gcc.gnu.org Subject: [PATCH] testsuite, asan: Avoid color in asan test output. Date: Mon, 20 Jun 2022 16:28:21 +0100 Message-Id: <20220620152821.81724-1-iain@sandoe.co.uk> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Iain Sandoe via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: iain@sandoe.co.uk Cc: Iain Sandoe <iains.gcc@gmail.com>, jakub@redhat.com Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
testsuite, asan: Avoid color in asan test output.
|
|
Commit Message
Iain Sandoe
June 20, 2022, 3:28 p.m. UTC
The presence of the color markers in the some of the asan tests
appears to confuse the dg-output matching (possibly a platform
TCL or termios bug) on some Darwin platforms.
Since the color is not being tested, switch it off (makes the log
files easier to read too). This fixes a large number of spurious
test fails on AVX512 Darwin19.
tested on x86_64 Darwin / Linux,
OK for master / backports?
thanks
Iain
Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
gcc/testsuite/ChangeLog:
* lib/asan-dg.exp: Do not apply color to asan output when
under test.
---
gcc/testsuite/lib/asan-dg.exp | 2 ++
1 file changed, 2 insertions(+)
Comments
On Mon, Jun 20, 2022 at 04:28:21PM +0100, Iain Sandoe wrote: > The presence of the color markers in the some of the asan tests > appears to confuse the dg-output matching (possibly a platform > TCL or termios bug) on some Darwin platforms. > > Since the color is not being tested, switch it off (makes the log > files easier to read too). This fixes a large number of spurious > test fails on AVX512 Darwin19. > > tested on x86_64 Darwin / Linux, > OK for master / backports? > thanks > Iain > > Signed-off-by: Iain Sandoe <iain@sandoe.co.uk> > > gcc/testsuite/ChangeLog: > > * lib/asan-dg.exp: Do not apply color to asan output when > under test. Okay. > diff --git a/gcc/testsuite/lib/asan-dg.exp b/gcc/testsuite/lib/asan-dg.exp > index 7e0f85dc9b0..87c70d0bebb 100644 > --- a/gcc/testsuite/lib/asan-dg.exp > +++ b/gcc/testsuite/lib/asan-dg.exp > @@ -111,6 +111,8 @@ proc asan_init { args } { > global asan_saved_TEST_ALWAYS_FLAGS > global asan_saved_ALWAYS_CXXFLAGS > > + setenv ASAN_OPTIONS "color=never" > + > set link_flags "" > if ![is_remote host] { > if [info exists TOOL_OPTIONS] { > -- > 2.24.3 (Apple Git-128) Jakub
diff --git a/gcc/testsuite/lib/asan-dg.exp b/gcc/testsuite/lib/asan-dg.exp index 7e0f85dc9b0..87c70d0bebb 100644 --- a/gcc/testsuite/lib/asan-dg.exp +++ b/gcc/testsuite/lib/asan-dg.exp @@ -111,6 +111,8 @@ proc asan_init { args } { global asan_saved_TEST_ALWAYS_FLAGS global asan_saved_ALWAYS_CXXFLAGS + setenv ASAN_OPTIONS "color=never" + set link_flags "" if ![is_remote host] { if [info exists TOOL_OPTIONS] {