From patchwork Wed Jun 8 16:06:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 54942 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 67F49385087E for ; Wed, 8 Jun 2022 16:07:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 67F49385087E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1654704423; bh=7PE3Ru1N7XyCNUjj4OGoF85YOO1Q9KpruQDd8SNMWwE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=KiiGLtzCuclSo9EvPSczmu05p4YYeILq78g9xH5wSftegfUcoyn9jsDOy2cd9Tn3L O6AunD77ausq27KNHv9jKItR5jpZW0zibCAKSrSvlK2PdFknhiGlhBrzwjCfQrEK83 NqLX0LHWZbNXvNam0dcX+KEFEG6mMKQorvRA5xJw= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id 59A083850846 for ; Wed, 8 Jun 2022 16:06:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59A083850846 Received: by mail-pj1-x1036.google.com with SMTP id a10so18987675pju.3 for ; Wed, 08 Jun 2022 09:06:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7PE3Ru1N7XyCNUjj4OGoF85YOO1Q9KpruQDd8SNMWwE=; b=GXUqrqv4HwzegdxawziY0lVLtSa8oh8jG0t8ZA7TwoxBcEtvcxAb1ejX+xj1CA5+il QjsGP0wcFJU9ctlcfhib6s4xw+7JIIR+KiJ/EGDwwQOqrasDeCnq9ilJ8aPPUTrOzwwc VK4Wl3oXBXLai7y32RWEZpqd8UrwDGxfle6fUiR7eL4tP9UWR6ldyjhdGbkV0b+kdQFk AGdfdyY3GuRy+T1m6jTOJOxR7ak7JF7pUiEFJt8y5HOX7YTFIPyvPH0tXEAXBxFtpG/X 233PRgd2a9KTlgrC6YpUaww34vYOWaBYPmiSWdYhycw+011AxJIiQ2pL47/cPRGaDLBm 8ztg== X-Gm-Message-State: AOAM5333BLWlWS9PxXExXxkauwwKgc2xIkIjASr8FwbLirL2kvRvBdiB TkPi6FtM2a9uTu4dJlLbw9vKd0JLQ4+meRuF X-Google-Smtp-Source: ABdhPJzIhW58CEzDEhtPMB+dPEWLTndQe3lB2Vep3alg51IHhGZIJYhfEyDk8ifvexNHOYJpBUB6gQ== X-Received: by 2002:a17:903:20f:b0:158:d86a:f473 with SMTP id r15-20020a170903020f00b00158d86af473mr35444754plh.92.1654704392073; Wed, 08 Jun 2022 09:06:32 -0700 (PDT) Received: from octofox.hsd1.ca.comcast.net ([2601:641:401:1d20:19f0:4aa:4fe8:aeee]) by smtp.gmail.com with ESMTPSA id s16-20020aa78bd0000000b0051bbd79fc9csm14030922pfd.57.2022.06.08.09.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 09:06:31 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [COMMITTED] gcc: xtensa: fix PR target/105879 Date: Wed, 8 Jun 2022 09:06:21 -0700 Message-Id: <20220608160621.2356374-1-jcmvbkbc@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Max Filippov via Gcc-patches From: Max Filippov Reply-To: Max Filippov Cc: linux-xtensa@linux-xtensa.org Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" split_double operates with the 'word that comes first in memory in the target' terminology, while gen_lowpart operates with the 'value representing some low-order bits of X' terminology. They are not equivalent and must be dealt with differently on little- and big-endian targets. gcc/ PR target/105879 * config/xtensa/xtensa.md (movdi): Rename 'first' and 'second' to 'lowpart' and 'highpart' so that they match 'gen_lowpart' and 'gen_highpart' bitwise semantics and fix order of highpart and lowpart depending on target endianness. --- gcc/config/xtensa/xtensa.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md index 6f5cbc541d85..8a119038ba15 100644 --- a/gcc/config/xtensa/xtensa.md +++ b/gcc/config/xtensa/xtensa.md @@ -799,11 +799,14 @@ because of offering further optimization opportunities. */ if (register_operand (operands[0], DImode)) { - rtx first, second; - - split_double (operands[1], &first, &second); - emit_insn (gen_movsi (gen_lowpart (SImode, operands[0]), first)); - emit_insn (gen_movsi (gen_highpart (SImode, operands[0]), second)); + rtx lowpart, highpart; + + if (TARGET_BIG_ENDIAN) + split_double (operands[1], &highpart, &lowpart); + else + split_double (operands[1], &lowpart, &highpart); + emit_insn (gen_movsi (gen_lowpart (SImode, operands[0]), lowpart)); + emit_insn (gen_movsi (gen_highpart (SImode, operands[0]), highpart)); DONE; }