diff mbox series

x86: Avoid uninitialized variable in PR target/104441 test

Message ID 20220523174410.1979523-1-hjl.tools@gmail.com
State Committed
Commit f1a80c05db8b08e71741bae8170f9e77e94bfc35
Headers
Series x86: Avoid uninitialized variable in PR target/104441 test |

Commit Message

H.J. Lu May 23, 2022, 5:44 p.m. UTC 
  PR target/104441
	* gcc.target/i386/pr104441-1a.c (load8bit_4x4_avx2): Initialize
	src23.
---
 gcc/testsuite/gcc.target/i386/pr104441-1a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Uros Bizjak May 23, 2022, 7:43 p.m. UTC | #1 
On Mon, May 23, 2022 at 7:44 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
>         PR target/104441
>         * gcc.target/i386/pr104441-1a.c (load8bit_4x4_avx2): Initialize
>         src23.

LGTM.

Thanks,
Uros.

> ---
>  gcc/testsuite/gcc.target/i386/pr104441-1a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr104441-1a.c b/gcc/testsuite/gcc.target/i386/pr104441-1a.c
> index 83734f710bd..0931029f2bb 100644
> --- a/gcc/testsuite/gcc.target/i386/pr104441-1a.c
> +++ b/gcc/testsuite/gcc.target/i386/pr104441-1a.c
> @@ -8,7 +8,7 @@ __attribute__((always_inline, target("avx2")))
>  static __m256i
>  load8bit_4x4_avx2(const uint8_t *const src, const uint32_t stride)
>  {
> -  __m128i src01, src23;
> +  __m128i src01, src23 = _mm_setzero_si128();
>    src01 = _mm_cvtsi32_si128(*(int32_t*)(src + 0 * stride));
>    src23 = _mm_insert_epi32(src23, *(int32_t *)(src + 3 * stride), 1);
>    return _mm256_setr_m128i(src01, src23);
> --
> 2.36.1
>
Richard Biener May 24, 2022, 6:25 a.m. UTC | #2 
On Mon, 23 May 2022, H.J. Lu wrote:

> 	PR target/104441
> 	* gcc.target/i386/pr104441-1a.c (load8bit_4x4_avx2): Initialize
> 	src23.

OK.

Thanks for fixing.
Richard.

> ---
>  gcc/testsuite/gcc.target/i386/pr104441-1a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/testsuite/gcc.target/i386/pr104441-1a.c b/gcc/testsuite/gcc.target/i386/pr104441-1a.c
> index 83734f710bd..0931029f2bb 100644
> --- a/gcc/testsuite/gcc.target/i386/pr104441-1a.c
> +++ b/gcc/testsuite/gcc.target/i386/pr104441-1a.c
> @@ -8,7 +8,7 @@ __attribute__((always_inline, target("avx2")))
>  static __m256i
>  load8bit_4x4_avx2(const uint8_t *const src, const uint32_t stride)
>  {
> -  __m128i src01, src23;
> +  __m128i src01, src23 = _mm_setzero_si128();
>    src01 = _mm_cvtsi32_si128(*(int32_t*)(src + 0 * stride));
>    src23 = _mm_insert_epi32(src23, *(int32_t *)(src + 3 * stride), 1);
>    return _mm256_setr_m128i(src01, src23);
>
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/i386/pr104441-1a.c b/gcc/testsuite/gcc.target/i386/pr104441-1a.c
index 83734f710bd..0931029f2bb 100644
--- a/gcc/testsuite/gcc.target/i386/pr104441-1a.c
+++ b/gcc/testsuite/gcc.target/i386/pr104441-1a.c
@@ -8,7 +8,7 @@  __attribute__((always_inline, target("avx2")))
 static __m256i
 load8bit_4x4_avx2(const uint8_t *const src, const uint32_t stride)
 {
-  __m128i src01, src23;
+  __m128i src01, src23 = _mm_setzero_si128();
   src01 = _mm_cvtsi32_si128(*(int32_t*)(src + 0 * stride));
   src23 = _mm_insert_epi32(src23, *(int32_t *)(src + 3 * stride), 1);
   return _mm256_setr_m128i(src01, src23);