From patchwork Thu May 19 14:16:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 54233 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 54C74383943C for ; Thu, 19 May 2022 14:43:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 54C74383943C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1652971435; bh=JFRBIoMnnoxgciAiEIA/TuKEMVZ9dLzK1DE8mm/XAgo=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=PzcygwRGsuimwt/+XSkiERlJeHSnmAcXjWQjsZSe3vXe1hlNdkkvJjAH6d4Eya+GY ZOuA+qruqo2N61kAx2m5PzvjansrcqUkSg3OFakf2w48zUoedSm9DBGtGbCC5a2rpG makjB9s/WQ+vK1gn+OCqifGDA2hTcjO4WVNnfAYU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 499D5383D833 for ; Thu, 19 May 2022 14:16:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 499D5383D833 Received: by mail-wr1-x42b.google.com with SMTP id f2so7424819wrc.0 for ; Thu, 19 May 2022 07:16:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=JFRBIoMnnoxgciAiEIA/TuKEMVZ9dLzK1DE8mm/XAgo=; b=B8wZFqASm+5g31boch9GlkwWTV8KVxJW50pyLN/vB0dH1KW230x0iCu9r8yharpYXJ HlvKhmwf0u5iZvE5Q3Aa7FnZIyXsecRLYWD4NxV2e7/5wF/uzB1JuEIufaLibgU+amU5 fssxCj8KrU/3KG7XIeszuy1xQZcwfziofd9P4HawFcK8aN7iRDEnUhqO5olEX06MknUe Qo+AzUejcgBQ6QiYnwzR/1cGl0munRH3fypX57DeUZRpaAtZn7S9n+sk8/4BySmHoZqr 2HtNG7nPBb/Io/gqzDYVXNLYmerKojb4iDovpcqu2sXzAB5lHtIaBluQVZPerJlQ+AgU TDjg== X-Gm-Message-State: AOAM5307qNSUVlySO18g8d81c7PPOTQwOQzh977+unzl9vvOCK4D5f35 KWp3BvVwKe5u/xBj0Q3y56PayaoG8dq8zQ== X-Google-Smtp-Source: ABdhPJzCSyZss/xh9MFLDX3GkNjRK/JrXWZU51IzXrVguWeBwIVJFmndjMd9DMHLKWZIvzLZT6T9iw== X-Received: by 2002:a05:6000:1b8d:b0:20c:d372:f07c with SMTP id r13-20020a0560001b8d00b0020cd372f07cmr4330559wru.607.1652969791914; Thu, 19 May 2022 07:16:31 -0700 (PDT) Received: from adacore.com ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id n34-20020a05600c3ba200b003945781b725sm7952628wms.37.2022.05.19.07.16.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 07:16:31 -0700 (PDT) Date: Thu, 19 May 2022 14:16:30 +0000 To: gcc-patches@gcc.gnu.org Subject: [Ada] Do not give warnings for compiler-generated entities by default Message-ID: <20220519141630.GA3723601@adacore.com> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Pierre-Marie de Rodat via Gcc-patches From: Pierre-Marie de Rodat Reply-To: Pierre-Marie de Rodat Cc: Eric Botcazou Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" The rationale is that these entities are almost always the result of expansion activities in the front-end, over which the user has very limited control. These warnings can be restored by means of -gnatD. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * gcc-interface/utils.cc (gnat_pushdecl): Also set TREE_NO_WARNING on the decl if Comes_From_Source is false for the associated node. diff --git a/gcc/ada/gcc-interface/utils.cc b/gcc/ada/gcc-interface/utils.cc --- a/gcc/ada/gcc-interface/utils.cc +++ b/gcc/ada/gcc-interface/utils.cc @@ -852,8 +852,11 @@ gnat_pushdecl (tree decl, Node_Id gnat_node) if (!deferred_decl_context) DECL_CONTEXT (decl) = context; - suppress_warning (decl, all_warnings, - No (gnat_node) || Warnings_Off (gnat_node)); + /* Disable warnings for compiler-generated entities or explicit request. */ + if (No (gnat_node) + || !Comes_From_Source (gnat_node) + || Warnings_Off (gnat_node)) + suppress_warning (decl); /* Set the location of DECL and emit a declaration for it. */ if (Present (gnat_node) && !renaming_from_instantiation_p (gnat_node))