From patchwork Mon May 2 12:58:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 53390 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B5103858028 for ; Mon, 2 May 2022 12:59:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B5103858028 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1651496354; bh=/mdnSX56Mkc0VAFjd5TpfZjanawIOt+3+7KgueqpASA=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=X1c3W3i+DDz1cP6usVxusYhZKdjFpGcW5Vsm6F018wl+Kn+b29vVSpdeJEK0i0elk wdL1Zf/LYW7zfOzbgLlAdqeP9Ulav5KhyMsGWldiv2dmJcixc52ZJkZ4f79dq0sKkB nYF8D9YnWDQ5qynsv3Nl6Bi1GlzipeZ0LbxFouS0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 4D10F3858C50 for ; Mon, 2 May 2022 12:58:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D10F3858C50 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6B345210E7 for ; Mon, 2 May 2022 12:58:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 573E5133E5 for ; Mon, 2 May 2022 12:58:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4zcRFITVb2JLCAAAMHmgww (envelope-from ) for ; Mon, 02 May 2022 12:58:44 +0000 Date: Mon, 2 May 2022 14:58:44 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Assume a call is expensive when it mismatches MIME-Version: 1.0 Message-Id: <20220502125844.573E5133E5@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" This makes sure to not consider calls to builtin decls with mismatching arguments as inexpensive. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2022-04-13 Richard Biener * tree-scalar-evolution.cc (expression_expensive_p): Never consider mismatched calls as cheap. --- gcc/tree-scalar-evolution.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/tree-scalar-evolution.cc b/gcc/tree-scalar-evolution.cc index 44157265ce8..b53d7aaa71d 100644 --- a/gcc/tree-scalar-evolution.cc +++ b/gcc/tree-scalar-evolution.cc @@ -3420,12 +3420,15 @@ expression_expensive_p (tree expr, hash_map &cache, break; return true; } + break; + default: + if (cfn == CFN_LAST + || !is_inexpensive_builtin (get_callee_fndecl (expr))) + return true; break; } - if (!is_inexpensive_builtin (get_callee_fndecl (expr))) - return true; FOR_EACH_CALL_EXPR_ARG (arg, iter, expr) if (expression_expensive_p (arg, cache, op_cost)) return true;