[committed] arm: temporarily disable 'local' pcs selection (PR96882)

Message ID 20220329160441.125782-1-rearnsha@arm.com
State Committed
Commit 1dca4ca1bf2f1b05537a1052e373d8b0ff11e53c
Series [committed] arm: temporarily disable 'local' pcs selection (PR96882) |

Commit Message

Richard Earnshaw March 29, 2022, 4:04 p.m. UTC
  The arm port has an optimization used during selection of the
function's ABI to permit deviation from the strict ABI when the
function does not escape the current translation unit.

Unfortunately, the ABI selection it makes can be unsafe if it changes
how a result is returned because not enough information is available
via the RETURN_IN_MEMORY hook to determine where the function gets
used.  This can result in some parts of the compiler thinking a value
is returned in memory while others think it is returned in registers.

To mitigate this, this patch temporarily disables the optimization and
falls back to using the default ABI for the translation.


	PR target/96882
	* config/arm/arm.cc (arm_get_pcs_model): Disable selection of
 gcc/config/arm/arm.cc | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)


diff --git a/gcc/config/arm/arm.cc b/gcc/config/arm/arm.cc
index e062361b985..26ed7f97fc6 100644
--- a/gcc/config/arm/arm.cc
+++ b/gcc/config/arm/arm.cc
@@ -6194,7 +6194,7 @@  arm_pcs_from_attribute (tree attr)
    specification, DECL is the specific declartion.  DECL may be null if
    the call could be indirect or if this is a library call.  */
 static enum arm_pcs
-arm_get_pcs_model (const_tree type, const_tree decl)
+arm_get_pcs_model (const_tree type, const_tree decl ATTRIBUTE_UNUSED)
   bool user_convention = false;
   enum arm_pcs user_pcs = arm_pcs_default;
@@ -6228,6 +6228,14 @@  arm_get_pcs_model (const_tree type, const_tree decl)
 	return ARM_PCS_AAPCS;
       else if (user_convention)
 	return user_pcs;
+#if 0
+      /* Unfortunately, this is not safe and can lead to wrong code
+	 being generated (PR96882).  Not all calls into the back-end
+	 pass the DECL, so it is unsafe to make any PCS-changing
+	 decisions based on it.  In particular the RETURN_IN_MEMORY
+	 hook is only ever passed a TYPE.  This needs revisiting to
+	 see if there are any partial improvements that can be
+	 re-enabled.  */
       else if (decl && flag_unit_at_a_time)
 	  /* Local functions never leak outside this compilation unit,
@@ -6239,6 +6247,7 @@  arm_get_pcs_model (const_tree type, const_tree decl)
 	  if (local_info_node && local_info_node->local)
 	    return ARM_PCS_AAPCS_LOCAL;
   else if (user_convention && user_pcs != arm_pcs_default)
     sorry ("PCS variant");