[v4,00/12] ARM/MVE use vectors of boolean for predicates
Message ID | 20220222150020.22852-1-christophe.lyon@linaro.org |
---|---|
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7311D3899018 for <patchwork@sourceware.org>; Tue, 22 Feb 2022 15:04:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7311D3899018 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1645542290; bh=dOonvyU1IV8BhI/NmOtAK1TR0IcyJFTSzYnLQKlnpr4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=r3MfZwGP8nwncxvcxy97TA3mqO7A83T79gkqYgKYxxL+peTkaRn6Vv6viSP9Nr1co bZaLlXzdZZ20Kfq/Dt88JPSQ/1HwVc4laraazqnwdMyJ8h/vk4ug4hFWiuWT9vfvhI 1turnlWOv5pz6rKKyUkWU8JuHvPXhMVrNhJeosAk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 89D343857818 for <gcc-patches@gcc.gnu.org>; Tue, 22 Feb 2022 15:00:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89D343857818 Received: by mail-wm1-x32e.google.com with SMTP id p14-20020a05600c1d8e00b0037f881182a8so2106238wms.2 for <gcc-patches@gcc.gnu.org>; Tue, 22 Feb 2022 07:00:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=dOonvyU1IV8BhI/NmOtAK1TR0IcyJFTSzYnLQKlnpr4=; b=QRxm2IUl7ylXOx/3weNHN6wX5oK+ywy38UY0DJmvW4/35eNqSs2Ou6DjdopcChaMnC HliQbtyQK1b4uuKzwn9ol6jvQEVIMB4FuDwnK+NwolRJWmRhhkVehIx6QTbZMRis+FLB CXeb6BA8pgnC9Csy/eWkkx4fuTJbIoLbUIO2Y9HAx37XxOM0cLvRfElPFzPxmCErN8/v XvmZlHcNaDEWWORmG6gomu78aQ/vFwWZYXUccBf3j9omE0EB1Vjfy8k0Z+QlSYD4JTBJ VDr9ksZ651T2RKTUVMhNkYCZhtTHldZNJiMzuAf8hogobJsvG7wSLPmA/75VkarjouwX xXNg== X-Gm-Message-State: AOAM530JJQkTCfnw9gX+ZXAnBo0DViNC9J3vEWcyNBsm64WHUAiaMIRi +XEom0PlwegE0e88BBdAeIbwHpXg+MYQgw== X-Google-Smtp-Source: ABdhPJzwdsXFpUDpd/D4w5DyolwI7P5cn+5aVtGWnnMf1Xvd7f0LAmVwiOPUERUupT2LqG8gf2WBHw== X-Received: by 2002:a7b:cd03:0:b0:37b:fc83:a4e2 with SMTP id f3-20020a7bcd03000000b0037bfc83a4e2mr3743845wmj.193.1645542024898; Tue, 22 Feb 2022 07:00:24 -0800 (PST) Received: from babel.clyon.hd.free.fr ([2a01:e0a:203:b210:afd3:bde6:6149:fc73]) by smtp.gmail.com with ESMTPSA id w8sm53845941wre.83.2022.02.22.07.00.24 for <gcc-patches@gcc.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 07:00:24 -0800 (PST) X-Google-Original-From: Christophe Lyon <christophe.lyon@linaro.org> To: gcc-patches@gcc.gnu.org Subject: [PATCH v4 00/12] ARM/MVE use vectors of boolean for predicates Date: Tue, 22 Feb 2022 16:00:08 +0100 Message-Id: <20220222150020.22852-1-christophe.lyon@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Christophe Lyon via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Christophe Lyon <christophe.lyon.oss@gmail.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Message
Christophe Lyon
Feb. 22, 2022, 3 p.m. UTC
From: Christophe Lyon <christophe.lyon.oss@gmail.com>
This is v4 of this patch series, fixing issues I discovered before
committing v2 (which had been approved). I am posting it for the
record of what I am going commit after I implemented all the requested
changes to v3.
Thanks a lot to Richard Sandiford for his help.
Most of the work of this patch series was carried out while I was
working at STMicroelectronics as a Linaro assignee.
The changes v3 -> v4 are:
Patch 5: Use build_truth_vector_type_for_mode to construct the boolean
types. Also fix the definition of B2Imode etc in init_emit_once.
Patches 6 and 7: Squash code change and testcases as requested during
the review.
Original text (patch numbers no longer match because of the squashes):
This patch series addresses PR 100757 and 101325 by representing
vectors of predicates (MVE VPR.P0 register) as vectors of booleans
rather than using HImode.
As this implies a lot of mostly mechanical changes, I have tried to
split the patches in a way that should help reviewers, but the split
is a bit artificial.
Patches 1-3 add new tests.
Patches 4-6 are small independent improvements.
Patch 7 implements the predicate qualifier, but does not change any
builtin yet.
Patch 8 is the first of the two main patches, and uses the new
qualifier to describe the vcmp and vpsel builtins that are useful for
auto-vectorization of comparisons.
Patch 9 is the second main patch, which fixes the vcond_mask expander.
Patches 10-13 convert almost all the remaining builtins with HI
operands to use the predicate qualifier. After these, there are still
a few builtins with HI operands left, about which I am not sure: vctp,
vpnot, load-gather and store-scatter with v2di operands. In fact,
patches 11/12 update some STR/LDR qualifiers in a way that breaks
these v2di builtins although existing tests still pass.
Christophe Lyon (12):
arm: Add new tests for comparison vectorization with Neon and MVE
arm: Add GENERAL_AND_VPR_REGS regclass
arm: Add support for VPR_REG in arm_class_likely_spilled_p
arm: Fix mve_vmvnq_n_<supf><mode> argument mode
arm: Implement MVE predicates as vectors of booleans
arm: Implement auto-vectorized MVE comparisons with vectors of boolean
predicates
arm: Fix vcond_mask expander for MVE (PR target/100757)
arm: Convert remaining MVE vcmp builtins to predicate qualifiers
arm: Convert more MVE builtins to predicate qualifiers
arm: Convert more load/store MVE builtins to predicate qualifiers
arm: Convert more MVE/CDE builtins to predicate qualifiers
arm: Add VPR_REG to ALL_REGS
gcc/config/aarch64/aarch64-modes.def | 8 +-
gcc/config/arm/arm-builtins.cc | 239 ++++--
gcc/config/arm/arm-builtins.h | 4 +-
gcc/config/arm/arm-modes.def | 8 +
gcc/config/arm/arm-protos.h | 4 +-
gcc/config/arm/arm-simd-builtin-types.def | 4 +
gcc/config/arm/arm.cc | 166 ++--
gcc/config/arm/arm.h | 9 +-
gcc/config/arm/arm_mve_builtins.def | 746 ++++++++--------
gcc/config/arm/constraints.md | 6 +
gcc/config/arm/iterators.md | 6 +
gcc/config/arm/mve.md | 795 ++++++++++--------
gcc/config/arm/neon.md | 39 +
gcc/config/arm/vec-common.md | 52 --
gcc/config/arm/vfp.md | 34 +-
gcc/doc/sourcebuild.texi | 4 +
gcc/emit-rtl.cc | 28 +-
gcc/genmodes.cc | 71 +-
gcc/machmode.def | 11 +-
gcc/rtx-vector-builder.cc | 4 +-
gcc/simplify-rtx.cc | 34 +-
gcc/testsuite/gcc.dg/rtl/arm/mve-vxbi.c | 89 ++
gcc/testsuite/gcc.dg/signbit-2.c | 1 +
.../gcc.target/arm/simd/mve-vcmp-f32-2.c | 32 +
.../gcc.target/arm/simd/neon-compare-1.c | 78 ++
.../gcc.target/arm/simd/neon-compare-2.c | 13 +
.../gcc.target/arm/simd/neon-compare-3.c | 14 +
.../arm/simd/neon-compare-scalar-1.c | 57 ++
.../gcc.target/arm/simd/neon-vcmp-f16.c | 12 +
.../gcc.target/arm/simd/neon-vcmp-f32-2.c | 15 +
.../gcc.target/arm/simd/neon-vcmp-f32-3.c | 12 +
.../gcc.target/arm/simd/neon-vcmp-f32.c | 12 +
gcc/testsuite/gcc.target/arm/simd/neon-vcmp.c | 22 +
.../gcc.target/arm/simd/pr100757-2.c | 20 +
.../gcc.target/arm/simd/pr100757-3.c | 20 +
.../gcc.target/arm/simd/pr100757-4.c | 19 +
gcc/testsuite/gcc.target/arm/simd/pr100757.c | 19 +
.../gcc.target/arm/simd/pr101325-2.c | 19 +
gcc/testsuite/gcc.target/arm/simd/pr101325.c | 14 +
gcc/testsuite/lib/target-supports.exp | 15 +-
gcc/varasm.cc | 7 +-
41 files changed, 1738 insertions(+), 1024 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/rtl/arm/mve-vxbi.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/mve-vcmp-f32-2.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-compare-1.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-compare-2.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-compare-3.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-compare-scalar-1.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp-f16.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp-f32-2.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp-f32-3.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp-f32.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr100757-2.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr100757-3.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr100757-4.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr100757.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr101325-2.c
create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr101325.c