From patchwork Tue Jan 25 19:29:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Merrill X-Patchwork-Id: 50439 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1A8A385C403 for ; Tue, 25 Jan 2022 19:30:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1A8A385C403 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1643139019; bh=Pfw02lwWu/qhYCLIaDOW11hU3FdLiwtOqQlnynvU6dE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=kPa6f1jAxudQHzCpNFvu3ricgItkO/9UElTSkCUyXIvD/R83UeaijxR2kcCnuaXvK CQymOdmHkEJgDkG5DKfpjYT2LakxmbEkGT2aChR1nvEGz3eLmmXkNCCHUd7wvG8kDZ EWM7oiBsubVMfLCRbMlJ+qji6w5C1dXp8JEDhMJs= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 59787385AC33 for ; Tue, 25 Jan 2022 19:29:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59787385AC33 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-355-W-AfsVh_MOuscap2xeHQMg-1; Tue, 25 Jan 2022 14:29:44 -0500 X-MC-Unique: W-AfsVh_MOuscap2xeHQMg-1 Received: by mail-qv1-f70.google.com with SMTP id gg10-20020a056214252a00b0041eeb1c2684so22498102qvb.21 for ; Tue, 25 Jan 2022 11:29:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Pfw02lwWu/qhYCLIaDOW11hU3FdLiwtOqQlnynvU6dE=; b=2f/x1dEaht4WnNXReszU/OfBQBXVBC8BleQF7YAVIcs2/OYPTBRLaYuTpotDEfTrui EbrpMo/FqpX1ZvESrsVgEqe00GqepfStzyRKW4o1CC/yg+g6cJc41BWNYz2zLr8igaSG 9Qa6MmjeBS8xbWCqtRK9J/wHoqmlQ9Q6vTTbcYnYpdx996wblY//EFYCFaizBgrKe/5G zB2UxBIea/zxTFPSbiBnanP0t285spzIZXEO4vFuvyucViyDGZ9whs8hAk2rUGMzioIW ojDeeMuZonzl+qkjUFBRDLiL6M2scz1SEAq85vOn2j8VQ7qUj1N8DBgnfeMPQRVHeHM1 narg== X-Gm-Message-State: AOAM530T/SHyK8/4Pi54pPMaDCzjLMiI9ttH3L5hLwBgJnQ8QR7c4GYg M66+nsffHxUwInIhCsEdwoEzDAcY4N4K5E4395vLiHUuETE0a3vbfYERJulOjro/jsxe0vnBsHz HRlwWmjWT+wVKKEDQjfHyJjKmPrGbObVGQs8zs+JC/rCdpbbi1YS7VxXE4y3xvG+2+A== X-Received: by 2002:a0c:e1c8:: with SMTP id v8mr11027343qvl.72.1643138983740; Tue, 25 Jan 2022 11:29:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxDisDjVaj2AM0F+QOdYqDG7a5ZnOs7zeZ6dxtgpGQCYeRQ4xbR2syBCj1uCGHiCwN4ka09oA== X-Received: by 2002:a0c:e1c8:: with SMTP id v8mr11027317qvl.72.1643138983258; Tue, 25 Jan 2022 11:29:43 -0800 (PST) Received: from barrymore.redhat.com (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id e7sm8904465qty.30.2022.01.25.11.29.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 11:29:42 -0800 (PST) To: gcc-patches@gcc.gnu.org Subject: [pushed] c++: assignment to temporary [PR59950] Date: Tue, 25 Jan 2022 14:29:41 -0500 Message-Id: <20220125192941.885833-1-jason@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jason Merrill via Gcc-patches From: Jason Merrill Reply-To: Jason Merrill Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Given build_this of a TARGET_EXPR, cp_build_fold_indirect_ref returns the TARGET_EXPR. But that's the wrong value category for the result of the defaulted class assignment operator, which returns an lvalue, so we need to actually build the INDIRECT_REF. Tested x86_64-pc-linux-gnu, applying to trunk. PR c++/59950 gcc/cp/ChangeLog: * call.cc (build_over_call): Use cp_build_indirect_ref. gcc/testsuite/ChangeLog: * g++.dg/init/assign2.C: New test. --- gcc/cp/call.cc | 5 ++++- gcc/testsuite/g++.dg/init/assign2.C | 6 ++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/init/assign2.C base-commit: aeac414923aa1e87986c7fc6f9b921d89a9b86cf diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc index f7f861cd16e..bc157cdd1fb 100644 --- a/gcc/cp/call.cc +++ b/gcc/cp/call.cc @@ -9789,7 +9789,10 @@ build_over_call (struct z_candidate *cand, int flags, tsubst_flags_t complain) && DECL_OVERLOADED_OPERATOR_IS (fn, NOP_EXPR) && trivial_fn_p (fn)) { - tree to = cp_build_fold_indirect_ref (argarray[0]); + /* Don't use cp_build_fold_indirect_ref, op= returns an lvalue even if + the object argument isn't one. */ + tree to = cp_build_indirect_ref (input_location, argarray[0], + RO_ARROW, complain); tree type = TREE_TYPE (to); tree as_base = CLASSTYPE_AS_BASE (type); tree arg = argarray[1]; diff --git a/gcc/testsuite/g++.dg/init/assign2.C b/gcc/testsuite/g++.dg/init/assign2.C new file mode 100644 index 00000000000..72d1264f3c9 --- /dev/null +++ b/gcc/testsuite/g++.dg/init/assign2.C @@ -0,0 +1,6 @@ +// PR c++/59950 + + struct Foo {}; + + int f(Foo *p); + int n = f(&(Foo() = Foo()));