From patchwork Sat Jan 22 11:59:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 50360 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 10D023858402 for ; Sat, 22 Jan 2022 12:00:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10D023858402 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1642852809; bh=MqnzU0pnTGtpFQIzVmDOj2swD3CdaITieML7xZmG3ww=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=JIXUstnIKWWYzMlS8pq6FCsg1H21JwmBmjNezk6NYpqf190oexOKAs3275EWVDS/D p0EhNXOM2xqMjm9sLR/lNaIyu2eVP1T29lLosm/R/PKfKP78CCR2Xf0fC7Uk8quZaY Lq9XX90dGDklWVt/N+RBObZbW2BS3CierDKW7hho= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5A14A3858D37 for ; Sat, 22 Jan 2022 11:59:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A14A3858D37 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-482-xEtyMeJQNzG9IbRVAHv9Jg-1; Sat, 22 Jan 2022 06:59:36 -0500 X-MC-Unique: xEtyMeJQNzG9IbRVAHv9Jg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2160818B62A4; Sat, 22 Jan 2022 11:59:35 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7058A6F94C; Sat, 22 Jan 2022 11:59:34 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 20MBxUa7393270 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 22 Jan 2022 12:59:31 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 20MBxTYQ393269; Sat, 22 Jan 2022 12:59:29 +0100 Date: Sat, 22 Jan 2022 12:59:29 +0100 To: Richard Biener , Jeff Law Subject: [PATCH] bootstrap: Fix bootstrap with --disable-plugin [PR104176] Message-ID: <20220122115929.GV2646553@tucnak> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! With --disable-plugin, bootstrap fails on x86_64-linux or probably all other targets with: ../../gcc/opts-global.cc: In function ‘void handle_common_deferred_options()’: ../../gcc/opts-global.cc:420:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag] 420 | error ("plugin support is disabled; configure with --enable-plugin"); | ^~~~~~~~~~~~~~~ ../../gcc/opts-global.cc:428:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag] 428 | error ("plugin support is disabled; configure with --enable-plugin"); | ^~~~~~~~~~~~~~~ The following patch fixes that, bootstrapped on x86_64-linux with --disable-plugin --enable-languages=c,c++ without the patch (where it failed as above) and with it (where it succeeded), ok for trunk? 2022-01-22 Jakub Jelinek PR other/104176 * opts-global.cc (handle_common_deferred_options): Quote --enable-plugin in diagnostics to avoid -Werror=format-diag. Jakub --- gcc/opts-global.cc.jj 2022-01-18 11:58:59.741979785 +0100 +++ gcc/opts-global.cc 2022-01-22 02:18:39.116047945 +0100 @@ -417,7 +417,8 @@ handle_common_deferred_options (void) #ifdef ENABLE_PLUGIN add_new_plugin (opt->arg); #else - error ("plugin support is disabled; configure with --enable-plugin"); + error ("plugin support is disabled; configure with " + "%<--enable-plugin%>"); #endif break; @@ -425,7 +426,8 @@ handle_common_deferred_options (void) #ifdef ENABLE_PLUGIN parse_plugin_arg_opt (opt->arg); #else - error ("plugin support is disabled; configure with --enable-plugin"); + error ("plugin support is disabled; configure with " + "%<--enable-plugin%>"); #endif break;