From patchwork Wed Jan 19 11:27:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 50227 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD9E03857C65 for ; Wed, 19 Jan 2022 11:28:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD9E03857C65 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1642591689; bh=J2r38l/+AXQaSK8avJqR7bL/AbYHTljzoesk3VyYTj0=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Dz5UCkHyr/FHV+m1OwIDWYil+oDyB7JIMDX0EyMTkV2LKWMSqGioeFAaybPDzJmIz Cs2tCz2Y+6lgCOALr94VogJIjXRfx64I6nRMivty/HHnPTuTP7Dn8+ILf7VqdDGM1G YKrfCzi2QgNr53tRy5WV8acLLwZuxFHspcUZLPPE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 710B13858D37 for ; Wed, 19 Jan 2022 11:27:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 710B13858D37 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-450-7eycz_9TNOiKsPtM2QUq2A-1; Wed, 19 Jan 2022 06:27:36 -0500 X-MC-Unique: 7eycz_9TNOiKsPtM2QUq2A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B737E1923E20; Wed, 19 Jan 2022 11:27:35 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.40.192.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1136270D51; Wed, 19 Jan 2022 11:27:34 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 20JBRXni2026427 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 19 Jan 2022 12:27:33 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 20JBRWKL2026426; Wed, 19 Jan 2022 12:27:32 +0100 Date: Wed, 19 Jan 2022 12:27:32 +0100 To: Sebastian Huber Subject: [committed] rs6000: Fix bootstrap Message-ID: <20220119112732.GS2646553@tucnak> References: <20220118115139.48203-1-sebastian.huber@embedded-brains.de> <20220118214223.GD614@gate.crashing.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, Segher Boessenkool Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" On Wed, Jan 19, 2022 at 07:54:19AM +0100, Sebastian Huber wrote: > On 18/01/2022 22:42, Segher Boessenkool wrote: > > > + default: > > > + break; > > Please don't do that. You can do > > > > default: > > break; > > break; > > /* And just to make sure: */ > > break; > > break; > > > > and it will do exactly the same as not having a default at all. Not > > having such useless code is by far the most readable, so please don't > > include a default case at all. > > I removed the default case. I hope this is what you wanted. Unfortunately the removal of default: break; breaks bootstrap: ../../gcc/config/rs6000/rs6000.cc: In function ‘const char* rs6000_machine_from_flags()’: ../../gcc/config/rs6000/rs6000.cc:5940:10: error: enumeration value ‘PROCESSOR_PPC601’ not handled in switch [-Werror=switch] 5940 | switch (rs6000_cpu) | ^ ../../gcc/config/rs6000/rs6000.cc:5940:10: error: enumeration value ‘PROCESSOR_PPC603’ not handled in switch [-Werror=switch] ... default: break; is needed to tell the -Wswitch warning that it is intentional that not all enumerators are handled in the switch. I've committed following as obvious to unbreak the bootstrap. 2022-01-19 Jakub Jelinek * config/rs6000/rs6000.cc (rs6000_machine_from_flags): Add default:. Jakub --- gcc/config/rs6000/rs6000.cc.jj +++ gcc/config/rs6000/rs6000.cc @@ -5958,6 +5958,9 @@ rs6000_machine_from_flags (void) case PROCESSOR_PPCE6500: return "e6500"; + + default: + break; } HOST_WIDE_INT flags = rs6000_isa_flags;