From patchwork Wed Jan 12 02:53:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 49892 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D3DF0393A414 for ; Wed, 12 Jan 2022 02:53:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D3DF0393A414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1641956028; bh=XOENsOwiThM03z6LtCx79vJoM+2PIpOkBormxApZrdc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=T6niE9CQib6jcMDXvWNeNOiLiEr+5tSdJl9wqoYh2kyKLphIfKSFu/9ZbEYfDrTzC RWVkTTEpzkNxVxmPuDLXDse+xr7IEZ8Ia+lSUhKIkmh7Yryid1tT7PPhohYWWDmqHc DiNBJvYmOhmV8A9vKaJZYOpGJmu1VR/5t/OU1IOo= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id DE7353858416 for ; Wed, 12 Jan 2022 02:53:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE7353858416 To: Subject: [Committed] cris: Parenthesize parameter to as_a. MIME-Version: 1.0 Message-ID: <20220112025318.5C3912040E@pchp3.se.axis.com> Date: Wed, 12 Jan 2022 03:53:18 +0100 X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Hans-Peter Nilsson via Gcc-patches From: Hans-Peter Nilsson Reply-To: Hans-Peter Nilsson Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Noted by Richard Sandiford in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103974#c7 (thanks!) Mea culpa: I wrongly thought the default development-level value ("yes,extra") would include everything interesting to normal target hacking (i.e. as opposed to hacking stuff like GC). I see rtl-checking is marked as "expensive" and presumably therefore left out. Maybe it could be split into rtl-static (cheap; catching type errors including this kind of foulups) and rtl-dynamic (the expensive parts). I suppose that's for whomever feels a strong enough itch. A quick (error-prone) grep-and-eyeball in config/ shows this was the only file missing the parenthesis. This lets cris-elf configured with --enable-checking=yes,extra,rtl survive make all-gcc. 2022-01-11 Hans-Peter Nilsson * config/cris/cris.c (cris_postdbr_cmpelim): Parenthesize parameter to as_a. --- gcc/config/cris/cris.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/cris/cris.c b/gcc/config/cris/cris.c index eff58435789e..ac1fc4909fc3 100644 --- a/gcc/config/cris/cris.c +++ b/gcc/config/cris/cris.c @@ -392,7 +392,7 @@ cris_postdbr_cmpelim () /* Consider filled delay slots; there might be a comparison there. It's only the second insn in a sequence that is interesting. */ if (GET_CODE (pat) == SEQUENCE) - insn = as_a XVECEXP (pat, 0, 1); + insn = as_a (XVECEXP (pat, 0, 1)); /* The "else" eliminates temptations to consider an insn in a delay slot for elimination; it can only be a prev_cc_setter. */ else if (prev_cc_setter != 0 && GET_CODE (pat) == SET)