diff mbox series

fixed testcase riscv/pr103302.c

Message ID 20211223073657.1057-1-shihua@iscas.ac.cn
State New
Headers show
Series fixed testcase riscv/pr103302.c | expand

Commit Message

廖仕华 Dec. 23, 2021, 7:36 a.m. UTC
From: LiaoShihua <shihua@iscas.ac.cn>

        because riscv32 not support __int128, so skip if -march=rv32*.

gcc/testsuite\ChangeLog:
        * gcc.target/riscv/pr103302.c: skip if -march=rv32*
---
 gcc/testsuite/gcc.target/riscv/pr103302.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Pinski Dec. 23, 2021, 7:41 a.m. UTC | #1
On Wed, Dec 22, 2021 at 11:37 PM <shihua@iscas.ac.cn> wrote:
>
> From: LiaoShihua <shihua@iscas.ac.cn>
>
>         because riscv32 not support __int128, so skip if -march=rv32*.
>
> gcc/testsuite\ChangeLog:
>         * gcc.target/riscv/pr103302.c: skip if -march=rv32*
> ---
>  gcc/testsuite/gcc.target/riscv/pr103302.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/pr103302.c b/gcc/testsuite/gcc.target/riscv/pr103302.c
> index 822c4087416..2cfb12498a2 100644
> --- a/gcc/testsuite/gcc.target/riscv/pr103302.c
> +++ b/gcc/testsuite/gcc.target/riscv/pr103302.c
> @@ -1,4 +1,5 @@
>  /* { dg-do run } */
> +/* { dg-skip-if "rv32 not support _int128" { *-*-* } { "-march=rv32*" } } */

Better fix:
/* { dg-do run { target int128 } } */

Thanks,
Andrew Pinski

>  /* { dg-options "-Og -fharden-compares -fno-tree-dce -fno-tree-fre " } */
>
>  typedef unsigned char u8;
> --
> 2.31.1.windows.1
>
Kito Cheng Dec. 27, 2021, 4:05 a.m. UTC | #2
Hi ShiHua:

Thanks for the fix, committed with Andrew's comment and minor fix for
commit comment.

On Thu, Dec 23, 2021 at 3:41 PM Andrew Pinski via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Wed, Dec 22, 2021 at 11:37 PM <shihua@iscas.ac.cn> wrote:
> >
> > From: LiaoShihua <shihua@iscas.ac.cn>
> >
> >         because riscv32 not support __int128, so skip if -march=rv32*.
> >
> > gcc/testsuite\ChangeLog:
> >         * gcc.target/riscv/pr103302.c: skip if -march=rv32*
> > ---
> >  gcc/testsuite/gcc.target/riscv/pr103302.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/gcc/testsuite/gcc.target/riscv/pr103302.c b/gcc/testsuite/gcc.target/riscv/pr103302.c
> > index 822c4087416..2cfb12498a2 100644
> > --- a/gcc/testsuite/gcc.target/riscv/pr103302.c
> > +++ b/gcc/testsuite/gcc.target/riscv/pr103302.c
> > @@ -1,4 +1,5 @@
> >  /* { dg-do run } */
> > +/* { dg-skip-if "rv32 not support _int128" { *-*-* } { "-march=rv32*" } } */
>
> Better fix:
> /* { dg-do run { target int128 } } */
>
> Thanks,
> Andrew Pinski
>
> >  /* { dg-options "-Og -fharden-compares -fno-tree-dce -fno-tree-fre " } */
> >
> >  typedef unsigned char u8;
> > --
> > 2.31.1.windows.1
> >
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/riscv/pr103302.c b/gcc/testsuite/gcc.target/riscv/pr103302.c
index 822c4087416..2cfb12498a2 100644
--- a/gcc/testsuite/gcc.target/riscv/pr103302.c
+++ b/gcc/testsuite/gcc.target/riscv/pr103302.c
@@ -1,4 +1,5 @@ 
 /* { dg-do run } */
+/* { dg-skip-if "rv32 not support _int128" { *-*-* } { "-march=rv32*" } } */
 /* { dg-options "-Og -fharden-compares -fno-tree-dce -fno-tree-fre " } */
 
 typedef unsigned char u8;