From patchwork Thu Dec 2 16:28:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 48400 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 03EEB385AC36 for ; Thu, 2 Dec 2021 16:36:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 03EEB385AC36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1638462982; bh=P/xLO+vI/ZX2MyoKTlcrFz9jP38pu8U5gRbWXgr1NhM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=eHf0KY2cGxJ8H9urLz6wcvALVrZ5Jbie+sn1EN/SEr+dIKNfkzfffBPb9xRtldbJc a9ZBGyaIkAjbWl04g+Wn5/Bed1Vnw4QT/b2ZelkqDtmUpcFpK/6XL1P655OaNTWI4o P6VPfnzGcb7rPLANmQ3mtaPR/f6qQ32Zwgl0CA0Q= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id D3D03385AC1F for ; Thu, 2 Dec 2021 16:28:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D3D03385AC1F Received: by mail-wr1-x42e.google.com with SMTP id j3so60841039wrp.1 for ; Thu, 02 Dec 2021 08:28:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=P/xLO+vI/ZX2MyoKTlcrFz9jP38pu8U5gRbWXgr1NhM=; b=bdALdMYKLneW5NdoJpwo2Faf9D/M2jxtQ4CGwWdnE2ldSKQv2F1GpHqOcM4myfCfWa gqgeP7ErgkqwlG9bWF/l6j535qr9/bb3aiGgnrMc2F14/BSt1lgcdrwYRgFMznZMcupF Itq/67IpI2x5IwYecl3N+cJ/l00xP+td8X37+zWFehprJXVTnBk+k9IzSZJEfghD2jU/ qVXhVsVcNv4u/f+RRNhGkY4Acm+unUdTjrxzwO2/uPZnbygirZR9or3/4xwYE5cRbrMA hJov66NcO74BtSeRZnDqGoJZe4TNJeJof0g9lHwRn7tuThjKdntnj2Ybm3+PA6rvHiLc KrwA== X-Gm-Message-State: AOAM53114FZ2uVOJ/9IyGo5/K2fUWq0uUE4ECUsMN5Jb9rdJu6AKV014 lBmy4nLXtGSiPbH1qSidoKnMAN6yqjBIYg== X-Google-Smtp-Source: ABdhPJzQSKosI+7jlFlq9EIKPqZZa8dUzHbXWj2srTP36K8CvQKUyGVHtPM4fNUtEu4LRMswdqwH7A== X-Received: by 2002:adf:e842:: with SMTP id d2mr15469630wrn.399.1638462523635; Thu, 02 Dec 2021 08:28:43 -0800 (PST) Received: from adacore.com ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id o25sm151727wms.17.2021.12.02.08.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Dec 2021 08:28:42 -0800 (PST) Date: Thu, 2 Dec 2021 16:28:42 +0000 To: gcc-patches@gcc.gnu.org Subject: [Ada] Remove duplicated condition in warnings about read-before-write Message-ID: <20211202162842.GA2157432@adacore.com> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Pierre-Marie de Rodat via Gcc-patches From: Pierre-Marie de Rodat Reply-To: Pierre-Marie de Rodat Cc: Piotr Trojanek Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Code for warnings about read-before-write of a variable had one condition in the outer IF statement and then the very same condition in an inner IF statement. Cleanup related to spurious warning on 'Initialized. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_warn.adb (Check_References): Remove redundant condition. diff --git a/gcc/ada/sem_warn.adb b/gcc/ada/sem_warn.adb --- a/gcc/ada/sem_warn.adb +++ b/gcc/ada/sem_warn.adb @@ -1569,15 +1569,13 @@ package body Sem_Warn is -- For access types, UR was only set for dereferences, -- so the issue is that the value may be null. - if not Is_Trivial_Subprogram (Scope (E1)) then - if not Warnings_Off_E1 then - if Is_Access_Type (Etype (Parent (UR))) then - Error_Msg_N ("??`&.&` may be null!", UR); - else - Error_Msg_N - ("??`&.&` may be referenced before " - & "it has a value!", UR); - end if; + if not Warnings_Off_E1 then + if Is_Access_Type (Etype (Parent (UR))) then + Error_Msg_N ("??`&.&` may be null!", UR); + else + Error_Msg_N + ("??`&.&` may be referenced before " + & "it has a value!", UR); end if; end if;