From patchwork Wed Dec 1 09:26:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 48323 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 63C7B3858419 for ; Wed, 1 Dec 2021 09:26:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63C7B3858419 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1638350808; bh=kMpsEzmTM6/310tzrFV6Ua/T2ZO4Qp67a+aG6MwT0uY=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=Pe4q/cVNYQYekBfet21iZ8HhfV8KnnIi+T7oVS54hc5CyAeRk/MVCRlcC+kViJD2g Hc0ygEFC12x+U02Q5b25bRRae1xt9hsuChXB+6LWrRxOnBn+ushs6AlRKZpe7SUJwz j13wZE8ExcXU+DkOseiGIz5NC8ZbPobbK81bRBpE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BE9213858401 for ; Wed, 1 Dec 2021 09:26:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE9213858401 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-358-hudptuR2Omedv-bInVjYvw-1; Wed, 01 Dec 2021 04:26:16 -0500 X-MC-Unique: hudptuR2Omedv-bInVjYvw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 87C51192780A; Wed, 1 Dec 2021 09:26:15 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.188]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F6E4781EB; Wed, 1 Dec 2021 09:26:14 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1B19QCm9983008 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 1 Dec 2021 10:26:12 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1B19QBNJ983007; Wed, 1 Dec 2021 10:26:11 +0100 Date: Wed, 1 Dec 2021 10:26:11 +0100 To: Uros Bizjak Subject: [committed] i386: Fix up some minor formatting issues and one inconsistency Message-ID: <20211201092611.GU2646553@tucnak> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! While looking at a proposed vendor backport, I've noticed some formatting issues in x86-tune.def. Also, in all spots m_GENERIC comes last, except one recently changed, I think it is useful to have m_GENERIC always last for consistency. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2021-12-01 Jakub Jelinek * config/i386/x86-tune.def (X86_TUNE_SCHEDULE, X86_TUNE_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY, X86_TUNE_MISALIGNED_MOVE_STRING_PRO_EPILOGUES): Formatting fixes. (X86_TUNE_USE_GATHER): Put m_GENERIC last for consistency. Jakub --- gcc/config/i386/x86-tune.def.jj 2021-11-11 14:35:37.537349474 +0100 +++ gcc/config/i386/x86-tune.def 2021-11-30 15:26:24.126226934 +0100 @@ -42,7 +42,7 @@ see the files COPYING3 and COPYING.RUNTI DEF_TUNE (X86_TUNE_SCHEDULE, "schedule", m_PENT | m_LAKEMONT | m_PPRO | m_CORE_ALL | m_BONNELL | m_SILVERMONT | m_INTEL | m_KNL | m_KNM | m_K6_GEODE | m_AMD_MULTIPLE | m_GOLDMONT - | m_GOLDMONT_PLUS | m_TREMONT | m_ALDERLAKE |m_GENERIC) + | m_GOLDMONT_PLUS | m_TREMONT | m_ALDERLAKE | m_GENERIC) /* X86_TUNE_PARTIAL_REG_DEPENDENCY: Enable more register renaming on modern chips. Preffer stores affecting whole integer register @@ -70,7 +70,7 @@ DEF_TUNE (X86_TUNE_SSE_PARTIAL_REG_DEPEN DEF_TUNE (X86_TUNE_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY, "sse_partial_reg_fp_converts_dependency", m_PPRO | m_P4_NOCONA | m_CORE_ALL | m_BONNELL | m_AMDFAM10 - | m_BDVER | m_ZNVER | m_ALDERLAKE| m_GENERIC) + | m_BDVER | m_ZNVER | m_ALDERLAKE | m_GENERIC) /* X86_TUNE_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY: This knob avoids partial write to the destination in scalar SSE conversion from integer to FP. */ @@ -298,7 +298,7 @@ DEF_TUNE (X86_TUNE_PREFER_KNOWN_REP_MOVS DEF_TUNE (X86_TUNE_MISALIGNED_MOVE_STRING_PRO_EPILOGUES, "misaligned_move_string_pro_epilogues", m_386 | m_486 | m_CORE_ALL | m_AMD_MULTIPLE | m_TREMONT - | m_ALDERLAKE |m_GENERIC) + | m_ALDERLAKE | m_GENERIC) /* X86_TUNE_USE_SAHF: Controls use of SAHF. */ DEF_TUNE (X86_TUNE_USE_SAHF, "use_sahf", @@ -460,7 +460,7 @@ DEF_TUNE (X86_TUNE_AVOID_4BYTE_PREFIXES, /* X86_TUNE_USE_GATHER: Use gather instructions. */ DEF_TUNE (X86_TUNE_USE_GATHER, "use_gather", - ~(m_ZNVER1 | m_ZNVER2 | m_GENERIC | m_ALDERLAKE)) + ~(m_ZNVER1 | m_ZNVER2 | m_ALDERLAKE | m_GENERIC)) /* X86_TUNE_AVOID_128FMA_CHAINS: Avoid creating loops with tight 128bit or smaller FMA chain. */