diff mbox series

Fix ICE in tree-ssa-structalias

Message ID 20211112153624.GB13726@kam.mff.cuni.cz
State Committed
Commit 4526ec20f17a6182f754da9460d9d944dd123cc0
Headers
Series Fix ICE in tree-ssa-structalias |

Commit Message

Jan Hubicka Nov. 12, 2021, 3:36 p.m. UTC 
  Hi,
this patch fixes ICE in sanity check of EAF flags determined: we can not
escape/clobber/return param indirectly w/o reading it.
I moved check earlier and fixed the wrong updates.

Boottrapped/regtested x86_64-linux, comitted.

Honza

	PR tree-optimization/103175
	* ipa-modref.c (modref_lattice::merge): Add sanity check.
	(callee_to_caller_flags): Make flags adjustment sane.
	(modref_eaf_analysis::analyze_ssa_name): Likewise.
diff mbox series

Patch

diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
index 44b3427a202..e999c2c5d1e 100644
--- a/gcc/ipa-modref.c
+++ b/gcc/ipa-modref.c
@@ -1681,6 +1681,13 @@  modref_lattice::merge (int f)
 {
   if (f & EAF_UNUSED)
     return false;
+  /* Check that flags seems sane: if function does not read the parameter
+     it can not access it indirectly.  */
+  gcc_checking_assert (!(f & EAF_NO_DIRECT_READ)
+		       || ((f & EAF_NO_INDIRECT_READ)
+			   && (f & EAF_NO_INDIRECT_CLOBBER)
+			   && (f & EAF_NO_INDIRECT_ESCAPE)
+			   && (f & EAF_NOT_RETURNED_INDIRECTLY)));
   if ((flags & f) != flags)
     {
       flags &= f;
@@ -1889,9 +1896,11 @@  callee_to_caller_flags (int call_flags, bool ignore_stores,
       if (!(call_flags & EAF_NO_DIRECT_ESCAPE))
 	lattice.merge (~(EAF_NOT_RETURNED_DIRECTLY
 			 | EAF_NOT_RETURNED_INDIRECTLY
+			 | EAF_NO_DIRECT_READ
 			 | EAF_UNUSED));
       if (!(call_flags & EAF_NO_INDIRECT_ESCAPE))
 	lattice.merge (~(EAF_NOT_RETURNED_INDIRECTLY
+			 | EAF_NO_DIRECT_READ
 			 | EAF_UNUSED));
     }
   else
@@ -2033,11 +2042,11 @@  modref_eaf_analysis::analyze_ssa_name (tree name)
 			  if (!(call_flags & (EAF_NOT_RETURNED_DIRECTLY
 					      | EAF_UNUSED)))
 			    m_lattice[index].merge (~(EAF_NO_DIRECT_ESCAPE
-						      | EAF_NO_INDIRECT_ESCAPE
 						      | EAF_UNUSED));
 			  if (!(call_flags & (EAF_NOT_RETURNED_INDIRECTLY
 					      | EAF_UNUSED)))
 			    m_lattice[index].merge (~(EAF_NO_INDIRECT_ESCAPE
+						      | EAF_NO_DIRECT_READ
 						      | EAF_UNUSED));
 			  call_flags = callee_to_caller_flags
 					   (call_flags, false,