diff mbox series

powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain

Message ID 20211109133946.1983974-1-lamm@linux.ibm.com
State Committed
Commit 9598134a055e9426fa283e51dac178d11af2c668
Headers
Series powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain |

Commit Message

Lucas A. M. Magalhaes Nov. 9, 2021, 1:39 p.m. UTC 
  Ping.

-- >8 --

Historically this was added to fill gaps from ld.so.cache on early AT
releases. This now are just causing errors and rework. Since AT5.0 the
AT's ld.so is using a correctly configured ld.so.cache and sets the
DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
builded program to get the correct libraries.

GCC congured with --with-advance-toolchain has issues building GlibC
releases because it adds DT_RUNPATH to ld.so and that's unsupported.

2021-03-11  Lucas A. M. Magalhães  <lamm@linux.ibm.com>

gcc/
	* config.gcc (powerpc*-*-*): Remove -rpath from
	  --with-advance-toochain
---
 gcc/config.gcc | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Segher Boessenkool Nov. 9, 2021, 2:19 p.m. UTC | #1 
Hi!

On Tue, Nov 09, 2021 at 10:39:46AM -0300, Lucas A. M. Magalhaes wrote:
> Ping.

I did not get the original, and neither did the archives?

> Historically this was added to fill gaps from ld.so.cache on early AT
> releases. This now are just causing errors and rework. Since AT5.0 the
> AT's ld.so is using a correctly configured ld.so.cache and sets the
> DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
> builded program to get the correct libraries.
> 
> GCC congured with --with-advance-toolchain has issues building GlibC
> releases because it adds DT_RUNPATH to ld.so and that's unsupported.
> 
> 2021-03-11  Lucas A. M. Magalhães  <lamm@linux.ibm.com>

2021-11-03

> 	* config.gcc (powerpc*-*-*): Remove -rpath from
> 	  --with-advance-toochain

The start of the line aligns with the star.  Changelog lines end in a
full stop.  It's "toolchain".

The patch is okay for trunk.  Thanks!  Do you need backports as well?
Those are fine as well :-)


Segher
Lucas A. M. Magalhaes Nov. 9, 2021, 7:03 p.m. UTC | #2 
Quoting Segher Boessenkool (2021-11-09 11:19:58)
> Hi!
> 
> On Tue, Nov 09, 2021 at 10:39:46AM -0300, Lucas A. M. Magalhaes wrote:
> > Ping.
> 
> I did not get the original, and neither did the archives?
> 
Strange, it's on the archives.
https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582643.html
Looking at my local mails, I did't receive it as well.

> > Historically this was added to fill gaps from ld.so.cache on early AT
> > releases. This now are just causing errors and rework. Since AT5.0 the
> > AT's ld.so is using a correctly configured ld.so.cache and sets the
> > DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
> > builded program to get the correct libraries.
> > 
> > GCC congured with --with-advance-toolchain has issues building GlibC
> > releases because it adds DT_RUNPATH to ld.so and that's unsupported.
> > 
> > 2021-03-11  Lucas A. M. Magalhães  <lamm@linux.ibm.com>
> 
> 2021-11-03
> 
> >       * config.gcc (powerpc*-*-*): Remove -rpath from
> >         --with-advance-toochain
> 
> The start of the line aligns with the star.  Changelog lines end in a
> full stop.  It's "toolchain".
> 
> The patch is okay for trunk.  Thanks!  Do you need backports as well?
> Those are fine as well :-)
I don't think we need a backport.
Segher can you push this with the changes or should I send a V2?

---
Lucas A. M. Magalhães
Segher Boessenkool Nov. 10, 2021, 2:39 p.m. UTC | #3 
On Tue, Nov 09, 2021 at 04:03:55PM -0300, Lucas A. M. Magalhaes wrote:
> Quoting Segher Boessenkool (2021-11-09 11:19:58)
> > On Tue, Nov 09, 2021 at 10:39:46AM -0300, Lucas A. M. Magalhaes wrote:
> > > Ping.
> > 
> > I did not get the original, and neither did the archives?
> > 
> Strange, it's on the archives.
> https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582643.html
> Looking at my local mails, I did't receive it as well.

Ah.  Because your changelog suggested this patch is from November, I
didn't look at earlier archives :-)


Segher
diff mbox series

Patch

diff --git a/gcc/config.gcc b/gcc/config.gcc
index fb1f06f3da8..9eba3ece0a9 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -5088,16 +5088,6 @@  case "${target}" in
 			(at="/opt/$with_advance_toolchain"
 			 echo "/* Use Advance Toolchain $at */"
 			 echo
-			 echo "#undef  LINK_OS_EXTRA_SPEC32"
-			 echo "#define LINK_OS_EXTRA_SPEC32" \
-			      "\"%(link_os_new_dtags)" \
-			      "-rpath $prefix/lib -rpath $at/lib\""
-			 echo
-			 echo "#undef  LINK_OS_EXTRA_SPEC64"
-			 echo "#define LINK_OS_EXTRA_SPEC64" \
-			      "\"%(link_os_new_dtags)" \
-			      "-rpath $prefix/lib64 -rpath $at/lib64\""
-			 echo
 			 echo "#undef  LINK_OS_NEW_DTAGS_SPEC"
 			 echo "#define LINK_OS_NEW_DTAGS_SPEC" \
 			      "\"--enable-new-dtags\""