diff mbox series

[01/21] Fix riscv_expand_block_move

Message ID	20211031093445.1414518-2-siyu@isrc.iscas.ac.cn
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 309F23858408 From: siyu@isrc.iscas.ac.cn To: gcc-patches@gcc.gnu.org Subject: [PATCH 01/21] Fix riscv_expand_block_move Date: Sun, 31 Oct 2021 17:34:25 +0800 Message-Id: <20211031093445.1414518-2-siyu@isrc.iscas.ac.cn> In-Reply-To: <20211031093445.1414518-1-siyu@isrc.iscas.ac.cn> References: <20211031093445.1414518-1-siyu@isrc.iscas.ac.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Cc: ben.marshall@pqshield.com, linsinan1995 <47880367+linsinan1995@users.noreply.github.com>, cmuellner@ventanamicro.com, andrew@sifive.com, Richard.Newell@microchip.com, jiawei@iscas.ac.cn, mjos@pqshield.com, kito.cheng@sifive.com Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org>
Series	RISC-V: add gcc support for Scalar Cryptography v1.0.0-rc5 \| [00/21] RISC-V: add gcc support for Scalar Cryptography v1.0.0-rc5 [01/21] Fix riscv_expand_block_move [02/21] Fix attribute bugs due to zicsr/zifencei [03/21,crypto] : add machine description for Zknd and Zkne [04/21,crypto] : add builtins for Zknd and Zkne [05/21,crypto] : add testcases for Zknd and Zkne [06/21,crypto] : add machine description for Zknh [07/21,crypto] : add builtins for Zknh [08/21,crypto] : add testcases for Zknh [09/21,crypto] : add machine description for Zksed [10/21,crypto] : add builtins for Zksed [11/21,crypto] : add testcases for Zksed [12/21,crypto] : add machine description for Zksh [13/21,crypto] : add builtins for Zksh [14/21,crypto] : add testcases for Zksh [15/21,crypto] : add option defines for Zkr and Zkt [16/21,crypto] : add option defines for Zbkb, Zbkc and Zbkx [17/21,crypto] : add implied defines of Zk, Zkn and Zks [18/21] change z* subset assert to allow "zk" [19/21,crypto] : add machine description for Zbkx [20/21,crypto] : add builtins for Zbkx [21/21,crypto] : add testcases for Zbkx

Commit Message

siyu@isrc.iscas.ac.cn Oct. 31, 2021, 9:34 a.m. UTC

  From: linsinan1995 <47880367+linsinan1995@users.noreply.github.com>

---
 gcc/config/riscv/riscv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kito Cheng Nov. 2, 2021, 10:45 a.m. UTC | #1

IIRC this issue should be resolved?

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99314

On Sun, Oct 31, 2021 at 5:34 PM <siyu@isrc.iscas.ac.cn> wrote:
>
> From: linsinan1995 <47880367+linsinan1995@users.noreply.github.com>
>
> ---
>  gcc/config/riscv/riscv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c
> index 6aef3d3a6cf..0529b6d60cd 100644
> --- a/gcc/config/riscv/riscv.c
> +++ b/gcc/config/riscv/riscv.c
> @@ -3491,7 +3491,7 @@ riscv_block_move_loop (rtx dest, rtx src, unsigned HOST_WIDE_INT length,
>  bool
>  riscv_expand_block_move (rtx dest, rtx src, rtx length)
>  {
> -  if (CONST_INT_P (length))
> +  if (CONST_INT_P (length) && INTVAL (length) >= 0)
>      {
>        unsigned HOST_WIDE_INT hwi_length = UINTVAL (length);
>        unsigned HOST_WIDE_INT factor, align;
> --
> 2.25.1
>

diff mbox series

Patch

diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c
index 6aef3d3a6cf..0529b6d60cd 100644
--- a/gcc/config/riscv/riscv.c
+++ b/gcc/config/riscv/riscv.c
@@ -3491,7 +3491,7 @@  riscv_block_move_loop (rtx dest, rtx src, unsigned HOST_WIDE_INT length,
 bool
 riscv_expand_block_move (rtx dest, rtx src, rtx length)
 {
-  if (CONST_INT_P (length))
+  if (CONST_INT_P (length) && INTVAL (length) >= 0)
     {
       unsigned HOST_WIDE_INT hwi_length = UINTVAL (length);
       unsigned HOST_WIDE_INT factor, align;