From patchwork Tue Oct 26 12:44:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 46661 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 42DDD3858026 for ; Tue, 26 Oct 2021 12:46:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42DDD3858026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1635252366; bh=xem6XBYPTM+EE/3XBhjHGrkf64bqRN0AcfJQ3bCub/w=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=cS6hX480s36W+uak1YWoYasAla0nRq0tlN8Wj4EDwbsWYrYaHM9CpTEzlaiOjRaOh pluT8ghg330kNSlrqIlpFk1jAM/PMyCXm6pSYtnVCcQltcqsmvN1sVVyxdqW9H4uQ2 z8hV1roV58faGlMhoiabUZV8huKD5iY/f1Lv//D0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id DF2E23858410 for ; Tue, 26 Oct 2021 12:44:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF2E23858410 Received: by mail-wr1-x42f.google.com with SMTP id d13so16506299wrf.11 for ; Tue, 26 Oct 2021 05:44:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xem6XBYPTM+EE/3XBhjHGrkf64bqRN0AcfJQ3bCub/w=; b=xn76reUUyM3ZwEs7d//f6PawidOYhTuuaEeiPGP3miOisGa7DpnOWBJvR///YxwYwe DUQD7IWUYOaJXSFt+DjG2CzRgoGP6LbhJ51+urwrN/GtOCCTVy9ayVPvkhCUobjAFF9H 1zlImcJZcZGQ6KFxhoBF9XjfsK59FHF/ZcNnVXtwV/mA+b0Emowor0fPfMXaNvT4ww1g 4mfvF5OzW/1YQz/5YJu1Jj4NzdU9I1V7XCig12rPJRifqDprtFyBSXeByRNel+lJdhpJ 73rqKwKQN8OAPKZBmIz7G4fHOUkJkVDbq/UGWtVAYCm6ZmDLV24Og9nfiIiL5cYf2++8 RxhA== X-Gm-Message-State: AOAM531BZ2G/QJ1lwTpIL4NiY8qOTiFm0PL7iDIv06dPbqRfkthZTPgz Hv86GbH/hdGaw170eDAILrK4HDlMSkdbCA== X-Google-Smtp-Source: ABdhPJxW8VaUbfAvbNml7WlYi3JQh0OBli/fbwanrmTLww1ucn+axBzdjPhgHeE5PNYiK7uuJC8A6g== X-Received: by 2002:a5d:6484:: with SMTP id o4mr31590772wri.337.1635252278734; Tue, 26 Oct 2021 05:44:38 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:6b9e:385e:1583:4f40]) by smtp.gmail.com with ESMTPSA id n68sm496146wmn.13.2021.10.26.05.44.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 05:44:38 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH 2/4] gcc: Fix "argument list too long" from install-plugins Date: Tue, 26 Oct 2021 13:44:35 +0100 Message-Id: <20211026124437.3301773-2-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211026124437.3301773-1-richard.purdie@linuxfoundation.org> References: <20211026124437.3301773-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Purdie via Gcc-patches From: Richard Purdie Reply-To: Richard Purdie Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" When building in longer build paths (200+ characters), the "echo $(PLUGIN_HEADERS)" from the install-plugins target would cause an "argument list too long error" on some systems. Avoid this by calling make's sort function on the list which removes duplicates and stops the overflow from reaching the echo command. The original sort is left to handle the the .h and .def files. 2021-10-26 Richard Purdie gcc/ChangeLog: * Makefile.in: Fix "argument list too long" from install-plugins Signed-off-by: Richard Purdie --- gcc/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/Makefile.in b/gcc/Makefile.in index 658093c11c0..89482c6dd4e 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -3685,7 +3685,7 @@ install-plugin: installdirs lang.install-plugin s-header-vars install-gengtype # We keep the directory structure for files in config, common/config or # c-family and .def files. All other files are flattened to a single directory. $(mkinstalldirs) $(DESTDIR)$(plugin_includedir) - headers=`echo $(PLUGIN_HEADERS) $$(cd $(srcdir); echo *.h *.def) | tr ' ' '\012' | sort -u`; \ + headers=`echo $(sort $(PLUGIN_HEADERS)) $$(cd $(srcdir); echo *.h *.def) | tr ' ' '\012' | sort -u`; \ srcdirstrip=`echo "$(srcdir)" | sed 's/[].[^$$\\*|]/\\\\&/g'`; \ for file in $$headers; do \ if [ -f $$file ] ; then \