x86: Document -fcf-protection requires i686 or newer

Message ID 20211021164722.500302-1-hjl.tools@gmail.com
State Committed
Commit 1373066a46d8d47abd97e46a005aef3b3dbfe94a
Headers
Series x86: Document -fcf-protection requires i686 or newer |

Commit Message

H.J. Lu Oct. 21, 2021, 4:47 p.m. UTC
  PR target/98667
	* doc/invoke.texi: Document -fcf-protection requires i686 or
	new.
---
 gcc/doc/invoke.texi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Uros Bizjak Oct. 21, 2021, 7:04 p.m. UTC | #1
On Thu, Oct 21, 2021 at 6:47 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
>         PR target/98667
>         * doc/invoke.texi: Document -fcf-protection requires i686 or
>         new.

Obvious patch?

Uros.

> ---
>  gcc/doc/invoke.texi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index c66a25fcd69..71992b8c597 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation
>  (@pxref{Function Attributes}).
>
>  Currently the x86 GNU/Linux target provides an implementation based
> -on Intel Control-flow Enforcement Technology (CET).
> +on Intel Control-flow Enforcement Technology (CET) which works for
> +i686 processor or newer.
>
>  @item -fstack-protector
>  @opindex fstack-protector
> --
> 2.32.0
>
  
H.J. Lu Oct. 21, 2021, 7:08 p.m. UTC | #2
On Thu, Oct 21, 2021 at 12:04 PM Uros Bizjak <ubizjak@gmail.com> wrote:
>
> On Thu, Oct 21, 2021 at 6:47 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> >         PR target/98667
> >         * doc/invoke.texi: Document -fcf-protection requires i686 or
> >         new.
>
> Obvious patch?

I am checking it in and backporting it to release branches.

Thanks.

> Uros.
>
> > ---
> >  gcc/doc/invoke.texi | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> > index c66a25fcd69..71992b8c597 100644
> > --- a/gcc/doc/invoke.texi
> > +++ b/gcc/doc/invoke.texi
> > @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation
> >  (@pxref{Function Attributes}).
> >
> >  Currently the x86 GNU/Linux target provides an implementation based
> > -on Intel Control-flow Enforcement Technology (CET).
> > +on Intel Control-flow Enforcement Technology (CET) which works for
> > +i686 processor or newer.
> >
> >  @item -fstack-protector
> >  @opindex fstack-protector
> > --
> > 2.32.0
> >
  
Eric Gallager Oct. 29, 2021, 10:03 p.m. UTC | #3
On Thu, Oct 21, 2021 at 12:49 PM H.J. Lu via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>         PR target/98667
>         * doc/invoke.texi: Document -fcf-protection requires i686 or
>         new.
> ---
>  gcc/doc/invoke.texi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index c66a25fcd69..71992b8c597 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation
>  (@pxref{Function Attributes}).
>
>  Currently the x86 GNU/Linux target provides an implementation based
> -on Intel Control-flow Enforcement Technology (CET).
> +on Intel Control-flow Enforcement Technology (CET) which works for
> +i686 processor or newer.

I think "processor" should be pluralized to "processors"? Also,
possibly a missing comma after "(CET)"?

>
>  @item -fstack-protector
>  @opindex fstack-protector
> --
> 2.32.0
>
  
H.J. Lu Nov. 1, 2021, 11:21 a.m. UTC | #4
On Fri, Oct 29, 2021 at 3:04 PM Eric Gallager <egall@gwmail.gwu.edu> wrote:
>
> On Thu, Oct 21, 2021 at 12:49 PM H.J. Lu via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> >         PR target/98667
> >         * doc/invoke.texi: Document -fcf-protection requires i686 or
> >         new.
> > ---
> >  gcc/doc/invoke.texi | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> > index c66a25fcd69..71992b8c597 100644
> > --- a/gcc/doc/invoke.texi
> > +++ b/gcc/doc/invoke.texi
> > @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation
> >  (@pxref{Function Attributes}).
> >
> >  Currently the x86 GNU/Linux target provides an implementation based
> > -on Intel Control-flow Enforcement Technology (CET).
> > +on Intel Control-flow Enforcement Technology (CET) which works for
> > +i686 processor or newer.
>
> I think "processor" should be pluralized to "processors"? Also,
> possibly a missing comma after "(CET)"?
>

Can you submit a patch?

Thanks.
  

Patch

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index c66a25fcd69..71992b8c597 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -15542,7 +15542,8 @@  which functions and calls should be skipped from instrumentation
 (@pxref{Function Attributes}).
 
 Currently the x86 GNU/Linux target provides an implementation based
-on Intel Control-flow Enforcement Technology (CET).
+on Intel Control-flow Enforcement Technology (CET) which works for
+i686 processor or newer.
 
 @item -fstack-protector
 @opindex fstack-protector