Message ID | 20211021164722.500302-1-hjl.tools@gmail.com |
---|---|
State | Committed |
Commit | 1373066a46d8d47abd97e46a005aef3b3dbfe94a |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D5ED3857C77 for <patchwork@sourceware.org>; Thu, 21 Oct 2021 16:49:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D5ED3857C77 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1634834955; bh=L3USyBZ+i0IQhPlSCKXdLWqb9ew9JHqKuK34B3CSksY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=RV1RugBfjd/qeXHLHHc+b6WbyF8Q1WAsKcOhujoQqLT5D3jbwJ7v8cvvDP2H4xVW4 zEIc9CXmPzXvoqSZLcTh5ML1nwjN9K4AZyj0RDvT7Z8a2TWJfjni08v9Qzzacz+NNe y3AMi3n719OBjvvuLl9gRu0EUWLc56Vij/SCTqGc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id 18FD03857C5D for <gcc-patches@gcc.gnu.org>; Thu, 21 Oct 2021 16:47:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18FD03857C5D Received: by mail-pj1-x1033.google.com with SMTP id ls14-20020a17090b350e00b001a00e2251c8so967124pjb.4 for <gcc-patches@gcc.gnu.org>; Thu, 21 Oct 2021 09:47:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=L3USyBZ+i0IQhPlSCKXdLWqb9ew9JHqKuK34B3CSksY=; b=liicGBePrA53tycB1Kxwq5/fMXCGmQkO0+z2KZ0bulqIRuPuWwJgpL5r53DBFdgcSa pAcpuI89OibZIdnJFpOEomcx3AngbCKts5zSz13DKNh/GigObyWaFFJ0QfRxNlEoOEtY YHi8pshB1o7654kEvRojH95Zhcvw1vM1IBPfpjxgJoAVRwFtGe+0hllwSxajK30Na09L gKm776Rdwk9pHWlW5QKich6xPT72qfoDQCe/pjfmVHTSgtgV/lcWjZLISwlRlL+NxrNF kbuAu7Fa36VS2dyKAkWNd9pqhrcwNgqCZk9DWPpd9hxJKpnXaH3M3Yrd0QWLK0hcrHoi MuYQ== X-Gm-Message-State: AOAM532AkA828X2CkI32edD50PzYj7atxFO2taGxafgTDsMchUHPgKVZ j6jL61fmh1gPzcATg81fcYd7Va5Gnck= X-Google-Smtp-Source: ABdhPJw9zFblVjAZbkslE6a7BJg9v5qmM2JHKWBks8/bu91BfQ23uN8c2y83KmQXP4P7FkuvabmgDg== X-Received: by 2002:a17:90b:1c90:: with SMTP id oo16mr7814146pjb.199.1634834843888; Thu, 21 Oct 2021 09:47:23 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.58.39.6]) by smtp.gmail.com with ESMTPSA id s20sm7018890pfk.131.2021.10.21.09.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 09:47:23 -0700 (PDT) Received: from gnu-cfl-2.lan (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id DA4561A00E1; Thu, 21 Oct 2021 09:47:22 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH] x86: Document -fcf-protection requires i686 or newer Date: Thu, 21 Oct 2021 09:47:22 -0700 Message-Id: <20211021164722.500302-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: "H.J. Lu via Gcc-patches" <gcc-patches@gcc.gnu.org> Reply-To: "H.J. Lu" <hjl.tools@gmail.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
x86: Document -fcf-protection requires i686 or newer
|
|
Commit Message
H.J. Lu
Oct. 21, 2021, 4:47 p.m. UTC
PR target/98667 * doc/invoke.texi: Document -fcf-protection requires i686 or new. --- gcc/doc/invoke.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Thu, Oct 21, 2021 at 6:47 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > PR target/98667 > * doc/invoke.texi: Document -fcf-protection requires i686 or > new. Obvious patch? Uros. > --- > gcc/doc/invoke.texi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index c66a25fcd69..71992b8c597 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation > (@pxref{Function Attributes}). > > Currently the x86 GNU/Linux target provides an implementation based > -on Intel Control-flow Enforcement Technology (CET). > +on Intel Control-flow Enforcement Technology (CET) which works for > +i686 processor or newer. > > @item -fstack-protector > @opindex fstack-protector > -- > 2.32.0 >
On Thu, Oct 21, 2021 at 12:04 PM Uros Bizjak <ubizjak@gmail.com> wrote: > > On Thu, Oct 21, 2021 at 6:47 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > > > PR target/98667 > > * doc/invoke.texi: Document -fcf-protection requires i686 or > > new. > > Obvious patch? I am checking it in and backporting it to release branches. Thanks. > Uros. > > > --- > > gcc/doc/invoke.texi | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > > index c66a25fcd69..71992b8c597 100644 > > --- a/gcc/doc/invoke.texi > > +++ b/gcc/doc/invoke.texi > > @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation > > (@pxref{Function Attributes}). > > > > Currently the x86 GNU/Linux target provides an implementation based > > -on Intel Control-flow Enforcement Technology (CET). > > +on Intel Control-flow Enforcement Technology (CET) which works for > > +i686 processor or newer. > > > > @item -fstack-protector > > @opindex fstack-protector > > -- > > 2.32.0 > >
On Thu, Oct 21, 2021 at 12:49 PM H.J. Lu via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > PR target/98667 > * doc/invoke.texi: Document -fcf-protection requires i686 or > new. > --- > gcc/doc/invoke.texi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index c66a25fcd69..71992b8c597 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation > (@pxref{Function Attributes}). > > Currently the x86 GNU/Linux target provides an implementation based > -on Intel Control-flow Enforcement Technology (CET). > +on Intel Control-flow Enforcement Technology (CET) which works for > +i686 processor or newer. I think "processor" should be pluralized to "processors"? Also, possibly a missing comma after "(CET)"? > > @item -fstack-protector > @opindex fstack-protector > -- > 2.32.0 >
On Fri, Oct 29, 2021 at 3:04 PM Eric Gallager <egall@gwmail.gwu.edu> wrote: > > On Thu, Oct 21, 2021 at 12:49 PM H.J. Lu via Gcc-patches > <gcc-patches@gcc.gnu.org> wrote: > > > > PR target/98667 > > * doc/invoke.texi: Document -fcf-protection requires i686 or > > new. > > --- > > gcc/doc/invoke.texi | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > > index c66a25fcd69..71992b8c597 100644 > > --- a/gcc/doc/invoke.texi > > +++ b/gcc/doc/invoke.texi > > @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation > > (@pxref{Function Attributes}). > > > > Currently the x86 GNU/Linux target provides an implementation based > > -on Intel Control-flow Enforcement Technology (CET). > > +on Intel Control-flow Enforcement Technology (CET) which works for > > +i686 processor or newer. > > I think "processor" should be pluralized to "processors"? Also, > possibly a missing comma after "(CET)"? > Can you submit a patch? Thanks.
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index c66a25fcd69..71992b8c597 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation (@pxref{Function Attributes}). Currently the x86 GNU/Linux target provides an implementation based -on Intel Control-flow Enforcement Technology (CET). +on Intel Control-flow Enforcement Technology (CET) which works for +i686 processor or newer. @item -fstack-protector @opindex fstack-protector