diff mbox series

[COMMITTED] Change threading comment before pass_ccp pass.

Message ID 20211019084823.444807-1-aldyh@redhat.com
State Committed
Commit d2161caffbb56a434776608af4e4491b59e508c8
Headers
Series [COMMITTED] Change threading comment before pass_ccp pass. |

Commit Message

Aldy Hernandez Oct. 19, 2021, 8:48 a.m. UTC 
  As suggested.  Thanks.

gcc/ChangeLog:

	* passes.def: Change threading comment before pass_ccp pass.
---
 gcc/passes.def | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Richard Biener Oct. 19, 2021, 10:55 a.m. UTC | #1 
On Tue, Oct 19, 2021 at 10:48 AM Aldy Hernandez <aldyh@redhat.com> wrote:
>
> As suggested.  Thanks.
>
> gcc/ChangeLog:
>
>         * passes.def: Change threading comment before pass_ccp pass.
> ---
>  gcc/passes.def | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/gcc/passes.def b/gcc/passes.def
> index c11c237f6d2..4c54176328b 100644
> --- a/gcc/passes.def
> +++ b/gcc/passes.def
> @@ -339,9 +339,7 @@ along with GCC; see the file COPYING3.  If not see
>        NEXT_PASS (pass_thread_jumps);
>        NEXT_PASS (pass_vrp, false /* warn_array_bounds_p */);
>        NEXT_PASS (pass_vrp_threader);
> -      /* Threading can leave many const/copy propagations in the IL.
> -        Clean them up.  Instead of just copy_prop, we use ccp to
> -        compute alignment and nonzero bits.  */

Well, the comment is still true as long as pass_vrp_threader is there ;)

> +      /* Run CCP to compute alignment and nonzero bits.  */
>        NEXT_PASS (pass_ccp, true /* nonzero_p */);
>        NEXT_PASS (pass_warn_restrict);
>        NEXT_PASS (pass_dse);
> --
> 2.31.1
>
Aldy Hernandez Oct. 19, 2021, 11:31 a.m. UTC | #2 
On 10/19/21 12:55 PM, Richard Biener wrote:
> On Tue, Oct 19, 2021 at 10:48 AM Aldy Hernandez <aldyh@redhat.com> wrote:
>>
>> As suggested.  Thanks.
>>
>> gcc/ChangeLog:
>>
>>          * passes.def: Change threading comment before pass_ccp pass.
>> ---
>>   gcc/passes.def | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/gcc/passes.def b/gcc/passes.def
>> index c11c237f6d2..4c54176328b 100644
>> --- a/gcc/passes.def
>> +++ b/gcc/passes.def
>> @@ -339,9 +339,7 @@ along with GCC; see the file COPYING3.  If not see
>>         NEXT_PASS (pass_thread_jumps);
>>         NEXT_PASS (pass_vrp, false /* warn_array_bounds_p */);
>>         NEXT_PASS (pass_vrp_threader);
>> -      /* Threading can leave many const/copy propagations in the IL.
>> -        Clean them up.  Instead of just copy_prop, we use ccp to
>> -        compute alignment and nonzero bits.  */
> 
> Well, the comment is still true as long as pass_vrp_threader is there ;)

Ha ha!  Oops.  You're right.

Tell you what, if we decide not to rearrange the pipeline, I'll put the 
comment back :).

Aldy
diff mbox series

Patch

diff --git a/gcc/passes.def b/gcc/passes.def
index c11c237f6d2..4c54176328b 100644
--- a/gcc/passes.def
+++ b/gcc/passes.def
@@ -339,9 +339,7 @@  along with GCC; see the file COPYING3.  If not see
       NEXT_PASS (pass_thread_jumps);
       NEXT_PASS (pass_vrp, false /* warn_array_bounds_p */);
       NEXT_PASS (pass_vrp_threader);
-      /* Threading can leave many const/copy propagations in the IL.
-	 Clean them up.  Instead of just copy_prop, we use ccp to
-	 compute alignment and nonzero bits.  */
+      /* Run CCP to compute alignment and nonzero bits.  */
       NEXT_PASS (pass_ccp, true /* nonzero_p */);
       NEXT_PASS (pass_warn_restrict);
       NEXT_PASS (pass_dse);