Message ID | 20211013153459.160132-1-contact@lsferreira.net |
---|---|
State | Superseded |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 262A63858006 for <patchwork@sourceware.org>; Wed, 13 Oct 2021 15:35:47 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from 4.mo550.mail-out.ovh.net (4.mo550.mail-out.ovh.net [46.105.76.26]) by sourceware.org (Postfix) with ESMTPS id 786EA3858C3A for <gcc-patches@gcc.gnu.org>; Wed, 13 Oct 2021 15:35:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 786EA3858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lsferreira.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lsferreira.net Received: from player770.ha.ovh.net (unknown [10.108.20.147]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 28569234F7 for <gcc-patches@gcc.gnu.org>; Wed, 13 Oct 2021 15:35:29 +0000 (UTC) Received: from lsferreira.net (252.131.62.94.rev.vodafone.pt [94.62.131.252]) (Authenticated sender: contact@lsferreira.net) by player770.ha.ovh.net (Postfix) with ESMTPSA id 631B1234A7C09; Wed, 13 Oct 2021 15:35:28 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-100R003311dc1f6-37a9-43e7-be0a-4f8f93d56e80, A8D098B9B29251AE790F9592EC533D14122901BA) smtp.auth=contact@lsferreira.net X-OVh-ClientIp: 94.62.131.252 From: =?utf-8?q?Lu=C3=ADs_Ferreira?= <contact@lsferreira.net> To: gcc-patches@gcc.gnu.org Subject: [PATCH] libiberty: d-demangle: use distinguishable tuple() Date: Wed, 13 Oct 2021 16:34:59 +0100 Message-Id: <20211013153459.160132-1-contact@lsferreira.net> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 18212838370753902840 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddgkeelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvffufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpefnuhovshcuhfgvrhhrvghirhgruceotghonhhtrggttheslhhsfhgvrhhrvghirhgrrdhnvghtqeenucggtffrrghtthgvrhhnpeelvddvtddtffdukeffffejtdfgkeegudelhfehveeuudejueegjeduueefgedukeenucfkpheptddrtddrtddrtddpleegrdeivddrudefuddrvdehvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejjedtrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghonhhtrggttheslhhsfhgvrhhrvghirhgrrdhnvghtpdhrtghpthhtohepghgttgdqphgrthgthhgvshesghgttgdrghhnuhdrohhrgh X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Cc: =?utf-8?q?Lu=C3=ADs_Ferreira?= <contact@lsferreira.net> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
libiberty: d-demangle: use distinguishable tuple()
|
|
Commit Message
Luís Ferreira
Oct. 13, 2021, 3:34 p.m. UTC
Since Tuple!() is templated type from standard library, this can make two
demangled names undistinguishable.
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
libiberty/ChangeLog:
* d-demangle.c (dlang_parse_tuple): use tuple() instead of Tuple!()
---
libiberty/d-demangle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, 2021-10-13 at 16:34 +0100, Luís Ferreira wrote: > Since Tuple!() is templated type from standard library, this can make > two > demangled names undistinguishable. > > Signed-off-by: Luís Ferreira <contact@lsferreira.net> > > libiberty/ChangeLog: > > * d-demangle.c (dlang_parse_tuple): use tuple() instead of > Tuple!() > --- > libiberty/d-demangle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libiberty/d-demangle.c b/libiberty/d-demangle.c > index 880f2ec85a4..5dbdc36adbe 100644 > --- a/libiberty/d-demangle.c > +++ b/libiberty/d-demangle.c > @@ -1711,7 +1711,7 @@ dlang_parse_tuple (string *decl, const char > *mangled, struct dlang_info *info) > if (mangled == NULL) > return NULL; > > - string_append (decl, "Tuple!("); > + string_append (decl, "tuple("); > > while (elements--) > { I need to update tests
On Wed, 2021-10-13 at 16:42 +0100, Luís Ferreira wrote: > On Wed, 2021-10-13 at 16:34 +0100, Luís Ferreira wrote: > > Since Tuple!() is templated type from standard library, this can > > make > > two > > demangled names undistinguishable. > > > > Signed-off-by: Luís Ferreira <contact@lsferreira.net> > > > > libiberty/ChangeLog: > > > > * d-demangle.c (dlang_parse_tuple): use tuple() instead of > > Tuple!() > > --- > > libiberty/d-demangle.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libiberty/d-demangle.c b/libiberty/d-demangle.c > > index 880f2ec85a4..5dbdc36adbe 100644 > > --- a/libiberty/d-demangle.c > > +++ b/libiberty/d-demangle.c > > @@ -1711,7 +1711,7 @@ dlang_parse_tuple (string *decl, const char > > *mangled, struct dlang_info *info) > > if (mangled == NULL) > > return NULL; > > > > - string_append (decl, "Tuple!("); > > + string_append (decl, "tuple("); > > > > while (elements--) > > { > > I need to update tests > Updated on PATCH v2.
diff --git a/libiberty/d-demangle.c b/libiberty/d-demangle.c index 880f2ec85a4..5dbdc36adbe 100644 --- a/libiberty/d-demangle.c +++ b/libiberty/d-demangle.c @@ -1711,7 +1711,7 @@ dlang_parse_tuple (string *decl, const char *mangled, struct dlang_info *info) if (mangled == NULL) return NULL; - string_append (decl, "Tuple!("); + string_append (decl, "tuple("); while (elements--) {