From patchwork Tue Oct 12 18:33:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 46144 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E0A0A385840B for ; Tue, 12 Oct 2021 18:34:24 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from brown.birch.relay.mailchannels.net (brown.birch.relay.mailchannels.net [23.83.209.23]) by sourceware.org (Postfix) with ESMTPS id 089233858D3C for ; Tue, 12 Oct 2021 18:34:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 089233858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1BDB4682005; Tue, 12 Oct 2021 18:34:05 +0000 (UTC) Received: from pdx1-sub0-mail-a82.g.dreamhost.com (100-96-133-192.trex.outbound.svc.cluster.local [100.96.133.192]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 903FE681F24; Tue, 12 Oct 2021 18:34:04 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a82.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.133.192 (trex/6.4.3); Tue, 12 Oct 2021 18:34:05 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Shelf-Robust: 4defa0d37b2ee585_1634063644906_3371523186 X-MC-Loop-Signature: 1634063644906:1765312997 X-MC-Ingress-Time: 1634063644906 Received: from pdx1-sub0-mail-a82.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a82.g.dreamhost.com (Postfix) with ESMTP id 9294989D78; Tue, 12 Oct 2021 11:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=gotplt.org; bh=tvU1S3qhf52Sp7HGuqk3PY1iv0o=; b=Fso43Rpxfr2D+r 3eF+ByRmZ5NIJAZQMjunm9SaAylvXgxFcI15Ht7g439+8e0q/CZRCXvv24sviYBX un/uLdHRIdhEdTX+d0JBgGpvep3yAx5/sxfan3oPjjAHJwLbxP5DOYHuQ6eMzeDM MGFtOkg5kgOmaTLP58YrfkqHVqIMQ= Received: from rhbox.redhat.com (unknown [1.186.121.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a82.g.dreamhost.com (Postfix) with ESMTPSA id 6456C89D72; Tue, 12 Oct 2021 11:33:59 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a82 From: Siddhesh Poyarekar To: gcc-patches@gcc.gnu.org Subject: [PATCH] Warray-bounds: Warn only for generic address spaces Date: Wed, 13 Oct 2021 00:03:47 +0530 Message-Id: <20211012183347.385794-1-siddhesh@gotplt.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3037.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: msebor@redhat.com Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" The warning is falsely triggered for THREAD_SELF in glibc when accessing TCB through the segment register. gcc/ChangeLog: * gimple-array-bounds.cc (array_bounds_checker::check_mem_ref): Bail out for non-generic address spaces. gcc/testsuite/ChangeLog: * gcc.target/i386/addr-space-3.c: New test case. Signed-off-by: Siddhesh Poyarekar --- gcc/gimple-array-bounds.cc | 3 +++ gcc/testsuite/gcc.target/i386/addr-space-3.c | 5 +++++ 2 files changed, 8 insertions(+) create mode 100644 gcc/testsuite/gcc.target/i386/addr-space-3.c diff --git a/gcc/gimple-array-bounds.cc b/gcc/gimple-array-bounds.cc index 0517e5ddd8e..36fc1dbe3f8 100644 --- a/gcc/gimple-array-bounds.cc +++ b/gcc/gimple-array-bounds.cc @@ -432,6 +432,9 @@ array_bounds_checker::check_mem_ref (location_t location, tree ref, if (aref.offset_in_range (axssize)) return false; + if (!ADDR_SPACE_GENERIC_P (TYPE_ADDR_SPACE (axstype))) + return false; + if (TREE_CODE (aref.ref) == SSA_NAME) { gimple *def = SSA_NAME_DEF_STMT (aref.ref); diff --git a/gcc/testsuite/gcc.target/i386/addr-space-3.c b/gcc/testsuite/gcc.target/i386/addr-space-3.c new file mode 100644 index 00000000000..4bd940e696a --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/addr-space-3.c @@ -0,0 +1,5 @@ +/* Verify that __seg_fs/gs marked variables do not trigger an array bounds + warning. */ +/* { dg-do compile */ +/* { dg-options "-O2 -Warray-bounds" } */ +#include "addr-space-2.c"