From patchwork Fri Dec 2 13:30:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vladimir Makarov X-Patchwork-Id: 61366 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 691A63858C2F for ; Fri, 2 Dec 2022 13:31:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 691A63858C2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1669987869; bh=/++Owib2s5Q1D71f2QDQTMG45APbkTojZQjiyQAcp20=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=VrZVcYY+Ai4zGDW5fg0jv255dGWhbBfFe1wcpXQ+Paj61QbuUZghFJV7G7HUKyJhT B0p2cRs7VkUS2HXTsab+Y+e4oEhXQN+Hq8Afg2HYlpgPKjIuoPzFIrhzs/aQGQnGvN INFiGJL7bI4DLGNdGxu4xTFoaMRvQoQDesO/qmkM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EC85E3858C50 for ; Fri, 2 Dec 2022 13:30:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC85E3858C50 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-199-RYfHWqZzNxui3hKJCgyb9g-1; Fri, 02 Dec 2022 08:30:38 -0500 X-MC-Unique: RYfHWqZzNxui3hKJCgyb9g-1 Received: by mail-qt1-f197.google.com with SMTP id ew11-20020a05622a514b00b003a524196d31so16820753qtb.2 for ; Fri, 02 Dec 2022 05:30:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lUAT7Gz6mSPtmSu/6Z5f9yrNLbk37S8DNOD0LCqkJGs=; b=pCgfc95+l2YR6K5vt6XjLG+iNGNWw/zCt+BfUvT6z6cp3wqic7Hy3ypybMCcpF10NK eY75xb2m2qwFc8Zg0mfoADFwYfPTjSuhLPCaoQt7tsyJ5hv6QuIJ1COI3Y0HVB+P4Hyv IhYxcjrbPnAH/afiWH4NuAoFvspjzEIr97AvW2IVwn5YpleG/uqzy4O7JLfsgj1GLFbz CyP4Wh1PwB8uk7ohOtuklQc9fLMdp9ca41e3zm/t510GrSUqZfIYIOBvRuAo07InmZ0o YD7WR6lgwUr1hI+YVmf1i4wTPvv7L9JYCk0cJnTDyfrMDoisWV5YfF7rit7xdF5RcZXi BQWQ== X-Gm-Message-State: ANoB5pkL0SBBt4b23dyLGJrNASb5cJdFcBijqjv9YHSA74oJLNin81/D NBAzglYLDayebebl/bXS5VkNq/Zb9pzIA2pgDlxSIwyNW9OpwYeLzG4U3QA4HWjUER8UY5TCxD+ N9tYhu7qGAyTwwHCl8hgg9VuzbTEaVfSgSwxGz8tZKpLlP7h786mCfBWsztua4cVA3Rm44A== X-Received: by 2002:a05:622a:6022:b0:398:5f25:649 with SMTP id he34-20020a05622a602200b003985f250649mr66637160qtb.673.1669987837915; Fri, 02 Dec 2022 05:30:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf7d/I+0azTkM5NombiWeMY6Ei12vVprbsBe/dwAMPIl3Qm/uZ+01NLupQcVsowiG4D4/9hhlw== X-Received: by 2002:a05:622a:6022:b0:398:5f25:649 with SMTP id he34-20020a05622a602200b003985f250649mr66637119qtb.673.1669987837521; Fri, 02 Dec 2022 05:30:37 -0800 (PST) Received: from [192.168.1.113] (23-233-12-120.cpe.pppoe.ca. [23.233.12.120]) by smtp.gmail.com with ESMTPSA id x10-20020a05620a448a00b006fa617ac616sm5449163qkp.49.2022.12.02.05.30.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 05:30:36 -0800 (PST) Message-ID: <1c654090-4263-a2f5-3651-312694a8f786@redhat.com> Date: Fri, 2 Dec 2022 08:30:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: "gcc-patches@gcc.gnu.org" Subject: [committed] [PR106462] LRA: Check hard reg availability of pseudo and its subreg for pseudo reload X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Vladimir Makarov via Gcc-patches From: Vladimir Makarov Reply-To: Vladimir Makarov Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" The following patch solves   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106462 The patch was successfully bootstrapped and tested on x86-64. commit 70596a0fb2a2ec072e1e97e37616e05041dfa4e5 Author: Vladimir N. Makarov Date: Fri Dec 2 08:18:04 2022 -0500 LRA: Check hard reg availability of pseudo and its subreg for pseudo reload Do not reload subreg pseudo if there are hard regs for subreg mode but there are no hard regs for pseudo mode. PR target/106462 gcc/ChangeLog: * lra-constraints.cc (curr_insn_transform): Check available hard regs for pseudo and its subreg to decide what to reload. gcc/testsuite/ChangeLog: * gcc.target/mips/pr106462.c: New test. diff --git a/gcc/lra-constraints.cc b/gcc/lra-constraints.cc index d92ab76908c..02b5ab4a316 100644 --- a/gcc/lra-constraints.cc +++ b/gcc/lra-constraints.cc @@ -4582,7 +4582,18 @@ curr_insn_transform (bool check_only_p) || (partial_subreg_p (mode, GET_MODE (reg)) && known_le (GET_MODE_SIZE (GET_MODE (reg)), UNITS_PER_WORD) - && WORD_REGISTER_OPERATIONS))) + && WORD_REGISTER_OPERATIONS)) + /* Avoid the situation when there are no available hard regs + for the pseudo mode but there are ones for the subreg + mode: */ + && !(goal_alt[i] != NO_REGS + && REGNO (reg) >= FIRST_PSEUDO_REGISTER + && (prohibited_class_reg_set_mode_p + (goal_alt[i], reg_class_contents[goal_alt[i]], + GET_MODE (reg))) + && !(prohibited_class_reg_set_mode_p + (goal_alt[i], reg_class_contents[goal_alt[i]], + mode)))) { /* An OP_INOUT is required when reloading a subreg of a mode wider than a word to ensure that data beyond the diff --git a/gcc/testsuite/gcc.target/mips/pr106462.c b/gcc/testsuite/gcc.target/mips/pr106462.c new file mode 100644 index 00000000000..c9105409524 --- /dev/null +++ b/gcc/testsuite/gcc.target/mips/pr106462.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-mabi=64 -msingle-float" } */ + +extern void bar (float x, short y); + +void foo (int argc) +{ + short c = argc * 2; + float a = (float)(short)c, b = 9.5; + + bar (b/a, c); +}