From patchwork Tue Jan 18 23:43:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 50203 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C4DD3857C74 for ; Tue, 18 Jan 2022 23:44:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C4DD3857C74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1642549444; bh=YCCKyW+GK3Zaf3FrUtXLAHbUIO9eQR0H6DIT4e+N6VA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=UF0HEDhZCeVgB3ntiUKjX1a9YWGJg3YYXBecPxc23saMoRojbZFC8Pm90WfTZ5JIT qzEh+FoHSM1Zp5NNDxG+dddOf3hunvKCp5JeKPcpyoLd9G3t9mJ1burkiF07mdUcYd sKmh8Eic8nq8Q/ROwblzlGAIalaamnUcBpP3rjlk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by sourceware.org (Postfix) with ESMTPS id 01B3F3858409 for ; Tue, 18 Jan 2022 23:43:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01B3F3858409 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20IIEUZs011641 for ; Tue, 18 Jan 2022 15:43:33 -0800 Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3dp2nd917s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 18 Jan 2022 15:43:33 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 Jan 2022 15:43:32 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 18 Jan 2022 15:43:32 -0800 Received: from linux.wrightpinski.org.com (unknown [10.69.242.198]) by maili.marvell.com (Postfix) with ESMTP id CBB253F704C; Tue, 18 Jan 2022 15:43:31 -0800 (PST) To: Subject: [PATCH] [COMMITTED] Improve coment for the newly added code in ipa-split. Date: Tue, 18 Jan 2022 15:43:27 -0800 Message-ID: <1642549407-17167-1-git-send-email-apinski@marvell.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Proofpoint-GUID: JfHR2u6L7AZHvrmqXPIiHr-MsTNlM1Zj X-Proofpoint-ORIG-GUID: JfHR2u6L7AZHvrmqXPIiHr-MsTNlM1Zj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-18_06,2022-01-18_01,2021-12-02_01 X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: apinski--- via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: apinski@marvell.com Cc: Andrew Pinski Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" From: Andrew Pinski It was pointed out to me by Jakub, that the comment in front of the new code which handles warning/error attribute was not really understandable. This fixes the comment to be understandable; I don't know why I wrote the original comment that way even. Committed as obvious after a quick build. gcc/ChangeLog: * ipa-split.cc (visit_bb): Fix comment before the warning/error attribute checking code. --- gcc/ipa-split.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/ipa-split.cc b/gcc/ipa-split.cc index 6ca45f3b745..ff11cf34b23 100644 --- a/gcc/ipa-split.cc +++ b/gcc/ipa-split.cc @@ -931,8 +931,8 @@ visit_bb (basic_block bb, basic_block return_bb, break; } - /* Calls that function has either the warning or error - attribute on it should not be split off into another + /* Calls to functions (which have the warning or error + attribute on them) should not be split off into another function. */ if (lookup_attribute ("warning", DECL_ATTRIBUTES (decl)) || lookup_attribute ("error", DECL_ATTRIBUTES (decl)))