From patchwork Sun Nov 28 17:56:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 48237 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20AE53858005 for ; Sun, 28 Nov 2021 17:57:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20AE53858005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1638122226; bh=RwCm5PFvpSjLN4IxhZqyF6OaSV4Zn99vbEMoYw0Y9VE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=tWgCRoZU4WitpKGmtF2cGsWfomThxk8b4Nvlfw2+2x7/vYhhcB+u7TH0LuVgIhGYo 8/BnIxXujy8InUqbf8aTMP2tgytukbVj/p7a15yy0Yi/y5ZAjIbJ72UEpa0WULTTEj Moo+pcPsggI/MJAILf3yG+vyJbKd3qy16q1cSaas= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by sourceware.org (Postfix) with ESMTPS id AC0DC3858C27 for ; Sun, 28 Nov 2021 17:56:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC0DC3858C27 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1ASB5bwk013860 for ; Sun, 28 Nov 2021 09:56:36 -0800 Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ckn2sb1sr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Sun, 28 Nov 2021 09:56:36 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 28 Nov 2021 09:56:34 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Sun, 28 Nov 2021 09:56:34 -0800 Received: from linux.wrightpinski.org.com (unknown [10.69.242.198]) by maili.marvell.com (Postfix) with ESMTP id D88353F70BD; Sun, 28 Nov 2021 09:56:33 -0800 (PST) To: Subject: [PATCH] tree-optimization: [PR101540] Simplify CONSTRUCTOR for vector(1) to be VCE Date: Sun, 28 Nov 2021 09:56:30 -0800 Message-ID: <1638122190-9379-1-git-send-email-apinski@marvell.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Proofpoint-GUID: Zo5zotJtM6cYx77Oa1w9_XvvQ6VccD6Q X-Proofpoint-ORIG-GUID: Zo5zotJtM6cYx77Oa1w9_XvvQ6VccD6Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-28_06,2021-11-28_01,2020-04-07_01 X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: apinski--- via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: apinski@marvell.com Cc: Andrew Pinski Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" From: Andrew Pinski This just adds a simplification to simplify_vector_constructor for vector of 1 element to be VCE which should reduce memory usage in the compiler and maybe allow for some more optimizations. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. PR tree-optimization/101540 gcc/ChangeLog: * tree-ssa-forwprop.c (simplify_vector_constructor): Simplify constructor of vector of 1 element to just be a VIEW_CONVERT_EXPR. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/pr101540-1.c: New test. --- gcc/testsuite/gcc.dg/tree-ssa/pr101540-1.c | 13 +++++++++++++ gcc/tree-ssa-forwprop.c | 13 +++++++++++++ 2 files changed, 26 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/pr101540-1.c diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr101540-1.c b/gcc/testsuite/gcc.dg/tree-ssa/pr101540-1.c new file mode 100644 index 00000000000..73fb342e029 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr101540-1.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-forwprop1" } */ +/* PR tree-optimization/101540 */ +typedef unsigned char __attribute__((__vector_size__ (1))) W; + +W foo (unsigned char uc) +{ + return (W){uc}; +} +/* The constructor in the above function should be converted into a VCE. */ +/* { dg-final { scan-tree-dump-times "VIEW_CONVERT_EXPR" 1 "forwprop1"} } */ +// {uc_1(D)} +/* { dg-final { scan-tree-dump-times "{uc_\[0-9\]+.D.}" 0 "forwprop1"} } */ diff --git a/gcc/tree-ssa-forwprop.c b/gcc/tree-ssa-forwprop.c index a830bab78ba..94b92d3d0af 100644 --- a/gcc/tree-ssa-forwprop.c +++ b/gcc/tree-ssa-forwprop.c @@ -2392,6 +2392,19 @@ simplify_vector_constructor (gimple_stmt_iterator *gsi) elem_type = TREE_TYPE (type); elem_size = TREE_INT_CST_LOW (TYPE_SIZE (elem_type)); + /* Special case V1 constructor with the same type to being a VCE. */ + if (nelts == 1 && CONSTRUCTOR_NELTS (op) == 1) + { + tree op1 = CONSTRUCTOR_ELT (op, 0)->value; + if (useless_type_conversion_p (elem_type, TREE_TYPE (op1))) + { + op1 = build1 (VIEW_CONVERT_EXPR, type, op1); + gimple_assign_set_rhs_from_tree (gsi, op1); + update_stmt (gsi_stmt (*gsi)); + return true; + } + } + orig[0] = NULL; orig[1] = NULL; conv_code = ERROR_MARK;