[(pushed)] fix -Winconsistent-missing-override clang warning

Message ID 12849e52-f444-3c91-1396-bd58bf656f38@suse.cz
State Committed
Commit cc95bca72f6e7f54c4adb6d332f881c277746366
Headers
Series [(pushed)] fix -Winconsistent-missing-override clang warning |

Commit Message

Martin Liška Aug. 31, 2022, 12:18 p.m. UTC
  Fixes:
gcc/value-range.h:357:16: warning: 'set_nonnegative' overrides
a member function but is not marked 'override' [-Winconsistent-missing-override]

gcc/ChangeLog:

	* value-range.h: Add override.
---
 gcc/value-range.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Aldy Hernandez Aug. 31, 2022, 12:20 p.m. UTC | #1
Thanks.

On Wed, Aug 31, 2022 at 2:18 PM Martin Liška <mliska@suse.cz> wrote:
>
> Fixes:
> gcc/value-range.h:357:16: warning: 'set_nonnegative' overrides
> a member function but is not marked 'override' [-Winconsistent-missing-override]
>
> gcc/ChangeLog:
>
>         * value-range.h: Add override.
> ---
>  gcc/value-range.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/value-range.h b/gcc/value-range.h
> index 07379d58f88..b25dd30d88a 100644
> --- a/gcc/value-range.h
> +++ b/gcc/value-range.h
> @@ -354,7 +354,7 @@ public:
>    virtual bool nonzero_p () const;
>    virtual void set_nonzero (tree type);
>    virtual void set_zero (tree type);
> -  virtual void set_nonnegative (tree type);
> +  virtual void set_nonnegative (tree type) override;
>    frange& operator= (const frange &);
>    bool operator== (const frange &) const;
>    bool operator!= (const frange &r) const { return !(*this == r); }
> --
> 2.37.2
>
  

Patch

diff --git a/gcc/value-range.h b/gcc/value-range.h
index 07379d58f88..b25dd30d88a 100644
--- a/gcc/value-range.h
+++ b/gcc/value-range.h
@@ -354,7 +354,7 @@  public:
   virtual bool nonzero_p () const;
   virtual void set_nonzero (tree type);
   virtual void set_zero (tree type);
-  virtual void set_nonnegative (tree type);
+  virtual void set_nonnegative (tree type) override;
   frange& operator= (const frange &);
   bool operator== (const frange &) const;
   bool operator!= (const frange &r) const { return !(*this == r); }