From patchwork Sat Jul 30 09:42:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Sayle X-Patchwork-Id: 56448 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 498A03856096 for ; Sat, 30 Jul 2022 09:42:32 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id 4062C3858C33 for ; Sat, 30 Jul 2022 09:42:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4062C3858C33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Type:MIME-Version:Message-ID: Date:Subject:In-Reply-To:References:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ejfILyN2+RAQvpdwNqI2BMtfpGnPhfu0CjPYZUZcbl8=; b=sT9fcnoox138bxQIhIwNkTAqJ3 mty47K5BFjUSQSxVJsyQueD06FWgpnbOo8+2tGlGreKYNaMGhI4QdvUQhGcBDzdsEraheyKhed/br njfjr0G4Y4qd89oOIJIDyBgTwWmW5j/u40UChV+VV494r4memED4eQOdW5ltn5BusdfryKpz4p2AQ qpJc9awfzCVjtbDD2cRYeJ/JnQ3Da4lIcxgHs8gwA/53C5M3qCkRXHiq3S6DBaT/6xIqrJtnFuwTC XHsYlPzYlgnNQGUOOYOKiGgISnbnMkcnRvxbEab/RTfB0rOmOjIOOf2x+xoF4lS4LUyLx4GwAyoP4 kaCjb23Q==; Received: from host86-169-41-119.range86-169.btcentralplus.com ([86.169.41.119]:58719 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oHiz8-0006wn-Ab; Sat, 30 Jul 2022 05:42:14 -0400 From: "Roger Sayle" To: "'GCC Patches'" References: <008b01d8a2a1$2ab6ff60$8024fe20$@nextmovesoftware.com> In-Reply-To: Subject: [x86_64 PATCH take #2] PR target/106450: Tweak timode_remove_non_convertible_regs. Date: Sat, 30 Jul 2022 10:42:12 +0100 Message-ID: <040c01d8a3f8$a6056d20$f2104760$@nextmovesoftware.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: Adij91VclepfdDzxQyqqg8R3urJQAg== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Many thanks to H.J. for pointing out a better idiom for traversing the USEs (and also DEFs) of TImode registers in an instruction. This revised patched has been tested on x86_64-pc-linux-gnu with make bootstrap and make -k check, both with and without --target_board=unix{-m32}, with no new failures. Ok for mainline? 2022-07-30 Roger Sayle H.J. Lu gcc/ChangeLog PR target/106450 * config/i386/i386-features.cc (timode_check_non_convertible_regs): Do nothing if REGNO is set in the REGS bitmap, or is a hard reg. (timode_remove_non_convertible_regs): Update comment. Call timode_check_non_convertible_reg on all TImode register DEFs and USEs in each instruction. gcc/testsuite/ChangeLog PR target/106450 * gcc.target/i386/pr106450.c: New test case. Thanks (H.J. and Uros), Roger --- > -----Original Message----- > From: H.J. Lu > Sent: 28 July 2022 17:55 > To: Roger Sayle > Cc: GCC Patches > Subject: Re: [x86_64 PATCH] PR target/106450: Tweak > timode_remove_non_convertible_regs. > > On Thu, Jul 28, 2022 at 9:43 AM Roger Sayle > wrote: > > > > This patch resolves PR target/106450, some more fall-out from more > > aggressive TImode scalar-to-vector (STV) optimizations. I continue to > > be caught out by how far TImode STV has diverged from DImode/SImode > > STV, and therefore requires additional (unexpected) tweaking. Many > > thanks to H.J. Lu for pointing out timode_remove_non_convertible_regs > > needs to be extended to handle XOR (and other new operations). > > > > Unhelpfully the comment above this function states that it's the > > TImode version of "remove_non_convertible_regs", which doesn't exist > > anymore, so I've resurrected an explanatory comment from the git history. > > By refactoring the checks for hard regs and already "marked" regs into > > timode_check_non_convertible_regs itself, all its callers are > > simplified. This patch then uses GET_RTX_CLASS to generically handle > > unary and binary operations, calling timode_check_non_convertible_regs > > on each TImode register operand in the single_set's SET_SRC. > > > > This patch has been tested on x86_64-pc-linux-gnu with make bootstrap > > and make -k check, both with and without --target_board=unix{-m32}, > > with no new failures. Ok for mainline? > > > > > > 2022-07-28 Roger Sayle > > > > gcc/ChangeLog > > PR target/106450 > > * config/i386/i386-features.cc (timode_check_non_convertible_regs): > > Do nothing if REGNO is set in the REGS bitmap, or is a hard reg. > > (timode_remove_non_convertible_regs): Update comment. > > Call timode_check_non_convertible_regs on all register operands > > of supported (binary and unary) operations. > > Should we use > > df_ref ref; > FOR_EACH_INSN_USE (ref, insn) > if (!DF_REF_REG_MEM_P (ref)) > timode_check_non_convertible_regs (candidates, regs, > DF_REF_REGNO (ref)); > > to check each use? > > > gcc/testsuite/ChangeLog > > PR target/106450 > > * gcc.target/i386/pr106450.c: New test case. > > > > > > Thanks in advance, > > Roger > > -- > -- > H.J. diff --git a/gcc/config/i386/i386-features.cc b/gcc/config/i386/i386-features.cc index aa5de71..e4cc4a3 100644 --- a/gcc/config/i386/i386-features.cc +++ b/gcc/config/i386/i386-features.cc @@ -1808,6 +1808,11 @@ static void timode_check_non_convertible_regs (bitmap candidates, bitmap regs, unsigned int regno) { + /* Do nothing if REGNO is already in REGS or is a hard reg. */ + if (bitmap_bit_p (regs, regno) + || HARD_REGISTER_NUM_P (regno)) + return; + for (df_ref def = DF_REG_DEF_CHAIN (regno); def; def = DF_REF_NEXT_REG (def)) @@ -1843,7 +1848,13 @@ timode_check_non_convertible_regs (bitmap candidates, bitmap regs, } } -/* The TImode version of remove_non_convertible_regs. */ +/* For a given bitmap of insn UIDs scans all instructions and + remove insn from CANDIDATES in case it has both convertible + and not convertible definitions. + + All insns in a bitmap are conversion candidates according to + scalar_to_vector_candidate_p. Currently it implies all insns + are single_set. */ static void timode_remove_non_convertible_regs (bitmap candidates) @@ -1857,25 +1868,20 @@ timode_remove_non_convertible_regs (bitmap candidates) changed = false; EXECUTE_IF_SET_IN_BITMAP (candidates, 0, id, bi) { - rtx def_set = single_set (DF_INSN_UID_GET (id)->insn); - rtx dest = SET_DEST (def_set); - rtx src = SET_SRC (def_set); - - if ((!REG_P (dest) - || bitmap_bit_p (regs, REGNO (dest)) - || HARD_REGISTER_P (dest)) - && (!REG_P (src) - || bitmap_bit_p (regs, REGNO (src)) - || HARD_REGISTER_P (src))) - continue; - - if (REG_P (dest)) - timode_check_non_convertible_regs (candidates, regs, - REGNO (dest)); - - if (REG_P (src)) - timode_check_non_convertible_regs (candidates, regs, - REGNO (src)); + rtx_insn *insn = DF_INSN_UID_GET (id)->insn; + df_ref ref; + + FOR_EACH_INSN_DEF (ref, insn) + if (!DF_REF_REG_MEM_P (ref) + && GET_MODE (DF_REF_REG (ref)) == TImode) + timode_check_non_convertible_regs (candidates, regs, + DF_REF_REGNO (ref)); + + FOR_EACH_INSN_USE (ref, insn) + if (!DF_REF_REG_MEM_P (ref) + && GET_MODE (DF_REF_REG (ref)) == TImode) + timode_check_non_convertible_regs (candidates, regs, + DF_REF_REGNO (ref)); } EXECUTE_IF_SET_IN_BITMAP (regs, 0, id, bi) diff --git a/gcc/testsuite/gcc.target/i386/pr106450.c b/gcc/testsuite/gcc.target/i386/pr106450.c new file mode 100644 index 0000000..d16231f --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr106450.c @@ -0,0 +1,14 @@ +/* { dg-do compile { target int128 } } */ +/* { dg-options "-O2 -fsplit-paths" } */ + +__int128 n; + +__attribute__ ((simd)) void +foo (void) +{ + __int128 uninitialized; + unsigned __int128 *p = &n; + + n >>= *p ? : 2; + n |= uninitialized; +}