Message ID | 026401db92bb$345050a0$9cf0f1e0$@symas.com |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9AE7D3857BB9 for <patchwork@sourceware.org>; Tue, 11 Mar 2025 19:25:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9AE7D3857BB9 X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from zmcc-3-mx.zmailcloud.com (zmcc-3-mx.zmailcloud.com [34.200.143.36]) by sourceware.org (Postfix) with ESMTPS id 0157C3857C78 for <gcc-patches@gcc.gnu.org>; Tue, 11 Mar 2025 19:24:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0157C3857C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=symas.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=symas.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0157C3857C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=34.200.143.36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741721067; cv=none; b=v+OquRCEWkcqg0Xr74FAuYYr24bKvhCmCneQIBt/ELOjQ1BoxdOglPzkBGUqkyYIBpy5dq+KNn46pDx6vQ5W+LpTh8zuI0K5fNizmaDY5zBAlowa0Wq/TmFE9thze0xma96yGidKx6ipzhp86wk1s7Qf4vHkso8VMINuJY303KQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741721067; c=relaxed/simple; bh=Ql9wI+QQ+ujiES2zO/Av/ZYY48Aw+Tv/p+YbwbWkJgI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=C3ff8787SwwwsL2Tk4jDr0kINJPTfcujd96REyl8S0W5y8Z/9bVTryrYO4u6UYp98BxrGjNG6nVvVCfV2jAe9qBFHy+d7xqebwGmxLY2LiYXhTkKxVR9nUcAavZmSANoqNjDHbLT6w5347IPv56pw6mD6dUiDQMT4XOzywpP8Qc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0157C3857C78 Received: from zmcc-3.zmailcloud.com (ec2-3-15-255-223.us-east-2.compute.amazonaws.com [3.15.255.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by zmcc-3-mx.zmailcloud.com (Postfix) with ESMTPS id B0FD1D800BD1 for <gcc-patches@gcc.gnu.org>; Tue, 11 Mar 2025 14:24:26 -0500 (CDT) Received: from zmcc-3.zmailcloud.com (localhost [127.0.0.1]) by zmcc-3-mta-1.zmailcloud.com (Postfix) with ESMTPS id 909A3A00E313 for <gcc-patches@gcc.gnu.org>; Tue, 11 Mar 2025 14:24:26 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by zmcc-3-mta-1.zmailcloud.com (Postfix) with ESMTP id 8248FA00ECC7 for <gcc-patches@gcc.gnu.org>; Tue, 11 Mar 2025 14:24:26 -0500 (CDT) Received: from zmcc-3.zmailcloud.com ([127.0.0.1]) by localhost (zmcc-3-mta-1.zmailcloud.com [127.0.0.1]) (amavis, port 10026) with ESMTP id 5TYPSy_88DnB for <gcc-patches@gcc.gnu.org>; Tue, 11 Mar 2025 14:24:26 -0500 (CDT) Received: from zmcc-3-mailbox-1.zmailcloud.com (zmcc-3-mailbox-1.zmailcloud.com [172.31.18.168]) by zmcc-3-mta-1.zmailcloud.com (Postfix) with ESMTP id 6E78EA00ECC3 for <gcc-patches@gcc.gnu.org>; Tue, 11 Mar 2025 14:24:26 -0500 (CDT) From: Robert Dubner <rdubner@symas.com> To: <gcc-patches@gcc.gnu.org> References: <Z8/s2TdDV8aV3TF7@tucnak> In-Reply-To: <Z8/s2TdDV8aV3TF7@tucnak> Subject: [PATCH] Add Robert Dubner to Maintainers Thread-Topic: [PATCH] Add Robert Dubner to Maintainers Date: Tue, 11 Mar 2025 14:24:26 -0500 (CDT) Message-ID: <026401db92bb$345050a0$9cf0f1e0$@symas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" X-Mailer: Microsoft Outlook 16.0 X-Mailer: Zimbra 9.0.0_GA_4718 (Zimbra-ZCO/9.0.0.1942 (10.0.26100 en-US) P524 T4c10 R1351) Content-Language: en-us Thread-Index: AduSuxoz/zsASMDRQGqoVUtXT1oRGg== Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
Series |
Add Robert Dubner to Maintainers
|
|
Commit Message
Robert Dubner
March 11, 2025, 7:24 p.m. UTC
As described in https://gcc.gnu.org/gitwrite.html, this is my inaugural, no-prior-approval-required, is-it-working? --yes-it-is-I-just-did-it patch to MAINTAINERS c++ Nathan Sidwell <nathan@acm.org> D front end Iain Buclaw <ibuclaw@gdcproject.org> @@ -276,6 +277,7 @@ check in changes outside of the parts of the compiler they maintain. arm port (MVE) Christophe Lyon <christophe.lyon@arm.com> callgraph Martin Jambor <mjambor@suse.cz> C front end Marek Polacek <polacek@redhat.com> +COBOL front end Robert Dubner <rdubner@symas.com> CTF, BTF Indu Bhagat <indu.bhagat@oracle.com> CTF, BTF, bpf port David Faust <david.faust@oracle.com> dataflow Paolo Bonzini <bonzini@gnu.org> @@ -445,6 +447,7 @@ Dimitar Dimitrov dimitar <dimitar@dinux.eu> Benoit Dupont de Dinechin bd3 <benoit.dupont-de-dinechin@st.com> Lehua Ding - <lehua.ding@rivai.ai> Ulrich Drepper drepper <drepper@gmail.com> +Robert Dubner rdubner <rdubner@symas.com> François Dumont fdumont <fdumont@gcc.gnu.org> Zdenek Dvorak rakdver <ook@ucw.cz> Michael Eager eager <eager@eagercon.com>
Comments
On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote: > As described in https://gcc.gnu.org/gitwrite.html, this is my inaugural, > no-prior-approval-required, is-it-working? --yes-it-is-I-just-did-it patch > to MAINTAINERS > > diff --git a/MAINTAINERS b/MAINTAINERS > index 84c0a6b892b..34e2f9f53b7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -162,6 +162,7 @@ Ada front end Arnaud Charlet > <charlet@adacore.com> > Ada front end Eric Botcazou > <ebotcazou@libertysurf.fr> > Ada front end Marc Poulhiès <poulhies@adacore.com> > Ada front end Pierre-Marie de Rodat <derodat@adacore.com> > +COBOL front end Robert Dubner <rdubner@symas.com> > c++ Jason Merrill <jason@redhat.com> > c++ Nathan Sidwell <nathan@acm.org> > D front end Iain Buclaw <ibuclaw@gdcproject.org> You can't be a maintainer (the first hunk) and reviewer (second hunk) at the same time. The difference between maintainer and reviewer is that maintainer can commit his own patches to the maintained subsystem without review (doesn't mean he can't ask for review). So, if the steering committee appointed you as maintainer, you should be just in the first hunk, if as a reviewer, second hunk. The third hunk is ok if you want all your commits go under DCO. > @@ -276,6 +277,7 @@ check in changes outside of the parts of the compiler > they maintain. > arm port (MVE) Christophe Lyon <christophe.lyon@arm.com> > callgraph Martin Jambor <mjambor@suse.cz> > C front end Marek Polacek <polacek@redhat.com> > +COBOL front end Robert Dubner <rdubner@symas.com> > CTF, BTF Indu Bhagat <indu.bhagat@oracle.com> > CTF, BTF, bpf port David Faust <david.faust@oracle.com> > dataflow Paolo Bonzini <bonzini@gnu.org> > @@ -445,6 +447,7 @@ Dimitar Dimitrov dimitar > <dimitar@dinux.eu> > Benoit Dupont de Dinechin bd3 > <benoit.dupont-de-dinechin@st.com> > Lehua Ding - <lehua.ding@rivai.ai> > Ulrich Drepper drepper <drepper@gmail.com> > +Robert Dubner rdubner <rdubner@symas.com> > François Dumont fdumont <fdumont@gcc.gnu.org> > Zdenek Dvorak rakdver <ook@ucw.cz> > Michael Eager eager <eager@eagercon.com> Jakub
> -----Original Message----- > From: Jakub Jelinek <jakub@redhat.com> > Sent: Tuesday, March 11, 2025 17:40 > To: Robert Dubner <rdubner@symas.com> > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Add Robert Dubner to Maintainers > > On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote: > > As described in https://gcc.gnu.org/gitwrite.html, this is my > > inaugural, no-prior-approval-required, is-it-working? > > --yes-it-is-I-just-did-it patch to MAINTAINERS > > > > diff --git a/MAINTAINERS b/MAINTAINERS index 84c0a6b892b..34e2f9f53b7 > > 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -162,6 +162,7 @@ Ada front end Arnaud Charlet > > <charlet@adacore.com> > > Ada front end Eric Botcazou > > <ebotcazou@libertysurf.fr> > > Ada front end Marc Poulhiès <poulhies@adacore.com> > > Ada front end Pierre-Marie de Rodat <derodat@adacore.com> > > +COBOL front end Robert Dubner <rdubner@symas.com> > > c++ Jason Merrill <jason@redhat.com> > > c++ Nathan Sidwell <nathan@acm.org> > > D front end Iain Buclaw > <ibuclaw@gdcproject.org> > > You can't be a maintainer (the first hunk) and reviewer (second hunk) at > the same time. The difference between maintainer and reviewer is that > maintainer can commit his own patches to the maintained subsystem without > review (doesn't mean he can't ask for review). > So, if the steering committee appointed you as maintainer, you should be > just in the first hunk, if as a reviewer, second hunk. > The third hunk is ok if you want all your commits go under DCO. My batting average remains at a thousand -- I never get things right on the first try. I don't know how the Steering Committee has designated me. I will say that it had best be as Front End Maintainer, because if Jim and I don't do it, the project is going to be, I suspect, very hard pressed to find somebody else to do it. This does beg another question: If somebody wants to submit a patch that affects the code in the COBOL front end, and if I am not in the role of reviewing those changes, well, who is supposed to do the review? Or is that understood to fall under the aegis of Front End Maintainer? The FSF has a copyright assignment for me on file. In any event, I will edit myself out of everything except Front End Maintainer. Thank you, Bob D. > > > @@ -276,6 +277,7 @@ check in changes outside of the parts of the > > compiler they maintain. > > arm port (MVE) Christophe Lyon > <christophe.lyon@arm.com> > > callgraph Martin Jambor <mjambor@suse.cz> > > C front end Marek Polacek <polacek@redhat.com> > > +COBOL front end Robert Dubner <rdubner@symas.com> > > CTF, BTF Indu Bhagat > <indu.bhagat@oracle.com> > > CTF, BTF, bpf port David Faust > <david.faust@oracle.com> > > dataflow Paolo Bonzini <bonzini@gnu.org> > > @@ -445,6 +447,7 @@ Dimitar Dimitrov dimitar > > <dimitar@dinux.eu> > > Benoit Dupont de Dinechin bd3 > > <benoit.dupont-de-dinechin@st.com> > > Lehua Ding - <lehua.ding@rivai.ai> > > Ulrich Drepper drepper <drepper@gmail.com> > > +Robert Dubner rdubner <rdubner@symas.com> > > François Dumont fdumont <fdumont@gcc.gnu.org> > > Zdenek Dvorak rakdver <ook@ucw.cz> > > Michael Eager eager <eager@eagercon.com> > > Jakub
Robert Dubner <rdubner@symas.com> writes: >> -----Original Message----- >> From: Jakub Jelinek <jakub@redhat.com> >> Sent: Tuesday, March 11, 2025 17:40 >> To: Robert Dubner <rdubner@symas.com> >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH] Add Robert Dubner to Maintainers >> >> On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote: >> > As described in https://gcc.gnu.org/gitwrite.html, this is my >> > inaugural, no-prior-approval-required, is-it-working? >> > --yes-it-is-I-just-did-it patch to MAINTAINERS >> > >> > diff --git a/MAINTAINERS b/MAINTAINERS index 84c0a6b892b..34e2f9f53b7 >> > 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -162,6 +162,7 @@ Ada front end Arnaud Charlet >> > <charlet@adacore.com> >> > Ada front end Eric Botcazou >> > <ebotcazou@libertysurf.fr> >> > Ada front end Marc Poulhiès > <poulhies@adacore.com> >> > Ada front end Pierre-Marie de Rodat <derodat@adacore.com> >> > +COBOL front end Robert Dubner <rdubner@symas.com> >> > c++ Jason Merrill <jason@redhat.com> >> > c++ Nathan Sidwell <nathan@acm.org> >> > D front end Iain Buclaw >> <ibuclaw@gdcproject.org> >> >> You can't be a maintainer (the first hunk) and reviewer (second hunk) at >> the same time. The difference between maintainer and reviewer is that >> maintainer can commit his own patches to the maintained subsystem > without >> review (doesn't mean he can't ask for review). >> So, if the steering committee appointed you as maintainer, you should be >> just in the first hunk, if as a reviewer, second hunk. >> The third hunk is ok if you want all your commits go under DCO. > > My batting average remains at a thousand -- I never get things right on > the first try. > > I don't know how the Steering Committee has designated me. I will say > that it had best be as Front End Maintainer, because if Jim and I don't do > it, the project is going to be, I suspect, very hard pressed to find > somebody else to do it. Think the question is more if they appointed you both as maintainers or what (I'm sure they have, though). > > This does beg another question: If somebody wants to submit a patch that > affects the code in the COBOL front end, and if I am not in the role of > reviewing those changes, well, who is supposed to do the review? Or is > that understood to fall under the aegis of Front End Maintainer? > Maintainers have the powers of reviewers and then some (like appointing new reviewers, or at least recommending them). > The FSF has a copyright assignment for me on file. > > In any event, I will edit myself out of everything except Front End > Maintainer. > That sounds good and correct if you've got an FSF copyright assignment on file (hence not using DCO). > Thank you, > > Bob D. > >> [...] sam
diff --git a/MAINTAINERS b/MAINTAINERS index 84c0a6b892b..34e2f9f53b7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -162,6 +162,7 @@ Ada front end Arnaud Charlet <charlet@adacore.com> Ada front end Eric Botcazou <ebotcazou@libertysurf.fr> Ada front end Marc Poulhiès <poulhies@adacore.com> Ada front end Pierre-Marie de Rodat <derodat@adacore.com> +COBOL front end Robert Dubner <rdubner@symas.com> c++ Jason Merrill <jason@redhat.com>