Add Robert Dubner to Maintainers

Message ID 026401db92bb$345050a0$9cf0f1e0$@symas.com
State New
Headers
Series Add Robert Dubner to Maintainers |

Commit Message

Robert Dubner March 11, 2025, 7:24 p.m. UTC
  As described in https://gcc.gnu.org/gitwrite.html, this is my inaugural,
no-prior-approval-required, is-it-working? --yes-it-is-I-just-did-it patch
to MAINTAINERS

 c++                     Nathan Sidwell          <nathan@acm.org>
 D front end             Iain Buclaw             <ibuclaw@gdcproject.org>
@@ -276,6 +277,7 @@ check in changes outside of the parts of the compiler
they maintain.
 arm port (MVE)          Christophe Lyon         <christophe.lyon@arm.com>
 callgraph               Martin Jambor           <mjambor@suse.cz>
 C front end             Marek Polacek           <polacek@redhat.com>
+COBOL front end         Robert Dubner           <rdubner@symas.com>
 CTF, BTF                Indu Bhagat             <indu.bhagat@oracle.com>
 CTF, BTF, bpf port      David Faust             <david.faust@oracle.com>
 dataflow                Paolo Bonzini           <bonzini@gnu.org>
@@ -445,6 +447,7 @@ Dimitar Dimitrov                dimitar
<dimitar@dinux.eu>
 Benoit Dupont de Dinechin       bd3
<benoit.dupont-de-dinechin@st.com>
 Lehua Ding                      -               <lehua.ding@rivai.ai>
 Ulrich Drepper                  drepper         <drepper@gmail.com>
+Robert Dubner                   rdubner         <rdubner@symas.com>
 François Dumont                 fdumont         <fdumont@gcc.gnu.org>
 Zdenek Dvorak                   rakdver         <ook@ucw.cz>
 Michael Eager                   eager           <eager@eagercon.com>
  

Comments

Jakub Jelinek March 11, 2025, 9:40 p.m. UTC | #1
On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote:
> As described in https://gcc.gnu.org/gitwrite.html, this is my inaugural,
> no-prior-approval-required, is-it-working? --yes-it-is-I-just-did-it patch
> to MAINTAINERS
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 84c0a6b892b..34e2f9f53b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -162,6 +162,7 @@ Ada front end           Arnaud Charlet
> <charlet@adacore.com>
>  Ada front end           Eric Botcazou
> <ebotcazou@libertysurf.fr>
>  Ada front end           Marc Poulhiès           <poulhies@adacore.com>
>  Ada front end           Pierre-Marie de Rodat   <derodat@adacore.com>
> +COBOL front end         Robert Dubner           <rdubner@symas.com>
>  c++                     Jason Merrill           <jason@redhat.com>
>  c++                     Nathan Sidwell          <nathan@acm.org>
>  D front end             Iain Buclaw             <ibuclaw@gdcproject.org>

You can't be a maintainer (the first hunk) and reviewer (second hunk) at the
same time.  The difference between maintainer and reviewer is that
maintainer can commit his own patches to the maintained subsystem without
review (doesn't mean he can't ask for review).
So, if the steering committee appointed you as maintainer, you should be
just in the first hunk, if as a reviewer, second hunk.
The third hunk is ok if you want all your commits go under DCO.

> @@ -276,6 +277,7 @@ check in changes outside of the parts of the compiler
> they maintain.
>  arm port (MVE)          Christophe Lyon         <christophe.lyon@arm.com>
>  callgraph               Martin Jambor           <mjambor@suse.cz>
>  C front end             Marek Polacek           <polacek@redhat.com>
> +COBOL front end         Robert Dubner           <rdubner@symas.com>
>  CTF, BTF                Indu Bhagat             <indu.bhagat@oracle.com>
>  CTF, BTF, bpf port      David Faust             <david.faust@oracle.com>
>  dataflow                Paolo Bonzini           <bonzini@gnu.org>
> @@ -445,6 +447,7 @@ Dimitar Dimitrov                dimitar
> <dimitar@dinux.eu>
>  Benoit Dupont de Dinechin       bd3
> <benoit.dupont-de-dinechin@st.com>
>  Lehua Ding                      -               <lehua.ding@rivai.ai>
>  Ulrich Drepper                  drepper         <drepper@gmail.com>
> +Robert Dubner                   rdubner         <rdubner@symas.com>
>  François Dumont                 fdumont         <fdumont@gcc.gnu.org>
>  Zdenek Dvorak                   rakdver         <ook@ucw.cz>
>  Michael Eager                   eager           <eager@eagercon.com>

	Jakub
  
Robert Dubner March 12, 2025, 2:55 a.m. UTC | #2
> -----Original Message-----
> From: Jakub Jelinek <jakub@redhat.com>
> Sent: Tuesday, March 11, 2025 17:40
> To: Robert Dubner <rdubner@symas.com>
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] Add Robert Dubner to Maintainers
>
> On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote:
> > As described in https://gcc.gnu.org/gitwrite.html, this is my
> > inaugural, no-prior-approval-required, is-it-working?
> > --yes-it-is-I-just-did-it patch to MAINTAINERS
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS index 84c0a6b892b..34e2f9f53b7
> > 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -162,6 +162,7 @@ Ada front end           Arnaud Charlet
> > <charlet@adacore.com>
> >  Ada front end           Eric Botcazou
> > <ebotcazou@libertysurf.fr>
> >  Ada front end           Marc Poulhiès
<poulhies@adacore.com>
> >  Ada front end           Pierre-Marie de Rodat   <derodat@adacore.com>
> > +COBOL front end         Robert Dubner           <rdubner@symas.com>
> >  c++                     Jason Merrill           <jason@redhat.com>
> >  c++                     Nathan Sidwell          <nathan@acm.org>
> >  D front end             Iain Buclaw
> <ibuclaw@gdcproject.org>
>
> You can't be a maintainer (the first hunk) and reviewer (second hunk) at
> the same time.  The difference between maintainer and reviewer is that
> maintainer can commit his own patches to the maintained subsystem
without
> review (doesn't mean he can't ask for review).
> So, if the steering committee appointed you as maintainer, you should be
> just in the first hunk, if as a reviewer, second hunk.
> The third hunk is ok if you want all your commits go under DCO.

My batting average remains at a thousand -- I never get things right on
the first try.

I don't know how the Steering Committee has designated me.  I will say
that it had best be as Front End Maintainer, because if Jim and I don't do
it, the project is going to be, I suspect, very hard pressed to find
somebody else to do it.

This does beg another question:  If somebody wants to submit a patch that
affects the code in the COBOL front end, and if I am not in the role of
reviewing those changes, well, who is supposed to do the review?  Or is
that understood to fall under the aegis of Front End Maintainer?

The FSF has a copyright assignment for me on file.

In any event, I will edit myself out of everything except Front End
Maintainer.

Thank you,

Bob D.

>
> > @@ -276,6 +277,7 @@ check in changes outside of the parts of the
> > compiler they maintain.
> >  arm port (MVE)          Christophe Lyon
> <christophe.lyon@arm.com>
> >  callgraph               Martin Jambor           <mjambor@suse.cz>
> >  C front end             Marek Polacek           <polacek@redhat.com>
> > +COBOL front end         Robert Dubner           <rdubner@symas.com>
> >  CTF, BTF                Indu Bhagat
> <indu.bhagat@oracle.com>
> >  CTF, BTF, bpf port      David Faust
> <david.faust@oracle.com>
> >  dataflow                Paolo Bonzini           <bonzini@gnu.org>
> > @@ -445,6 +447,7 @@ Dimitar Dimitrov                dimitar
> > <dimitar@dinux.eu>
> >  Benoit Dupont de Dinechin       bd3
> > <benoit.dupont-de-dinechin@st.com>
> >  Lehua Ding                      -               <lehua.ding@rivai.ai>
> >  Ulrich Drepper                  drepper         <drepper@gmail.com>
> > +Robert Dubner                   rdubner         <rdubner@symas.com>
> >  François Dumont                 fdumont         <fdumont@gcc.gnu.org>
> >  Zdenek Dvorak                   rakdver         <ook@ucw.cz>
> >  Michael Eager                   eager           <eager@eagercon.com>
>
> 	Jakub
  
Sam James March 12, 2025, 4:18 a.m. UTC | #3
Robert Dubner <rdubner@symas.com> writes:

>> -----Original Message-----
>> From: Jakub Jelinek <jakub@redhat.com>
>> Sent: Tuesday, March 11, 2025 17:40
>> To: Robert Dubner <rdubner@symas.com>
>> Cc: gcc-patches@gcc.gnu.org
>> Subject: Re: [PATCH] Add Robert Dubner to Maintainers
>>
>> On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote:
>> > As described in https://gcc.gnu.org/gitwrite.html, this is my
>> > inaugural, no-prior-approval-required, is-it-working?
>> > --yes-it-is-I-just-did-it patch to MAINTAINERS
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS index 84c0a6b892b..34e2f9f53b7
>> > 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -162,6 +162,7 @@ Ada front end           Arnaud Charlet
>> > <charlet@adacore.com>
>> >  Ada front end           Eric Botcazou
>> > <ebotcazou@libertysurf.fr>
>> >  Ada front end           Marc Poulhiès
> <poulhies@adacore.com>
>> >  Ada front end           Pierre-Marie de Rodat   <derodat@adacore.com>
>> > +COBOL front end         Robert Dubner           <rdubner@symas.com>
>> >  c++                     Jason Merrill           <jason@redhat.com>
>> >  c++                     Nathan Sidwell          <nathan@acm.org>
>> >  D front end             Iain Buclaw
>> <ibuclaw@gdcproject.org>
>>
>> You can't be a maintainer (the first hunk) and reviewer (second hunk) at
>> the same time.  The difference between maintainer and reviewer is that
>> maintainer can commit his own patches to the maintained subsystem
> without
>> review (doesn't mean he can't ask for review).
>> So, if the steering committee appointed you as maintainer, you should be
>> just in the first hunk, if as a reviewer, second hunk.
>> The third hunk is ok if you want all your commits go under DCO.
>
> My batting average remains at a thousand -- I never get things right on
> the first try.
>
> I don't know how the Steering Committee has designated me.  I will say
> that it had best be as Front End Maintainer, because if Jim and I don't do
> it, the project is going to be, I suspect, very hard pressed to find
> somebody else to do it.

Think the question is more if they appointed you both as maintainers or
what (I'm sure they have, though).

>
> This does beg another question:  If somebody wants to submit a patch that
> affects the code in the COBOL front end, and if I am not in the role of
> reviewing those changes, well, who is supposed to do the review?  Or is
> that understood to fall under the aegis of Front End Maintainer?
>

Maintainers have the powers of reviewers and then some (like appointing
new reviewers, or at least recommending them). 

> The FSF has a copyright assignment for me on file.
>
> In any event, I will edit myself out of everything except Front End
> Maintainer.
>

That sounds good and correct if you've got an FSF copyright assignment
on file (hence not using DCO).

> Thank you,
>
> Bob D.
>
>> [...]

sam
  

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 84c0a6b892b..34e2f9f53b7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -162,6 +162,7 @@  Ada front end           Arnaud Charlet
<charlet@adacore.com>
 Ada front end           Eric Botcazou
<ebotcazou@libertysurf.fr>
 Ada front end           Marc Poulhiès           <poulhies@adacore.com>
 Ada front end           Pierre-Marie de Rodat   <derodat@adacore.com>
+COBOL front end         Robert Dubner           <rdubner@symas.com>
 c++                     Jason Merrill           <jason@redhat.com>