Message ID | f77bbf8a-33e3-ab20-57aa-10863e26039b@e124511.cambridge.arm.com |
---|---|
Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A555385AC19 for <patchwork@sourceware.org>; Fri, 10 Jan 2025 17:22:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A555385AC19 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=JvD80pCI X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20628.outbound.protection.outlook.com [IPv6:2a01:111:f403:260e::628]) by sourceware.org (Postfix) with ESMTPS id F04E8385771D for <gcc-patches@gcc.gnu.org>; Fri, 10 Jan 2025 17:21:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F04E8385771D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F04E8385771D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:260e::628 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736529664; cv=pass; b=mfVvfY1Z0acrO8HgqKCnCkQsPf7a7+5DbGVp93ZEgRTxB7cgbwLuUjScMOI+HPhJlTUh1woB9gIZX0euGAa+kt1hHuf9fUEbfI0PsvlSvAX2BmDtcycbs90cvvV2qZ1WBxv4EmJRj5rJXc4QP/IGsaiydyZgUXaYR1Qq9XP41q0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736529664; c=relaxed/simple; bh=cL/qi1M4mk3BMPLOULDatQfRf+yLrO5RyjE7nN1vAr8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=E2EXt3G+mCsr+QnJuwYob3MUxKNy9RWFPwwkNPLtdv0gccHDs+GXz1s4pYy97QUI8LJ3PAcTkbYMUH/cHxBDYnOb3uYQ0MPCu3nIb2bUlHnDLyxCMyEfqdigYjlO3459ZRo+gc0yNb7AVNkIZtdRCFqOIG/y0Rk+Icd8mmWQW9s= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n+ISq+Gpwt/7eiKqKGE7gFC1I/C/7o61XBx4pL8axNi8jXC8uk38/f8Bd2RT6UWqrhyNRzYmKE1eYPvCNIGCAOLkH5o4zuVx6Mj6Ka7F40lECRwrGMtuu8DC9KP1x9nN07hNkXlxrDebqPvFTU746FaM67MPTf9IVluZcxgKd9UHPvcFMVsan4MWmJx17PzyGwMr5BCFkrtMpmveNIMgD0zCKwTozMMovEKpW5RpXGJgaYsZlV+Qlpr7AjRrep02tcj6Ox6d/p2mivoy/VbW+KrrN9Eu/o4Ned5xblS8+cJDz3TrtcyiKQvlocxM+80euODNEC/tem3qFsIApwB8gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V2IJ9r6CDYqGtA6jMNiScGHxSEUj3GnyrqYi9SRdaYA=; b=DEcq7XFRX9qFwlqgbGXcoS2e20m1iz8ZJK848pj3epBQpxC1J37IbYzTtzxfGtS+0rl6oUxSdzQhvbxg441R1xoiSd4OocbbS3IiIMru1HOjPCsDbRjMl+eAS2edY1ENKeF3N5dY5RvUKvBBeZDLVLhB1p2WUBhOczmeJIOPyu4sf0fB29BeIzgPpFyut7eU9+7nxDUSTizIrZ4LU/3zsI05a0XDuOCpSEp3mVVv/crvSTCclBAmU5/0WGKaJd4lVAJUWU96r94q1Tb/fVBb4IeqATcI5MfxMz0ipSQnM65/Swo4sU5oC/19iJrvVsFbBOjRjQeNWawcNUzMpoBbsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V2IJ9r6CDYqGtA6jMNiScGHxSEUj3GnyrqYi9SRdaYA=; b=JvD80pCInC0e+Q54GuXwNP/Hcks0ukGGAqdmoPWJ100dOuen8NqiNLuozmXAGv3MA5BywdWGw6GwBefdSSId6VS3vYTkv8TXQ5p7UbyGnSFb0kLX6rWE78HWhaw8r2/vJgqvwy3Y6AfGE2EYxLhPcuZwZl8gDvXlVqjiod8td0I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB8255.eurprd08.prod.outlook.com (2603:10a6:10:411::9) by AS8PR08MB8826.eurprd08.prod.outlook.com (2603:10a6:20b:5bb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.12; Fri, 10 Jan 2025 17:20:59 +0000 Received: from DU0PR08MB8255.eurprd08.prod.outlook.com ([fe80::cbc8:c020:6a1b:d27a]) by DU0PR08MB8255.eurprd08.prod.outlook.com ([fe80::cbc8:c020:6a1b:d27a%3]) with mapi id 15.20.8335.011; Fri, 10 Jan 2025 17:20:58 +0000 Date: Fri, 10 Jan 2025 17:20:56 +0000 From: Andrew Carlotti <andrew.carlotti@arm.com> To: gcc-patches@gcc.gnu.org Cc: Richard Sandiford <richard.sandiford@arm.com>, Kyrylo Tkachov <ktkachov@nvidia.com> Subject: [PATCH 00/11] aarch64: Refactor target parsing Message-ID: <f77bbf8a-33e3-ab20-57aa-10863e26039b@e124511.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-ClientProxiedBy: LO4P123CA0130.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::9) To DU0PR08MB8255.eurprd08.prod.outlook.com (2603:10a6:10:411::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8255:EE_|AS8PR08MB8826:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f2af92c-4548-4ea5-b82e-08dd319b2646 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: 5B+kqH+fmOqieHw7HFU//57ru0sdln/gmY4JGpwsV8Ud/p7c5em3FbnXcjoTekdvVsX7uzzrI+7vqpUD0jdqqGKPlRt+X/iaWg4ZGUfvVALunUKntifk5WhqangDIU8oM6HPCMSmROlZjlONsS4nQ8j6LGLcR+GcS0WRkIZbMZR5Y5E8YlgjTTiVHcHOz3VkjYsMFQlUN3IJtq9HEiJs6fNnIW793129Kaagd6/8sMkWiOeUtmK/BzhIGURxkaqdpg4wfY6f0QVXvcvpVQdqEpA6gz0qnQ6OTQfYcDNlsDrx1KCBmfVCuXFbgVCWpVdUxZkqhmYLM00FC+jlP4pnwXznz41oLSAVblcwpRgf8LtEgte40Ogrg6Gbb6GyCOIKK25dsKDTvjoLTNcqd4EFkFNoZ5qRFitOg5BOZpm4kMLJEhL3yLkmCp1/gIPLVRq2y9PibV5l8ojt07OEcjyx2wc6lqZyPLF+p9n4bgcT7xKKiw57JdXaaAoY53Oi1ZrVDnPBA1O5ZtL6r7yPsKLhWxSMGGq7euqc4yu3Rt83mmIT07YRH2ae2bRthpAqyRxmvW0DHC3/RwDKUMUdMHAIRdNaXDp3L1Va59l8ajw3CykuX4de+mYImkUQdzOlGm9sRricIr7AsCg3akLiOQ/U4jY6HO6udzsjqvHZ4no3Lq9zpyjptCvuQJONts3EMbhmQehufHsP8w0c0gMoGQGjuTAqwr2m3pfAIoVf1cV4K200IduxJdImIYQFCfgd0aMBQHBo0QKhTEKP7nAdi2WB/8t3mJeq82LwPS51GJQ+GDojT9eM0cA123d6UG97tihyLYAOgyhPuud1CcuYKck/uY47DcBetcUFXTsSCXHikH96bBOIJrAQjXn4g0yYkagzIPjnICOA8iXYUj+NitHnr6DE166e3StI4/4IaLKT4RTks2o6gB7R8dN6lNkX90gD1NMJVphXE15jim8w88IQkGk+Qeapc0ByOyPYndFUBX0RuOeWCsF/8FkOofFgiE//OkTvzbpdLwYVoLDx5qyO7Few95m/Pgl24UtcVrM0dGx1WoG6v28APpo/WTZb/EMsFJy+LBiHdw0ZkKHgS+lya6ddNXKNNhVwXVeHLPWzbEuajIj+SAhetaKVG8H7osgoAFDrlF8HtpNRgEWisvI+7gjO7AWB4Atg28HyYq7p6A5XU6CJzM0X1G8yDbH0CIMWItkkp6tLMMD+a0y1r9NCpGA8Qn04z/6XAThvJbIqo7BHW1T6yQ6fbcegGRCKcfFX6qRdkpUTT2ReOVsz7cjJuRhmJ9I9KLvk7Y5jmdMkj/Lto6eUaYlkSZFYQ7hbzhlZC7W0P2qmB6Fl90WQ/aYqok2XjZEnVqwicb8/jwPSxhQ/wgtxvFfrC1q/eeor3DDu X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8255.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wpBvD25iJ0nZok+R5Y0VzhwbuFfcsqvMNQXIeCqVHNqh+GahkhViwEMv6qr52kRIMq6+48ShmeTJlZShNmsxXHJKgJQWwF3Z5cJOXCVnNawlW9ldPb2JK6diwg9lt99MMnfgw16fjo1ElC2KMyfCyX+e3Skd8VggXIm6fx4hJUSaRWNGEa9RutmEHF/O4ceY4pee20ljj9ISZnvBWzG26+inNmh3QKe8gz3W7rCPC5+5nu8a/6y5+WCJi+QAgp6ixqvCQ2A/8hYDMDRN9oIQMBfsPaU4eS0vhn0AbVFchMEe1Ho7u3h0eBztMIv3vf9bd1clGkGZqvQwKIwqsdBTFcpsHGx2qZAiDUJZBakafy/StGU0UILSiy1UYwDC558ayPp9n8wevov2p1XC+pJvBk39VqkjHSJzOOjL8FMlRMwy6VFiIsKgdNhN9jIriSWYeMjqniMTzKOoK5pBa6rqnwyLiC/MxMS/VVqdtjMk5a2i2/xIOXymVKidA7+I1CWbawDopAcRiddzRejpcX+R3Bvrv/e2T7BUB5TZ/wA1bXogogaieaNez/QYvKhVo5fN9HkkJ0XagoAy8/zoeiy/LDXogImC8ykYWD+6181wq2hqvIpha3H2jC+AeKT4yYEKDsfaYawgh+Ycoe3UDGQXkbwXHlLE3uJfTjSSo2yOFVRMiXtjUdmtprexjny2b2QDdI72tt64JXi4KROINBUfNQxBXNwm1aqdmsRtPhhuyax1CoB6O6z4uP0KXAd/2bIohG3wqzo4D72gUFU++QqFR4fU6RQraTjaUwoXt7qi7U4WjSzPVDrIF5C03RyIIEKORrM+CKoSamCI//IjXB7bS4nM6V1th3Wtk9d/wMZ5GYhplEwGQpWmgSPQ3HSeNhGuEY83mEjBWqDhsymjFyvEGlw6/gxCVZARSCeB89po9/P5d9KaGQRGuUXEZj4iVA/uXkpM5Dr5RI4J1L3TEwacBBgK8TdTjCTsbYN2hGRl5AgqrnBGNGaEn976pUj0rpjTJqUSDT1DQcHToNQVIPU/FGaHN1qnH3cqYdSfyYtTZAHA5lPb1QEwbB3FIQQLkTfqWi+Zy9xeyvkky/5wEdo6I+mgaF6+ItV6aurPwV2QmSpSlVWMm0c8CEj4Zv0niVU3W5jQBkvdH7e9yg0B0zlZ3HZRl0Vb1F9Pc2Xd+YSm3ZqNyXQDgfRtUOoD0yBgnEb/8Ittwg0yBzBociE0kJY8mz+eYS1JrGkHI/iT+lE+G3L8fTc4Uj3QK+hKzBICUd0Cq4/j16Yxmegh8bQerUvkpKbM5dTmja9uWgZO1EqnVZu3LEgsXtxGJx+iOL5q5DRF3kpVLHIAvtXkq/9WG4uFarFFLYjd84j3HnRrs6DFG0n5/4YoKFk0xQMEdiZcbSf5eQP5qHS++uZ3mNyRlvZI6hLSQPk52sQ0kzRutkiH+aMVaayUoVQef43wmxdkcw8Amt3GHou9f7S+FXlOMCxLArTntpYcl7+BOEYldxrXA++Pw6DsG5JpeeeK6QflNzk8XFWLlYiIaS+1dFUC3DdbNT5cam3zLzFyQiAswh7BBCoUmITcX4ONU5LmwPhbUfnZuJglFtW8V3n9acAE+MkJGw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f2af92c-4548-4ea5-b82e-08dd319b2646 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8255.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2025 17:20:58.9295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DDEk/ogsEuGw3VHa61M+/81Mznsh7nNVF0gLPiM9RP50GmS/HBpWIZVyqOgcHVlQVYhAYgK5k+N4844sQ8CosA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8826 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
Series |
aarch64: Refactor target parsing
|
|
Message
Andrew Carlotti
Jan. 10, 2025, 5:20 p.m. UTC
This series also fixes a couple of minor bugs (see 01/11 and 11/11). The aim of the refactor is to get all of the target parsing logic (whether via command line options, or attributes) into a single location with as much code regularity and reuse as is reasonably possible. This includes reordering functions so that each group of functions covers (where applicable) "extensions", "arch", "cpu" and "tune", in that order. I considered whether it might be possible to further combine the error handling for command line parsing and attribute parsing, but concluded that the functions were sufficiently disimilar to justify their separation. The patch series also ensures that all target strings passed to the assembler pass through the same canonicalisation, regardless of which part of the driver or compiler emits them. Previously the -march driver flag was passed directly to the assembler; this would only have been an issue when using `-march=...+aes+sha2` (or similar) in the driver's options with an old assembler version. Each commit has been built and tested with: RUNTESTFLAGS="aarch64.exp=feature-*\ spellcheck*\ mv*\ arch-diag*\ cpu-diag*\ target_attr_crypto_ice*\ aarch64-cpunative.exp=* dg.exp=march.c\ mtune.c" Additionally, I'm currently rerunning bootstrap/regression testing on the whole series. Ok for master if regression testing passes?