From patchwork Sat Jan 13 15:42:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Coplan X-Patchwork-Id: 56606 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0CF1C3858C56 for ; Sat, 13 Jan 2024 15:43:24 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) by sourceware.org (Postfix) with ESMTPS id C6EC53858D1E for ; Sat, 13 Jan 2024 15:42:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6EC53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C6EC53858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.66 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1705160579; cv=pass; b=iJKJIyb+0GSqu/yVPShcr9593t6RBQwZX+MPovP1hEKtqOl1y3e9VkjsIn+hSzdnZXhoihrotTOG1sGxNgWjLDk9Hhtoke5kO4cgY8tb5zfIFw2yeHQ7cbRMdkczu+cb+rc8E+i3dvBntaM1PGSMD3I3Rh+j+LgUOCzubY8Ttow= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1705160579; c=relaxed/simple; bh=SPuS6xMQ2eK87PY2W9sEQG2LdR4tcI0c7LuJQ9kAJQk=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=sJDNcWuQbABQwhWPx6+mMRD2UWn2/HGFNvjIRO/SGgh433UDPkcqad/rJ4pkuM0y8OlIARlYTyepy/H7vqxQKmvsX3fqGQ+UniYjRSgezPieBVh+gqF3u6tTM06222vlOEJiwBSen8SNLoRKTiiTHuKhmvFSxJTzOuaDzeqPzOo= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=V/UpTXRgq9gVkQdXzMRhCi7g2L0oCKnZEUho2gKLPiE59zlSdeuNDenHZpSU+R7TC2P2WYTVRmu3F3STlIxstTntqatWpvxHWzJAWneoHKxO3/0bwBrwuVZGze9EsKCxdK5SXH/NBytJqE/k//FeClqqqcI5vhge5fKPVhZbfReehDE+hVlyTDsO0hXnoGe0x1nMw7F3lidJTtCYkEaihHqcZ4VD5EI/DnB+T0xcLxmf+tN9Z9Ymi43XvWZ/BsDwKs1eB+EbVc6ihmv+mnwjCbIHeu5OD0h+QFCzXRlWaLy4PhJQumvdZ7NlqKj5kNL1gQ4g1J2XRRz2IKGLjfJGnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YWgehRStz2npXLSiuazFA+vT2XTPLAFl5RZeQpdDS8E=; b=hv1t/jwv2mSjDG3DvGrvyN7BZwGPxkBVbMmCY5eszTGfXAE9wWCaJ4QcBT1iQUWZ20Yzfw1XVGE5aArqEzSo/taSFgXt4iqh69/fG1KhBRzvsjLWmK0LCF76uhj8WDRnJ0wpIo+0MNKj54RfEYD0R8/lYETUO9WwtQOPZuBSh5sA7lUQfpadd+m0Z72R8zO1gkcmP0Lzt2GI+5zmjgIYjhXqmXz/kLUcCiDtAiW4JOnFSZFVu19lcnC2yv/9CbSArioTVruqWgRYq9XB+pIkFYKGOOBnCmbtZaUm6X48THJ7c9Bv1qkbfKcRNRpkJL9cvXPF5+Uuo+//MRRUv4fjYw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YWgehRStz2npXLSiuazFA+vT2XTPLAFl5RZeQpdDS8E=; b=nLrEwQIJixwJdt5zaUvCCgZh0MuGijdVRovdf1RUQB9NblufTrRFs3JHom6DyULEM3dF7U711fvzwIeTAK8IH+r124FsGILjGmGu+Y11SH7Y/9iaF7y04evdeBbu2oRW8gPZornKl5T1c4Mnj7Tamnt+9ZfbOH1tGoZz5TfY370= Received: from AM6P195CA0072.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::49) by GV2PR08MB8462.eurprd08.prod.outlook.com (2603:10a6:150:bc::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.19; Sat, 13 Jan 2024 15:42:49 +0000 Received: from AM1PEPF000252E1.eurprd07.prod.outlook.com (2603:10a6:209:87:cafe::66) by AM6P195CA0072.outlook.office365.com (2603:10a6:209:87::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21 via Frontend Transport; Sat, 13 Jan 2024 15:42:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM1PEPF000252E1.mail.protection.outlook.com (10.167.16.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.14 via Frontend Transport; Sat, 13 Jan 2024 15:42:48 +0000 Received: ("Tessian outbound c4f080b252bb:v228"); Sat, 13 Jan 2024 15:42:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0f65055215345da7 X-CR-MTA-TID: 64aa7808 Received: from 22386ef2f2e4.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1A34EB35-C953-4215-A4CA-2B14D481E224.1; Sat, 13 Jan 2024 15:42:41 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 22386ef2f2e4.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 13 Jan 2024 15:42:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F0sXd+9C9Gfb0NVL5tJMZQ/w9vYFSAKZgWG0yt0xInhU8vX1WbKqs1IZfJ8IF3agRQdE3e2SkklGiP8w7rjyBi8q280rHvV8tfAF80pB00Eo6T8wwuIA++zIA4WbH+XiLCsRHZ1YinEHKKzavi4BE4W0kvcvW7rwP/zMdzte8UkRwdRriXrmTeFPTCS8lmrsiavMW+Vg6DAUJdczHMaRUC5RAqJwSEBC9kYixCbgNjbwt7nYY2vKi3Z1ql8EXzfEFIKaMHDx5s99eEmC5/KU8q2lUJM0Aafy8iGfyiwFcnUB/eKeJ56uVD7M+Ps651+QElklm5Y1GSdul43AOfIisQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YWgehRStz2npXLSiuazFA+vT2XTPLAFl5RZeQpdDS8E=; b=VhCwH5SGgPYeL/HsQtY0hwlt/f6uQOpJB1fA62OQYC1ec/JbRnqB1pWnkdO2IxqWacw/flOBG8ElL546lSWesTDAGsZmJsV6EYZIdy9l6llG52EEwtuDm1KcXOq0sbLIJtHH7W35Lujh19u0iKevkeIdAfum8jEqc0FdhhrkhHpM2hIil5PmqcsfUH7LR5Y41mQZqpmZzxaIz4aGA4+0ym2UMiHkYjs0454iHKaIkoeNmsa7w/qy0ePX+xOTFzb2PT77RXeuvdyEs18BIyUBer3Ycmat7/jIbRDEoFO7+vMHUJo9pEkUnEGLR6lzh4RKA1Z2IYFxbivvOWox6CI2wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YWgehRStz2npXLSiuazFA+vT2XTPLAFl5RZeQpdDS8E=; b=nLrEwQIJixwJdt5zaUvCCgZh0MuGijdVRovdf1RUQB9NblufTrRFs3JHom6DyULEM3dF7U711fvzwIeTAK8IH+r124FsGILjGmGu+Y11SH7Y/9iaF7y04evdeBbu2oRW8gPZornKl5T1c4Mnj7Tamnt+9ZfbOH1tGoZz5TfY370= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) by DB9PR08MB8484.eurprd08.prod.outlook.com (2603:10a6:10:3d4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.23; Sat, 13 Jan 2024 15:42:39 +0000 Received: from PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::48ca:fbcb:84bf:ed17]) by PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::48ca:fbcb:84bf:ed17%4]) with mapi id 15.20.7181.015; Sat, 13 Jan 2024 15:42:39 +0000 Date: Sat, 13 Jan 2024 15:42:28 +0000 From: Alex Coplan To: gcc-patches@gcc.gnu.org Cc: Richard Sandiford , Kyrylo Tkachov , Richard Earnshaw Subject: [PATCH 0/4] aarch64, rtl-ssa: Fix wrong code in ldp fusion pass [PR113070] Message-ID: Content-Disposition: inline X-ClientProxiedBy: LO4P123CA0658.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::7) To PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAWPR08MB8958:EE_|DB9PR08MB8484:EE_|AM1PEPF000252E1:EE_|GV2PR08MB8462:EE_ X-MS-Office365-Filtering-Correlation-Id: ad03ea6f-01fd-49ad-089c-08dc144e4ba9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Nu1/V+v6c1Z6kU1gIqg0vlgDE1kkZXGrG85PRA9yS71fE5r4TJYhz5+RILBMBdiO0hRYEpjIG5x8uc/5AvBI+KphYLPnlBkeiArwpoVgr4QtO95W5bMIFpYeC33GHLPAqinspxD+7Vm4Dh5x1yVn+72ECKMoeKb34QC4YXHG2Ix1Jx5aDDzynPvcCAObvBA3tgW/bsVDtW6dNbkkAbwRpV2LGhuONMwzAuxfCU9nnp50x9hDh7ciOpS5eHpJiL0JSlDK82ZzHJ+rYIOBgjYT7UcaxtNnK8EHq+N2B92+TH8eWR4UoHZUpBMrW4D5sOcPrwsKl/27YbAEVmv98J0ewWds/zT4hjuJq4qePAnDgfVfRtURlYX1/TK26L+ujgYxXm2h4/nB5ZjxXL334e1sksF+hy61Pgc+vXh7Tub8Z0vpnArowXlaegKU26gbsUHA10R23U9rzf5DKuMdRsLIsy2HWc4p7wbiTI5nUx+Pnnx9xWDkEEfkyooW0PkXXFD8i0SMEZbvc4gHuX8YmnMJ38I89c0A6IO9lRQ9tPjW8sA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAWPR08MB8958.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(376002)(346002)(136003)(39860400002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(86362001)(38100700002)(26005)(2616005)(36756003)(83380400001)(6512007)(6506007)(6666004)(966005)(316002)(6486002)(66946007)(54906003)(66556008)(66476007)(6916009)(2906002)(44832011)(8676002)(5660300002)(4326008)(478600001)(8936002)(41300700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8484 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252E1.eurprd07.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 39ad769f-82cb-4074-35a8-08dc144e45e8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5ri+cTeyzpcR5LNg0KY0qgPHCvWNt+WAVYOLA7FGcLSPsygG7QalJt+b3eqZqClcB7iu1XpBCglj7DzSziDObiLK0xKyQyYybRv2rD7i3K0wvF+OMEcT4gf144noaHuAS7M77Uh1D2K6oc9dxDyi5MweyThpwfrDtoGBfdu7eY3gfUbsHGvubvCQ39Sc4dAWSHk7AhgZOl9jEzNYk4INBiJjqAXRwEutF3dmflVKm65nfR9Neku1od0xx9maJ+Xq+7EIqGG8C6bLZWnB7EKULtXGfz322whhGmz/yIQpl5skA8C+oX4k8DJeDAPnboJd+CvaIPRG/3DPsQvI9KYx1JxxlFj5Szg9voHR55o86bSkPdH0RpNtore8PgJFS8lLe8IxA1MYByqLkdZ56a5DAB/waMpRGXtJiRxcpR/1u+1FQErA5POXWw39ASAhAFxzqXPguLWtj/lcQBUTZR+Czz/fD6jyMtigF9lQLRkj1H9U1gto4bW7lLNZHRK+bGXqMqjEHRnXSrrB2jhOcKISjE0UVhsVwgC3dN+4VchqRsfuR3XwfDcABvs7qvhPxLUs9+nMFU+tb2OE+F1Bk7kAkQ8AEcTNpx0v95drmrklTRvUcnNe/vlO+1URb2BV8u0SKCMX1wsw9kB8wKnBnFPDaaNtoOK7VXddU2a67jw4GGkDZjjm/ueHLev2xDTomdkdMusgxDEr9TWmhAs2bJCkMDw53pyJ1CiuWZNqCZ1Yrro= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(376002)(396003)(346002)(39860400002)(230922051799003)(64100799003)(451199024)(1800799012)(82310400011)(186009)(40470700004)(46966006)(36840700001)(41300700001)(36860700001)(478600001)(966005)(86362001)(82740400003)(6486002)(6506007)(40480700001)(316002)(2906002)(54906003)(83380400001)(356005)(81166007)(26005)(5660300002)(70206006)(70586007)(6666004)(2616005)(36756003)(6916009)(40460700003)(336012)(4326008)(8676002)(8936002)(6512007)(44832011)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2024 15:42:48.8516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad03ea6f-01fd-49ad-089c-08dc144e4ba9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000252E1.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8462 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org This patch series restores PGO+LTO bootstrap on aarch64 (with the ldp passes enabled) and fixes wrong code (leading to a segfault) seen in cactuBSSN_r from SPEC CPU 2017 with PGO+LTO enabled. For an example showing what goes wrong, see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113070#c7 In the case that we insert a new stp insn (as opposed to re-purposing an existing store) RTL-SSA fails to properly insert the newly-created def of memory into the def chain and the ldp/stp pass fails to update uses of memory immediately following an stp insn. This can lead to alias analysis going wrong as it ends up incorrectly skipping over the stp insn when analysing subsequent load pair candidates. Bootstrapped/regtested as a series with/without the passes enabled on aarch64-linux-gnu (1/4 also tested independently and no regressions). OK for trunk? Thanks, Alex Alex Coplan (4): rtl-ssa: Run finalize_new_accesses forwards [PR113070] rtl-ssa: Support for creating new uses [PR113070] rtl-ssa: Ensure new defs get inserted [PR113070] aarch64: Fix up uses of mem following stp insert [PR113070] gcc/config/aarch64/aarch64-ldp-fusion.cc | 248 ++++++++++++++++++----- gcc/rtl-ssa.h | 1 + gcc/rtl-ssa/accesses.cc | 10 + gcc/rtl-ssa/changes.cc | 71 +++++-- gcc/rtl-ssa/functions.h | 11 +- 5 files changed, 269 insertions(+), 72 deletions(-)