From patchwork Wed Jun 7 13:59:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Coplan X-Patchwork-Id: 55821 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C03DE385771F for ; Wed, 7 Jun 2023 14:00:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C03DE385771F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686146454; bh=7S+bzTFVP4GIV/qsj9pPrOgWBqRAenAYwNFv7l3h/Z0=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=URz3GORefDVJZ+4BEJb5xGDGZsbSP6QS4uWWlLjt4MBk9+QnJnXE5k+6CZg2kKAFs ZRfqazcNQTo/oYS87YjpuK72I053Z9+Yy/hXzOnVWnGV7xsPNDh+bqPopBiVS3PkEm arotEwwp3WQQM/GZWC10UZKeqiU5rdcJFDjvQZzg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2043.outbound.protection.outlook.com [40.107.21.43]) by sourceware.org (Postfix) with ESMTPS id 038953858C54 for ; Wed, 7 Jun 2023 14:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 038953858C54 Received: from DB8PR06CA0034.eurprd06.prod.outlook.com (2603:10a6:10:100::47) by AM8PR08MB5588.eurprd08.prod.outlook.com (2603:10a6:20b:1d4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Wed, 7 Jun 2023 14:00:12 +0000 Received: from DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::ad) by DB8PR06CA0034.outlook.office365.com (2603:10a6:10:100::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend Transport; Wed, 7 Jun 2023 14:00:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT059.mail.protection.outlook.com (100.127.142.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.19 via Frontend Transport; Wed, 7 Jun 2023 14:00:12 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Wed, 07 Jun 2023 14:00:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6519a877007fbcf0 X-CR-MTA-TID: 64aa7808 Received: from 5ef15294de6b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4EBC4D8D-46A0-4450-A1AE-4D47BF9A1DD2.1; Wed, 07 Jun 2023 14:00:01 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5ef15294de6b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Jun 2023 14:00:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MUTgCPlCfELk4W6slQDzQUuIhZTF7T3Uay1Cl9nUQKfQ/MawePcHxpuvzDXNDMd2B3bGEctAv38KRlplA+O88rqPR2S0m2vQKu5oh8SnhEe3GqZDn/+pnVQEZCeIY53hZvFpgnfw6Q4wIihVeTcctTCyuSHu+qo1nbpUY/g7QZsvCsj9CNcOqOBDsRjbOcb7aExLRDBDYQ9I2eW/UJJVn+aXHu0mwPnnZEMx4QMwUhYPMXZMwA2X69NP9dP5vuuPh9/JCbaXXdZl0uc/P21/O+tqHOQ+YOKjg+Mt1ClULXHorPX5EoZuHfl+rBbEtL9YuUhD0AwCIC8E8em59klU0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7S+bzTFVP4GIV/qsj9pPrOgWBqRAenAYwNFv7l3h/Z0=; b=OPNeoqiNzNtW/AMdmkaXYTWAdcjf8G+DsGXbQKATfJ7cTztsJJ3eIicXnZp8ftJczg2WJuI+tXx/J1dgnvDelumMUnLlRY9tnLJnzKi6ocl3fJz51ZXJzLUKdcCJotzHm69CXerrsq67yBSTGhN+LwuQXa8yDvQ/IagO4E1t+srdm82U+DJtoHcxchGuo8Rs5CNEz2lBTgNFiAwFATARIEA1NX+DFpOvghMxscA1fUGuV2zGbC4MKz6KSQNuGO72yAbIBCDW3gcJ5wnQHG2xXB1lOyD7LIOExLHG1SEn3JIvdsBUcgmmQwrqpuyOmEbyAudNy2L1FbCSr2nnOV56Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAXPR08MB7201.eurprd08.prod.outlook.com (2603:10a6:102:20b::17) by PA4PR08MB5933.eurprd08.prod.outlook.com (2603:10a6:102:f0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Wed, 7 Jun 2023 13:59:57 +0000 Received: from PAXPR08MB7201.eurprd08.prod.outlook.com ([fe80::5b72:ef2:156a:296a]) by PAXPR08MB7201.eurprd08.prod.outlook.com ([fe80::5b72:ef2:156a:296a%6]) with mapi id 15.20.6455.030; Wed, 7 Jun 2023 13:59:57 +0000 Date: Wed, 7 Jun 2023 14:59:49 +0100 To: gcc-patches@gcc.gnu.org Cc: Richard Earnshaw , Richard Sandiford , Kyrylo Tkachov Subject: [PATCH 0/3] aarch64: ls64 builtin fixes [PR110100,PR110132] Message-ID: Content-Disposition: inline X-ClientProxiedBy: SA9PR13CA0062.namprd13.prod.outlook.com (2603:10b6:806:23::7) To PAXPR08MB7201.eurprd08.prod.outlook.com (2603:10a6:102:20b::17) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7201:EE_|PA4PR08MB5933:EE_|DBAEUR03FT059:EE_|AM8PR08MB5588:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a57c1da-acc2-426d-3241-08db675f8329 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: R2lw4QdYBUH69TOGh0s5v0cbN15YhSCXYqfIYGzWtwwk4lTvWBJIyxYqfnWZhgTxzKp3jix2sXdCKHroCnEycz4wNgPwVTOb50EH18ON/eorRYbCae6ZaIA7FtTYWSeXYm1WVrMSPHHaBVeAVN+n8jSch2FOUnV46aogPu9cHxVavPXh9DvgGmM6zveLbxHCeHCcZupIHBSmj+LVboMbAI10LJsM6KtRJvo1t7KE36ujBV6xeFqkejiBgS5aTgzfmYQAMwhMbpjz1EXCKS9b6BMVf5jKxx/AuAvVuIBXPpyjpy5vwQA1AwyijD5hRUrjQKyvN02XPEGHI3Geh0k6aTFOLppgShP/+wvRloges1MOZ/pu4CcCPS3piuQwkeTKaUfbg4NsYq5jSxIQWvEManW54NxA6dGNjJZ+rVGotsmF8o8kc9vApDeEKrwyOGL060y3lJvV4pCAUYuQWR7s7pNaeCozsFYATvHMFpbOIVCcVqvBqEt9aNf4oJ73p3fE5tb0Zu13oSZVyyxFkZAKKyqHvBCGMfTZWw/sZgR3s0BBbb2VzMJbPgd2FXcKVrjr X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB7201.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(451199021)(478600001)(2906002)(6486002)(36756003)(6666004)(2616005)(83380400001)(86362001)(6512007)(6506007)(38100700002)(26005)(186003)(5660300002)(316002)(8676002)(66946007)(6916009)(8936002)(66556008)(4326008)(66476007)(44832011)(54906003)(41300700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5933 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 99a2dbe5-94c1-4b9a-7747-08db675f7a49 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DCVstrcDZqKeSRSRXkIDEyUatLvixEDFi0n/5c36ZKhIoiThXVZRnGevDwrS4hjHEoPuUIsptfob4exCx1SnVzX2Bbzdmrg6bFryzn93yPv8Ig83lvv0S067anfLI+rqOhXxF4s26KQRpwgFW23ky0yfOrNQXJ1NJo/vcBFCqLkBi92HfHnYdAJNDirnOgQ+SSfd3GsPimixWSWWj8QE3YGkmoEmrLKe0hUjPuYq0xtprahIW3ina8o3Q/26S8ShcFMszoL1nl72lIEAa3sXcNVUI/28GN5rulV+mz8wYyyY2ny9/2RrTn4WW8qUILqkfYdbyowwAvZz5EG8PwBVZrhoKqQ96cGxOD7Z23Og/YrVcJCoABC5bnirQTRmsL/IHRbPXi67Nr+LHkNfVAUnripA4l1lBJi1UTNNOwY8DXvtDVL/EREQebqLKdgngfAvVsYwmkr3KJ6bnpPfho93q52wwe/Nuj1YME7U9HvRv8EJ5+HVrQt2eAxUu7bsOt0VdgiyaYPM7wL3l6V6u29wQZ9Jxzp4O4Z266kvk6c5ev4KU8YpzONXyqgiDM6rQPYLYNFwb21S+72bbx+vfq3dNOvANmx4oVjRTkPtoHGPl+vLibPiRbBqtCLekkH/CvLpON4EruFuj87zMHqOG3FINebva+yA6svI1HELDMecITjkcFN+GD1JS9orJcoZFP4kVfqUyxzWSnWaXO5dKHikAnwuhtBeOI8AVbuK7KIOCL1iN2V457fCmEyWg4nDYvFj X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199021)(40470700004)(46966006)(36840700001)(47076005)(82310400005)(83380400001)(336012)(478600001)(82740400003)(44832011)(40480700001)(8936002)(8676002)(356005)(316002)(70586007)(70206006)(81166007)(4326008)(6916009)(5660300002)(40460700003)(86362001)(41300700001)(6666004)(2906002)(6486002)(54906003)(36756003)(36860700001)(6512007)(186003)(6506007)(26005)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 14:00:12.2970 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a57c1da-acc2-426d-3241-08db675f8329 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5588 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alex Coplan via Gcc-patches From: Alex Coplan Reply-To: Alex Coplan Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi, This patch series fixes various defects with the FEAT_LS64 ACLE implementation in the AArch64 backend. The series is organised as follows: - Patch 1/3 fixes whitespace errors in the existing code. - Patch 2/3 fixes PR110100 where we generate wrong code for the st64b builtin. - Patch 3/3 fixes PR110132, allowing the compiler to define the ACLE builtins directly, and also makes the builtins work under LTO. Bootstrapped/regtested as a series on aarch64-linux-gnu. OK for trunk and backports back to GCC 12? Thanks, Alex Alex Coplan (3): aarch64: Fix whitespace in ls64 builtin implementation [PR110100] aarch64: Fix wrong code with st64b builtin [PR110100] aarch64: Allow compiler to define ls64 builtins [PR110132] gcc/config/aarch64/aarch64-builtins.cc | 88 +++++++++++-------- gcc/config/aarch64/aarch64.md | 24 ++--- gcc/config/aarch64/arm_acle.h | 33 ------- .../g++.target/aarch64/acle/acle.exp | 35 ++++++++ gcc/testsuite/g++.target/aarch64/acle/ls64.C | 10 +++ .../g++.target/aarch64/acle/ls64_lto.C | 10 +++ .../gcc.target/aarch64/acle/ls64_lto.c | 10 +++ .../gcc.target/aarch64/acle/pr110100.c | 7 ++ .../gcc.target/aarch64/acle/pr110132.c | 15 ++++ gcc/testsuite/lib/target-supports.exp | 2 +- 10 files changed, 151 insertions(+), 83 deletions(-) create mode 100644 gcc/testsuite/g++.target/aarch64/acle/acle.exp create mode 100644 gcc/testsuite/g++.target/aarch64/acle/ls64.C create mode 100644 gcc/testsuite/g++.target/aarch64/acle/ls64_lto.C create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/ls64_lto.c create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/pr110100.c create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/pr110132.c