| Message ID | 20260707214457.1628003-1-hjl.tools@gmail.com |
|---|---|
| Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C84D94BA23C2 for <patchwork@sourceware.org>; Tue, 7 Jul 2026 21:46:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C84D94BA23C2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=SeXjyLIu X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id D1D454BA2E16 for <gcc-patches@gcc.gnu.org>; Tue, 7 Jul 2026 21:45:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1D454BA2E16 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1D454BA2E16 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783460708; cv=none; b=bme8Vll4qGTpBmGu/p7rKhhlay5mC6GmJoKzsW23xXxgQwT+uAP6Kkmhg48lpxTJRhaaKUxa9HTy80D+p0iYfcftr2NcwstnZicunmZMUtvqMQxJFxlryYL3qVtXfCQHY5ukaP0d9pPOOfXWRe9MsgGV93CFtqacfHoU3zhUo6o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783460708; c=relaxed/simple; bh=pt2+19LsOk1EUOAtikNHMG5a5gPV7ZPoUAV5q80D+nA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VuWdBHukHMpnCUgIFdF034R4Jfe1EGcs/vjLx+B2utYoD3Uxg5rUCk/6MV2tk4wPaMmL+RLoRa7AQHO/mAxa/8fm9KgViKB7qNsuOgvbVu1VPAZu9eK2im8IMf0YyRGzgWVM2TjkZER9HCFNKIHFGLUjmF8A3l5DPayRqHdgjU4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=SeXjyLIu DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D1D454BA2E16 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-c966b9ee9cbso2226664a12.1 for <gcc-patches@gcc.gnu.org>; Tue, 07 Jul 2026 14:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783460706; x=1784065506; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=WaG1oWU1KLyQ4vv7bklnqWijNfd8wCMOFNhfIs7JM1Q=; b=SeXjyLIuFJkNf9bvOUq2YgOpaMXZIk8bAd7QrB/8IQfjAUDjWC5EtQDLXRy4hngS0p YvWX7YlhGP+Qj8WIvAlzPO/Vz15lGppKyL/N2xKRYcgh3Ql7r2yaQWimQh7wMSskhual iWEg9akxqxZ7NIsaWGK/9J0s7CX8fLkrP6JV7qQR7UTqr/eaZi4HvD2kH3XFuFNselXo /d4dtS9WOOExssne+huokj4u/DVVW9+6jQ1hRG7NgkW3IvJnmr+PZTL7HttKlYqjvt4o hoEY3iopMfZMQYyWi2TuPMVrni9MWE259e19qLKYTttbID6FdZ/22GJ5dd0urMy6uLB/ 2l4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783460706; x=1784065506; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WaG1oWU1KLyQ4vv7bklnqWijNfd8wCMOFNhfIs7JM1Q=; b=fyYdvSGY/gUQDRTCpoAzzhgIkbYlUZze6Uv9wUBCRaPPe6ruxf5IKuPrG5vtDuQLTN cDmZ3BTbyo4qThmaOj/5VkFlPHmcR5kE7V21FzfYdIxUsQd0DVCO7aFz6fUVYqiUNz62 QuX2MAvPXnm0nIIzH+xwOFNBeWjGNPkUuuJ8vNyZE4sGNk/m//eiWY9QAuPguI8+SDy5 G2wacdsNyZqh6cERnTka2gEWyvcBl3UqrfYDMvZb7+iB1E6sdqfoZqBMWODRA+31/Aqk 7UZ/WiP2PmIjAtQoytFBm3Av5sJV2j5QoqE0ml5ICJrB03fB3jQ4iKQXxXOqgrLrYn/K k5lw== X-Gm-Message-State: AOJu0YxN2PvyeQixdC/VbUDnsYxrcZxrLvy1a5TvRAxWpzoWlxf8fn1O dZ857erBM9TJhOqldGQeqJGm2o186Se+njWZ11SmqSOJ0fKVwmtqMXr7V2Xa0fcTMYA= X-Gm-Gg: AfdE7cmLvCPdUC972tUoVWukWNn1lbLesklcxdwAUld0blKkmv7ldkjou/ixX6dFvTL XvFvhdmjhNGDtpF0ON9HPCP0pwNvtp2GultkrGnm9dAJpTQLyakXcebahKl8kCiX/KLjrgJoz+m hFd3jZBOh/74WaJac9QsDPQbPn3EJFwJJ2DvyC5ZOtg5XT9iMCSryNNfIq5/YN8fdzid66Y+Dne uXYTex0EaY+QCicF2cr/IiBbHlJsUbtDcz9RQiXKWEhbpjjGZif4Vxf7m/qoOY01z674MfvOk73 FL6R3xG4TFmPgpHZDcVnArI0wYHtfRWxOwIzElrSkcrhSrebxK6ZTs+KZdnbKifGL5c00L4OGFf Pa3vktLk4gqgngDtNms35R9YCzfv0MgCQAi2W8mxhkViSq97kpMjadOIDC7QAzj7z8fMnH0mQm7 KKeTyLy/OWMWTNuKSrmVaorrLbe7AvLFqxR6XG3PVLrtPVMBA= X-Received: by 2002:a05:6a20:a105:b0:3c0:9c19:6595 with SMTP id adf61e73a8af0-3c09c1967e3mr4999296637.61.1783460706364; Tue, 07 Jul 2026 14:45:06 -0700 (PDT) Received: from gnu-tgl-3.localdomain ([172.56.176.93]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b6594f6a9sm12787629c88.5.2026.07.07.14.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 14:45:05 -0700 (PDT) Received: from gnu-tgl-3.localdomain (localhost [127.0.0.1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id 46073C1B52; Wed, 08 Jul 2026 05:45:02 +0800 (CST) From: "H.J. Lu" <hjl.tools@gmail.com> To: gcc-patches@gcc.gnu.org Cc: rdsandiford@googlemail.com, ubizjak@gmail.com, hongtao.liu@intel.com Subject: [PATCH v4 0/4] x86: Implement TARGET_FNTYPE_ABI Date: Wed, 8 Jul 2026 05:44:53 +0800 Message-ID: <20260707214457.1628003-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3001.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_PBL, RCVD_IN_XBL, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
| Series | x86: Implement TARGET_FNTYPE_ABI | |
Message
H.J. Lu
July 7, 2026, 9:44 p.m. UTC
Changes in v4: 1. Use default_function_abi, instead of ix86_tls_get_addr_abi(), in ix86_emit_tls_call to get call clobbered registers for GNU TLS calls. Changes in v3: 1. Don't preserve MMX nor X87 registers. 2. Handle return struct pair with int64 and double in AX and XMM0 registers. Changes in v2: 1. Add ix86_tls_get_addr_abi and use it to set CALL_INSN_ABI_ID. --- This patch set implements TARGET_FNTYPE_ABI for x86 to avoid unnecessary spills when calling no_caller_saved_registers functions: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=124798 and spill callee-saved registers when calling __tls_get_addr from a ms_abi function: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125436 The first 3 patches update the x86 backend for TARGET_FNTYPE_ABI and the last one implements TARGET_FNTYPE_ABI. H.J. Lu (1): x86: Implement TARGET_FNTYPE_ABI Richard Sandiford (3): i386: Split out call_saved_registers_type detection i386: Avoid reading call_used_regs i386: Avoid always-true condition gcc/config/i386/i386-expand.cc | 113 +---- gcc/config/i386/i386-features.cc | 17 +- gcc/config/i386/i386-options.cc | 152 ++++--- gcc/config/i386/i386-protos.h | 5 +- gcc/config/i386/i386.cc | 386 ++++++++++++++---- gcc/config/i386/i386.md | 32 +- gcc/testsuite/gcc.target/i386/abi-mix-1.c | 21 + gcc/testsuite/gcc.target/i386/abi-mix-2.c | 7 + .../gcc.target/i386/no-callee-saved-18.c | 2 - .../gcc.target/i386/no-callee-saved-19b.c | 32 +- .../gcc.target/i386/no-callee-saved-19d.c | 6 +- .../gcc.target/i386/no-callee-saved-19e.c | 33 +- .../gcc.target/i386/no-callee-saved-2.c | 10 +- .../gcc.target/i386/no-callee-saved-20.c | 92 +++++ .../gcc.target/i386/no-callee-saved-8.c | 8 +- .../gcc.target/i386/no-callee-saved-9.c | 10 +- .../gcc.target/i386/no-caller-saved-1-ms.c | 50 +++ .../gcc.target/i386/no-caller-saved-1-sysv.c | 46 +++ .../gcc.target/i386/no-caller-saved-1.c | 50 +++ .../gcc.target/i386/no-caller-saved-10.c | 17 + .../gcc.target/i386/no-caller-saved-11.c | 19 + .../gcc.target/i386/no-caller-saved-2.c | 49 +++ .../gcc.target/i386/no-caller-saved-3.c | 49 +++ .../gcc.target/i386/no-caller-saved-4.c | 44 ++ .../gcc.target/i386/no-caller-saved-5.c | 34 ++ .../gcc.target/i386/no-caller-saved-6.c | 34 ++ .../gcc.target/i386/no-caller-saved-7.c | 49 +++ .../gcc.target/i386/no-caller-saved-8.c | 51 +++ .../gcc.target/i386/no-caller-saved-9.c | 51 +++ gcc/testsuite/gcc.target/i386/pr119784b.c | 33 +- gcc/testsuite/gcc.target/i386/pr125436-1a.c | 130 ++++++ gcc/testsuite/gcc.target/i386/pr125436-1b.c | 81 ++++ gcc/testsuite/gcc.target/i386/pr125436-2a.c | 132 ++++++ gcc/testsuite/gcc.target/i386/pr125436-2b.c | 83 ++++ gcc/testsuite/gcc.target/i386/pr125436-3.c | 88 ++++ gcc/testsuite/gcc.target/i386/pr125436-4.c | 88 ++++ .../gcc.target/i386/preserve-none-14.c | 2 - .../gcc.target/i386/preserve-none-23.c | 2 - .../gcc.target/i386/preserve-none-7.c | 10 +- 39 files changed, 1777 insertions(+), 341 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/abi-mix-1.c create mode 100644 gcc/testsuite/gcc.target/i386/abi-mix-2.c create mode 100644 gcc/testsuite/gcc.target/i386/no-callee-saved-20.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-1-ms.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-1-sysv.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-1.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-10.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-11.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-2.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-3.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-4.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-5.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-6.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-7.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-8.c create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-9.c create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-1a.c create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-1b.c create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-2a.c create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-2b.c create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-3.c create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-4.c
Comments
On Wed, Jul 8, 2026 at 5:46 AM H.J. Lu <hjl.tools@gmail.com> wrote: > > Changes in v4: > > 1. Use default_function_abi, instead of ix86_tls_get_addr_abi(), in > ix86_emit_tls_call to get call clobbered registers for GNU TLS calls. Ok. > > Changes in v3: > > 1. Don't preserve MMX nor X87 registers. > 2. Handle return struct pair with int64 and double in AX and XMM0 > registers. > > Changes in v2: > > 1. Add ix86_tls_get_addr_abi and use it to set CALL_INSN_ABI_ID. > > --- > This patch set implements TARGET_FNTYPE_ABI for x86 to avoid unnecessary > spills when calling no_caller_saved_registers functions: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=124798 > > and spill callee-saved registers when calling __tls_get_addr from a ms_abi > function: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125436 > > The first 3 patches update the x86 backend for TARGET_FNTYPE_ABI and the > last one implements TARGET_FNTYPE_ABI. > > H.J. Lu (1): > x86: Implement TARGET_FNTYPE_ABI > > Richard Sandiford (3): > i386: Split out call_saved_registers_type detection > i386: Avoid reading call_used_regs > i386: Avoid always-true condition > > gcc/config/i386/i386-expand.cc | 113 +---- > gcc/config/i386/i386-features.cc | 17 +- > gcc/config/i386/i386-options.cc | 152 ++++--- > gcc/config/i386/i386-protos.h | 5 +- > gcc/config/i386/i386.cc | 386 ++++++++++++++---- > gcc/config/i386/i386.md | 32 +- > gcc/testsuite/gcc.target/i386/abi-mix-1.c | 21 + > gcc/testsuite/gcc.target/i386/abi-mix-2.c | 7 + > .../gcc.target/i386/no-callee-saved-18.c | 2 - > .../gcc.target/i386/no-callee-saved-19b.c | 32 +- > .../gcc.target/i386/no-callee-saved-19d.c | 6 +- > .../gcc.target/i386/no-callee-saved-19e.c | 33 +- > .../gcc.target/i386/no-callee-saved-2.c | 10 +- > .../gcc.target/i386/no-callee-saved-20.c | 92 +++++ > .../gcc.target/i386/no-callee-saved-8.c | 8 +- > .../gcc.target/i386/no-callee-saved-9.c | 10 +- > .../gcc.target/i386/no-caller-saved-1-ms.c | 50 +++ > .../gcc.target/i386/no-caller-saved-1-sysv.c | 46 +++ > .../gcc.target/i386/no-caller-saved-1.c | 50 +++ > .../gcc.target/i386/no-caller-saved-10.c | 17 + > .../gcc.target/i386/no-caller-saved-11.c | 19 + > .../gcc.target/i386/no-caller-saved-2.c | 49 +++ > .../gcc.target/i386/no-caller-saved-3.c | 49 +++ > .../gcc.target/i386/no-caller-saved-4.c | 44 ++ > .../gcc.target/i386/no-caller-saved-5.c | 34 ++ > .../gcc.target/i386/no-caller-saved-6.c | 34 ++ > .../gcc.target/i386/no-caller-saved-7.c | 49 +++ > .../gcc.target/i386/no-caller-saved-8.c | 51 +++ > .../gcc.target/i386/no-caller-saved-9.c | 51 +++ > gcc/testsuite/gcc.target/i386/pr119784b.c | 33 +- > gcc/testsuite/gcc.target/i386/pr125436-1a.c | 130 ++++++ > gcc/testsuite/gcc.target/i386/pr125436-1b.c | 81 ++++ > gcc/testsuite/gcc.target/i386/pr125436-2a.c | 132 ++++++ > gcc/testsuite/gcc.target/i386/pr125436-2b.c | 83 ++++ > gcc/testsuite/gcc.target/i386/pr125436-3.c | 88 ++++ > gcc/testsuite/gcc.target/i386/pr125436-4.c | 88 ++++ > .../gcc.target/i386/preserve-none-14.c | 2 - > .../gcc.target/i386/preserve-none-23.c | 2 - > .../gcc.target/i386/preserve-none-7.c | 10 +- > 39 files changed, 1777 insertions(+), 341 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/i386/abi-mix-1.c > create mode 100644 gcc/testsuite/gcc.target/i386/abi-mix-2.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-callee-saved-20.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-1-ms.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-1-sysv.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-1.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-10.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-11.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-2.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-3.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-4.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-5.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-6.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-7.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-8.c > create mode 100644 gcc/testsuite/gcc.target/i386/no-caller-saved-9.c > create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-1a.c > create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-1b.c > create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-2a.c > create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-2b.c > create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-3.c > create mode 100644 gcc/testsuite/gcc.target/i386/pr125436-4.c > > -- > 2.55.0 >